| Message ID | 1435248289-16477-1-git-send-email-ira.weiny@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 06/25/2015 09:04 AM, ira.weiny@intel.com wrote: > From: Ira Weiny <ira.weiny@intel.com> > > The define OPA_LID_PERMISSIVE is big endian and was compared to cpu value > opa_drslid. > > 0-day build caught this while building with the OPA (hfi1) driver which was > recently sent to the list. > > Fixes: 8e4349d13f33 (IB/mad: Add final OPA MAD processing) Hello Ira, For future patches please make sure that the subject of the patch describes what has been fixed instead of referring to the tool that detected the issue. Thanks, Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/25/2015 8:28 PM, Bart Van Assche wrote: > On 06/25/2015 09:04 AM, ira.weiny@intel.com wrote: >> From: Ira Weiny <ira.weiny@intel.com> >> >> The define OPA_LID_PERMISSIVE is big endian and was compared to cpu >> value >> opa_drslid. >> >> 0-day build caught this while building with the OPA (hfi1) driver >> which was >> recently sent to the list. >> >> Fixes: 8e4349d13f33 (IB/mad: Add final OPA MAD processing) > > Hello Ira, > > For future patches please make sure that the subject of the patch > describes what has been fixed instead of referring to the tool that > detected the issue. > Also, Ira, make sure to avoid two patches with the same name in the same series, such as f28990b IB/mad: Add partial Intel OPA MAD support 548ead1 IB/mad: Add partial Intel OPA MAD support Maybe you should ask Sean to go over patch titles and change-logs till you'll be up to speed on how this should be done, he has lots of kernel experience Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/25/2015 12:04 PM, ira.weiny@intel.com wrote: > From: Ira Weiny <ira.weiny@intel.com> > > The define OPA_LID_PERMISSIVE is big endian and was compared to cpu value > opa_drslid. > > 0-day build caught this while building with the OPA (hfi1) driver which was > recently sent to the list. > > Fixes: 8e4349d13f33 (IB/mad: Add final OPA MAD processing) > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com> > Reviewed-by: John, Jubin <jubin.john@intel.com> > > --- > Changes from V2 > Really update the commit message I made some changes to the commit message, but patch was taken as is. > > drivers/infiniband/core/mad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c > index a4b1466c1bf6..9c90a729db62 100644 > --- a/drivers/infiniband/core/mad.c > +++ b/drivers/infiniband/core/mad.c > @@ -794,7 +794,7 @@ static int handle_outgoing_dr_smp(struct ib_mad_agent_private *mad_agent_priv, > goto out; > } > opa_drslid = be32_to_cpu(opa_smp->route.dr.dr_slid); > - if (opa_drslid != OPA_LID_PERMISSIVE && > + if (opa_drslid != be32_to_cpu(OPA_LID_PERMISSIVE) && > opa_drslid & 0xffff0000) { > ret = -EINVAL; > dev_err(&device->dev, "OPA Invalid dr_slid 0x%x\n", >
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index a4b1466c1bf6..9c90a729db62 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -794,7 +794,7 @@ static int handle_outgoing_dr_smp(struct ib_mad_agent_private *mad_agent_priv, goto out; } opa_drslid = be32_to_cpu(opa_smp->route.dr.dr_slid); - if (opa_drslid != OPA_LID_PERMISSIVE && + if (opa_drslid != be32_to_cpu(OPA_LID_PERMISSIVE) && opa_drslid & 0xffff0000) { ret = -EINVAL; dev_err(&device->dev, "OPA Invalid dr_slid 0x%x\n",