diff mbox

[1/2] IB/core: Remove unnecessary defines from ib_mad.h

Message ID 1441233955-31743-1-git-send-email-ira.weiny@intel.com (mailing list archive)
State Accepted
Headers show

Commit Message

Ira Weiny Sept. 2, 2015, 10:45 p.m. UTC
From: Ira Weiny <ira.weiny@intel.com>

Remove the unused IB_NOTICE_REPRESS_* defines.

When the hfi1 driver was added these definitions were moved from the qib driver
to ib_mad.h.  They should have been removed instead.

Fixes: d4ab347005fb ("IB/core: Add core header changes needed for OPA")
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
 include/rdma/ib_mad.h | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Hal Rosenstock Sept. 3, 2015, 5:40 p.m. UTC | #1
On 9/2/2015 6:45 PM, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> Remove the unused IB_NOTICE_REPRESS_* defines.
> 
> When the hfi1 driver was added these definitions were moved from the qib driver
> to ib_mad.h.  They should have been removed instead.
> 
> Fixes: d4ab347005fb ("IB/core: Add core header changes needed for OPA")
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Hal Rosenstock <hal@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Doug Ledford Sept. 3, 2015, 7:51 p.m. UTC | #2
On 09/02/2015 06:45 PM, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> Remove the unused IB_NOTICE_REPRESS_* defines.
> 
> When the hfi1 driver was added these definitions were moved from the qib driver
> to ib_mad.h.  They should have been removed instead.
> 
> Fixes: d4ab347005fb ("IB/core: Add core header changes needed for OPA")
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
>  include/rdma/ib_mad.h | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h
> index c206205bbf98..7f2cf855a0b6 100644
> --- a/include/rdma/ib_mad.h
> +++ b/include/rdma/ib_mad.h
> @@ -157,18 +157,6 @@
>  #define IB_NOTICE_TRAP_BAD_QKEY		cpu_to_be16(258)
>  
>  /*
> - * Repress trap/notice flags
> - */
> -#define IB_NOTICE_REPRESS_LLI_THRESH	(1 << 0)
> -#define IB_NOTICE_REPRESS_EBO_THRESH	(1 << 1)
> -#define IB_NOTICE_REPRESS_FLOW_UPDATE	(1 << 2)
> -#define IB_NOTICE_REPRESS_CAP_MASK_CHG	(1 << 3)
> -#define IB_NOTICE_REPRESS_SYS_GUID_CHG	(1 << 4)
> -#define IB_NOTICE_REPRESS_BAD_MKEY	(1 << 5)
> -#define IB_NOTICE_REPRESS_BAD_PKEY	(1 << 6)
> -#define IB_NOTICE_REPRESS_BAD_QKEY	(1 << 7)
> -
> -/*
>   * Generic trap/notice other local changes flags (trap 144).
>   */
>  #define IB_NOTICE_TRAP_LSE_CHG		0x04	/* Link Speed Enable changed */
> 

Thanks, applied.
diff mbox

Patch

diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h
index c206205bbf98..7f2cf855a0b6 100644
--- a/include/rdma/ib_mad.h
+++ b/include/rdma/ib_mad.h
@@ -157,18 +157,6 @@ 
 #define IB_NOTICE_TRAP_BAD_QKEY		cpu_to_be16(258)
 
 /*
- * Repress trap/notice flags
- */
-#define IB_NOTICE_REPRESS_LLI_THRESH	(1 << 0)
-#define IB_NOTICE_REPRESS_EBO_THRESH	(1 << 1)
-#define IB_NOTICE_REPRESS_FLOW_UPDATE	(1 << 2)
-#define IB_NOTICE_REPRESS_CAP_MASK_CHG	(1 << 3)
-#define IB_NOTICE_REPRESS_SYS_GUID_CHG	(1 << 4)
-#define IB_NOTICE_REPRESS_BAD_MKEY	(1 << 5)
-#define IB_NOTICE_REPRESS_BAD_PKEY	(1 << 6)
-#define IB_NOTICE_REPRESS_BAD_QKEY	(1 << 7)
-
-/*
  * Generic trap/notice other local changes flags (trap 144).
  */
 #define IB_NOTICE_TRAP_LSE_CHG		0x04	/* Link Speed Enable changed */