From patchwork Sat Oct 17 19:06:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Insu Yun X-Patchwork-Id: 7423111 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 88D229F36A for ; Sat, 17 Oct 2015 19:05:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A4B362041C for ; Sat, 17 Oct 2015 19:05:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE6F7203E9 for ; Sat, 17 Oct 2015 19:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbbJQTFy (ORCPT ); Sat, 17 Oct 2015 15:05:54 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:33925 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbbJQTFx (ORCPT ); Sat, 17 Oct 2015 15:05:53 -0400 Received: by ykfy204 with SMTP id y204so112045573ykf.1; Sat, 17 Oct 2015 12:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=mmBG6Mtj2jxhDeL6ym0oRN/hyOmH/uzlCyNrRVWWAF4=; b=VJ+ZiCWDfvDcmL24gBy6Bp4sFTZ/hjEjBkSUlN6tVYm+p3CFZgjtUfnKAhxnMPafka kUzkvZhoscGSNNTRFIE/iozZHEG8IAF9kTLPaUFg+SH000a5soXK09nza3NmzIv93zq/ lVHW1QP5qqw0p5I/aBi7BOyBGEPi28Ll1LXKmtvdsm9GR8/k3dUcS3D4W6REehaSQlGO CWZCbvoPzIXznLx9U7YZVY2Y+WsRWztcNojUawXarWnU5aXB3qCvmDwfz8OFudDrr1P0 uyhuqxhNHQB4mC2HgmSWrGs3uXDqBKhe3jiaDiqk/TCPH/7Otcuyvme7Mq92HhLyGOQg W/hg== X-Received: by 10.129.152.212 with SMTP id p203mr14623392ywg.266.1445108752671; Sat, 17 Oct 2015 12:05:52 -0700 (PDT) Received: from cutthroat.gtisc.gatech.edu (cutthroat.gtisc.gatech.edu. [128.61.240.77]) by smtp.gmail.com with ESMTPSA id r63sm19918619ywb.43.2015.10.17.12.05.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 17 Oct 2015 12:05:51 -0700 (PDT) From: Insu Yun To: umalhi@cisco.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, Insu Yun Subject: [PATCH] usnix: correctly handle kzalloc return value Date: Sat, 17 Oct 2015 19:06:56 +0000 Message-Id: <1445108816-7616-1-git-send-email-wuninsu@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since kzalloc returns memory address, not error code, it should be checked whether it is null or not. Signed-off-by: Insu Yun Reviewed-by: Dave Goodell --- drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c index db3588d..a678a66 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c @@ -221,8 +221,8 @@ create_roce_custom_flow(struct usnic_ib_qp_grp *qp_grp, /* Create Flow Handle */ qp_flow = kzalloc(sizeof(*qp_flow), GFP_ATOMIC); - if (IS_ERR_OR_NULL(qp_flow)) { - err = qp_flow ? PTR_ERR(qp_flow) : -ENOMEM; + if (!qp_flow) { + err = -ENOMEM; goto out_dealloc_flow; } qp_flow->flow = flow; @@ -296,8 +296,8 @@ create_udp_flow(struct usnic_ib_qp_grp *qp_grp, /* Create qp_flow */ qp_flow = kzalloc(sizeof(*qp_flow), GFP_ATOMIC); - if (IS_ERR_OR_NULL(qp_flow)) { - err = qp_flow ? PTR_ERR(qp_flow) : -ENOMEM; + if (!qp_flow) { + err = -ENOMEM; goto out_dealloc_flow; } qp_flow->flow = flow;