diff mbox

[v2,07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

Message ID 1445307097-8244-8-git-send-email-ira.weiny@intel.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Ira Weiny Oct. 20, 2015, 2:11 a.m. UTC 
From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

Use NULL instead of 0 for pointer argument to fix the sparse error.

Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
 drivers/staging/rdma/hfi1/sdma.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Carpenter Oct. 21, 2015, 2:12 p.m. UTC | #1 
On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.weiny@intel.com wrote:
> From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> 
> Use NULL instead of 0 for pointer argument to fix the sparse error.
> 
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

This should have just been folded in with the previous patch.  Don't
introduce problems and fix them in the patchset.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ira Weiny Oct. 21, 2015, 4:29 p.m. UTC | #2 
> 
> On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.weiny@intel.com wrote:
> > From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> >
> > Use NULL instead of 0 for pointer argument to fix the sparse error.
> >
> > Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> > Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
> > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> > Signed-off-by: Niranjana Vishwanathapura
> > <niranjana.vishwanathapura@intel.com>
> > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> 
> This should have just been folded in with the previous patch.  Don't introduce
> problems and fix them in the patchset.

My bad, I will fix in v3.

Ira

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dan Carpenter Oct. 22, 2015, 10:01 a.m. UTC | #3 
On Wed, Oct 21, 2015 at 04:29:35PM +0000, Weiny, Ira wrote:
> > 
> > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.weiny@intel.com wrote:
> > > From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> > >
> > > Use NULL instead of 0 for pointer argument to fix the sparse error.
> > >
> > > Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> > > Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
> > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> > > Signed-off-by: Niranjana Vishwanathapura
> > > <niranjana.vishwanathapura@intel.com>
> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > 
> > This should have just been folded in with the previous patch.  Don't introduce
> > problems and fix them in the patchset.
> 
> My bad, I will fix in v3.

I don't think it's worth redoing the patchset over because it's just a
Sparse warning, not a bug.  But for the future.

regards,
dan carpenter



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Greg Kroah-Hartman Oct. 25, 2015, 1:59 a.m. UTC | #4 
On Thu, Oct 22, 2015 at 01:01:25PM +0300, Dan Carpenter wrote:
> On Wed, Oct 21, 2015 at 04:29:35PM +0000, Weiny, Ira wrote:
> > > 
> > > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.weiny@intel.com wrote:
> > > > From: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> > > >
> > > > Use NULL instead of 0 for pointer argument to fix the sparse error.
> > > >
> > > > Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> > > > Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com>
> > > > Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> > > > Signed-off-by: Niranjana Vishwanathapura
> > > > <niranjana.vishwanathapura@intel.com>
> > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > > 
> > > This should have just been folded in with the previous patch.  Don't introduce
> > > problems and fix them in the patchset.
> > 
> > My bad, I will fix in v3.
> 
> I don't think it's worth redoing the patchset over because it's just a
> Sparse warning, not a bug.  But for the future.

No, please redo, the other problems in this series warrent a new series.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/staging/rdma/hfi1/sdma.h b/drivers/staging/rdma/hfi1/sdma.h
index 52a7d04067e0..cc22d2ee2054 100644
--- a/drivers/staging/rdma/hfi1/sdma.h
+++ b/drivers/staging/rdma/hfi1/sdma.h
@@ -893,7 +893,7 @@  static inline int sdma_txadd_kvaddr(
 
 	if ((unlikely(tx->num_desc == tx->desc_limit))) {
 		rval = ext_coal_sdma_tx_descs(dd, tx, SDMA_MAP_SINGLE,
-					      kvaddr, 0, 0, len);
+					      kvaddr, NULL, 0, len);
 		if (rval <= 0)
 			return rval;
 	}