diff mbox

IB/srpt: Remove redundant wc array

Message ID 1452597590-17850-1-git-send-email-sagig@mellanox.com (mailing list archive)
State Accepted
Headers show

Commit Message

Sagi Grimberg Jan. 12, 2016, 11:19 a.m. UTC
No usage after the conversion to the new CQ API.

Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
---
This can go as is or be folded to Christoph's srpt patch,
whatever works best.

 drivers/infiniband/ulp/srpt/ib_srpt.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Comments

Bart Van Assche Jan. 12, 2016, 2:33 p.m. UTC | #1
On 01/12/16 03:20, Sagi Grimberg wrote:
> No usage after the conversion to the new CQ API.
>
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig Jan. 12, 2016, 3:55 p.m. UTC | #2
Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Doug Ledford Jan. 19, 2016, 9:46 p.m. UTC | #3
On 01/12/2016 06:19 AM, Sagi Grimberg wrote:
> No usage after the conversion to the new CQ API.
> 
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> ---
> This can go as is or be folded to Christoph's srpt patch,
> whatever works best.
> 
>  drivers/infiniband/ulp/srpt/ib_srpt.h |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h
> index ff8b907..247c807 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.h
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h
> @@ -254,7 +254,6 @@ enum rdma_ch_state {
>   * @free_list:     Head of list with free send I/O contexts.
>   * @state:         channel state. See also enum rdma_ch_state.
>   * @ioctx_ring:    Send ring.
> - * @wc:            IB work completion array for srpt_process_completion().
>   * @list:          Node for insertion in the srpt_device.rch_list list.
>   * @cmd_wait_list: List of SCSI commands that arrived before the RTU event. This
>   *                 list contains struct srpt_ioctx elements and is protected
> @@ -281,7 +280,6 @@ struct srpt_rdma_ch {
>  	struct list_head	free_list;
>  	enum rdma_ch_state	state;
>  	struct srpt_send_ioctx	**ioctx_ring;
> -	struct ib_wc		wc[16];
>  	struct list_head	list;
>  	struct list_head	cmd_wait_list;
>  	struct se_session	*sess;
> 

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h
index ff8b907..247c807 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.h
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.h
@@ -254,7 +254,6 @@  enum rdma_ch_state {
  * @free_list:     Head of list with free send I/O contexts.
  * @state:         channel state. See also enum rdma_ch_state.
  * @ioctx_ring:    Send ring.
- * @wc:            IB work completion array for srpt_process_completion().
  * @list:          Node for insertion in the srpt_device.rch_list list.
  * @cmd_wait_list: List of SCSI commands that arrived before the RTU event. This
  *                 list contains struct srpt_ioctx elements and is protected
@@ -281,7 +280,6 @@  struct srpt_rdma_ch {
 	struct list_head	free_list;
 	enum rdma_ch_state	state;
 	struct srpt_send_ioctx	**ioctx_ring;
-	struct ib_wc		wc[16];
 	struct list_head	list;
 	struct list_head	cmd_wait_list;
 	struct se_session	*sess;