diff mbox

[for-4.5-rc1,1/5] IB/mlx5: Add CREATE_CQ and CREATE_QP to uverbs_ex_cmd_mask

Message ID 1453979055-25285-2-git-send-email-matanb@mellanox.com (mailing list archive)
State Superseded
Headers show

Commit Message

Matan Barak Jan. 28, 2016, 11:04 a.m. UTC
The mlx5_ib supports the extended create_cq and create_qp user verbs.
In the current mechanism, a vendor supporting an exteded uverb should
set the appropriate bit in the uverbs_ex_cmd_mask field. There was a
proposal [1] that lifts this requirement, however, this proposal
hasn't been accepted yet. Adding the actual support by setting the
required bits in order to support features like completion
timestamping and cross-channel.

[1] http://www.spinics.net/lists/linux-rdma/msg30019.html

Fixes: 972ecb821379 ('IB/mlx5: Add create_cq extended command')
Fixes: ddf9529be19c ('IB/core: Allow setting create flags in QP init
                      attribute')
Signed-off-by: Matan Barak <matanb@mellanox.com>
---
 drivers/infiniband/hw/mlx5/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Or Gerlitz Jan. 28, 2016, 3:30 p.m. UTC | #1
On 1/28/2016 1:04 PM, Matan Barak wrote:
> The mlx5_ib supports the extended create_cq and create_qp user verbs.
> In the current mechanism, a vendor supporting an exteded uverb should
> set the appropriate bit in the uverbs_ex_cmd_mask field. There was a
> proposal [1] that lifts this requirement, however, this proposal
> hasn't been accepted yet. Adding the actual support by setting the
> required bits in order to support features like completion
> timestamping and cross-channel.
>
> [1]http://www.spinics.net/lists/linux-rdma/msg30019.html
>
> Fixes: 972ecb821379 ('IB/mlx5: Add create_cq extended command')
> Fixes: ddf9529be19c ('IB/core: Allow setting create flags in QP init
>                        attribute')
> Signed-off-by: Matan Barak<matanb@mellanox.com>

This change-log is going to stay in the kernel log forever... lets drop 
the email archive reference
out of the change-log and put it before the --- lines for ref while 
reviewing.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index ec737e2..6f67412 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -2214,7 +2214,9 @@  static void *mlx5_ib_add(struct mlx5_core_dev *mdev)
 		(1ull << IB_USER_VERBS_CMD_CREATE_XSRQ)		|
 		(1ull << IB_USER_VERBS_CMD_OPEN_QP);
 	dev->ib_dev.uverbs_ex_cmd_mask =
-		(1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE);
+		(1ull << IB_USER_VERBS_EX_CMD_QUERY_DEVICE)	|
+		(1ull << IB_USER_VERBS_EX_CMD_CREATE_CQ)	|
+		(1ull << IB_USER_VERBS_EX_CMD_CREATE_QP);
 
 	dev->ib_dev.query_device	= mlx5_ib_query_device;
 	dev->ib_dev.query_port		= mlx5_ib_query_port;