Message ID | 1466187166-2549-1-git-send-email-weiyj_lk@163.com (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
On (06/17/16 18:12), weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fixes the following sparse warnings: > > net/rds/tcp.c:59:5: warning: > symbol 'rds_tcp_min_sndbuf' was not declared. Should it be static? > net/rds/tcp.c:60:5: warning: > symbol 'rds_tcp_min_rcvbuf' was not declared. Should it be static? Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/17/2016 11:12 AM, weiyj_lk@163.com wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fixes the following sparse warnings: > > net/rds/tcp.c:59:5: warning: > symbol 'rds_tcp_min_sndbuf' was not declared. Should it be static? > net/rds/tcp.c:60:5: warning: > symbol 'rds_tcp_min_rcvbuf' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- Look ok. Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: weiyj_lk@163.com Date: Fri, 17 Jun 2016 18:12:46 +0000 > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > Fixes the following sparse warnings: > > net/rds/tcp.c:59:5: warning: > symbol 'rds_tcp_min_sndbuf' was not declared. Should it be static? > net/rds/tcp.c:60:5: warning: > symbol 'rds_tcp_min_rcvbuf' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/rds/tcp.c b/net/rds/tcp.c index 86187da..49fab0c 100644 --- a/net/rds/tcp.c +++ b/net/rds/tcp.c @@ -56,8 +56,8 @@ static int rds_tcp_skbuf_handler(struct ctl_table *ctl, int write, void __user *buffer, size_t *lenp, loff_t *fpos); -int rds_tcp_min_sndbuf = SOCK_MIN_SNDBUF; -int rds_tcp_min_rcvbuf = SOCK_MIN_RCVBUF; +static int rds_tcp_min_sndbuf = SOCK_MIN_SNDBUF; +static int rds_tcp_min_rcvbuf = SOCK_MIN_RCVBUF; static struct ctl_table rds_tcp_sysctl_table[] = { #define RDS_TCP_SNDBUF 0