From patchwork Thu Aug 18 17:32:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jarod Wilson X-Patchwork-Id: 9289111 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3E4E0607FF for ; Fri, 19 Aug 2016 01:52:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2D5742915B for ; Fri, 19 Aug 2016 01:52:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 207CC29161; Fri, 19 Aug 2016 01:52:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFDA12915B for ; Fri, 19 Aug 2016 01:52:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754638AbcHSBwe (ORCPT ); Thu, 18 Aug 2016 21:52:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57626 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754294AbcHSBwc (ORCPT ); Thu, 18 Aug 2016 21:52:32 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 40A14A89A; Thu, 18 Aug 2016 17:32:38 +0000 (UTC) Received: from hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com (hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com [10.16.184.47]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7IHWUAG018884; Thu, 18 Aug 2016 13:32:37 -0400 From: Jarod Wilson To: linux-rdma@vger.kernel.org Cc: Jarod Wilson , Gil Rockah Subject: [PATCH perftest 14/23] perftest_communication: fix ibv_create_ah failure check Date: Thu, 18 Aug 2016 13:32:09 -0400 Message-Id: <1471541538-20270-15-git-send-email-jarod@redhat.com> In-Reply-To: <1471541538-20270-1-git-send-email-jarod@redhat.com> References: <1471541538-20270-1-git-send-email-jarod@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 18 Aug 2016 17:32:38 +0000 (UTC) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We've already dereferenced ctx->ah by assigning the return value of ibv_create_ah to ctx->ah[0], so this check as-is will currently never trip. I believe what was meant was to check for a failure of ibv_create_ah, which returns 0 on success or the value of errno on failure. Just check for non-zero ctx->ah[0] instead. CC: Gil Rockah Signed-off-by: Jarod Wilson --- src/perftest_communication.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/perftest_communication.c b/src/perftest_communication.c index bec973a..d938e41 100755 --- a/src/perftest_communication.c +++ b/src/perftest_communication.c @@ -1007,7 +1007,7 @@ int rdma_client_connect(struct pingpong_context *ctx,struct perftest_parameters ctx->ah[0] = ibv_create_ah(ctx->pd,&event->param.ud.ah_attr); - if (!ctx->ah) { + if (ctx->ah[0]) { printf(" Unable to create address handler for UD QP\n"); return FAILURE; }