From patchwork Mon Sep 19 04:36:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Knut Omang X-Patchwork-Id: 9338503 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 073FF601C2 for ; Mon, 19 Sep 2016 04:36:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED60728E63 for ; Mon, 19 Sep 2016 04:36:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E1F4428EA9; Mon, 19 Sep 2016 04:36:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FEC828E63 for ; Mon, 19 Sep 2016 04:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750786AbcISEgm (ORCPT ); Mon, 19 Sep 2016 00:36:42 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38413 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbcISEgl (ORCPT ); Mon, 19 Sep 2016 00:36:41 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8J4aaiU016251 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Sep 2016 04:36:37 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u8J4aa3p003665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Sep 2016 04:36:36 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u8J4aZTi020504; Mon, 19 Sep 2016 04:36:36 GMT Received: from ori (/10.175.250.37) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 18 Sep 2016 21:36:35 -0700 Message-ID: <1474259792.20134.117.camel@oracle.com> Subject: Re: [PATCH libibverbs v2 1/3] Add new call ibv_cmd_create_ah_ex which supports extra parameters From: Knut Omang To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma@vger.kernel.org, Mukesh Kacker Date: Mon, 19 Sep 2016 06:36:32 +0200 In-Reply-To: <1474259364.20134.114.camel@oracle.com> References: <5cc0157c0f05701d8cb1334e6ee11e1e7be6fa24.1474063039.git-series.knut.omang@oracle.com> <20160919030122.GA23152@obsidianresearch.com> <1474257063.20134.103.camel@oracle.com> <20160919040854.GA28241@obsidianresearch.com> <1474259364.20134.114.camel@oracle.com> X-Mailer: Evolution 3.16.5 (3.16.5-3.fc22) Mime-Version: 1.0 X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2016-09-19 at 06:29 +0200, Knut Omang wrote: > On Sun, 2016-09-18 at 22:08 -0600, Jason Gunthorpe wrote: > > On Mon, Sep 19, 2016 at 05:51:03AM +0200, Knut Omang wrote: > > > > > I was a bit concerned about the "structure", but ultimately decided to > > > follow the pattern since I could not find any documentation with this syntax > > > (which is probably because it is not supported?) > > > > It is something carried over from Solaris, it is not implemented in > > linux today, but it is good practice to follow the solaris > > method. Drepper talks about it in his various documentations of symbol > > versioning. > > > > Each stanza should refer to its predecessor. > > Ok, I see... > That also means that this patch would have to be based on the IBVERBS_1.2 and IBVERBS_1.3 fixups > to avoid introducing conflicts. I tested this, which seems to work fine, but I am not sure you want it ;-) : +} IBVERBS_1.3; Knut --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/src/libibverbs.map b/src/libibverbs.map index 5134bd9..979980d 100644 --- a/src/libibverbs.map +++ b/src/libibverbs.map @@ -118,5 +118,15 @@ IBVERBS_1.1 { ibv_cmd_create_qp_ex2; ibv_cmd_open_qp; ibv_cmd_rereg_mr; } IBVERBS_1.0; +IBVERBS_1.2 { +} IBVERBS_1.1; + + +IBVERBS_1.3 { +} IBVERBS_1.2; + +IBVERBS_1.4 { + global: + ibv_cmd_create_ah_ex;