From patchwork Wed Nov 2 13:11:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9409053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C316601C2 for ; Wed, 2 Nov 2016 13:11:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3B9C02A152 for ; Wed, 2 Nov 2016 13:11:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2DC542A15B; Wed, 2 Nov 2016 13:11:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B18C52A152 for ; Wed, 2 Nov 2016 13:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752240AbcKBNLq (ORCPT ); Wed, 2 Nov 2016 09:11:46 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35764 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847AbcKBNLq (ORCPT ); Wed, 2 Nov 2016 09:11:46 -0400 Received: by mail-pf0-f195.google.com with SMTP id i88so1772916pfk.2 for ; Wed, 02 Nov 2016 06:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DmbhIgpFBuCJtCIhQW1iwc4Jy+4tdOyrTKmlnVP9Hiw=; b=WQVkpjjgblk8UxK6A23DlJkeZyf9M7cjFnM2DCTz6abOFvgroOjXBtO6g/cjLjeRly i2gUxGpeMVGKfRCvV2sTYdYmPeSk6xiZTX16b/LJj4EUu0WYaf4lvcQydcaEkIV2mRHS X0F/D/R2y8YYxQM0KDaLcZUgfO3Z77gBzJ0xAsXiqNa4mtbnn+bZWHLjeKTMr2Zj/8AC VZe44PO0cy+pttg6vf7dY5HGEjHX9bMheUsRVcdgP6kSl5iR2b6Gb1TegpLR33GTuiNq Wr5qdN6rasAiiYYKjH7dFHHL56OoPzPnpPGlH5fJyFS2D/0LKbs7i+WrU7Bz0v9q+CgR QmlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DmbhIgpFBuCJtCIhQW1iwc4Jy+4tdOyrTKmlnVP9Hiw=; b=D/Adex8bSIBhdYKlIToikydlQd5eIgxGgf5vRivRRU79BWI9hpmtk0lD7hMUc+j+xj dNTK+R8PODhYvtrPn9mOQceF7Qn37FDUEppj4/wG8X4rC4FXP0HUeCy/pmAsW9Yq1RGC ssIIK8nta/ZUjyINYJMgknY9iL2RS91hSNafUJZzRgpn4UQGCR6DNAAoDpQiIdiIGKmx Y7lYRKDt5eRvPimQUd8huX/pVVrUOs6tS12X6U+99dyVQG3aCcqho3CBF5NZN1kWlTA4 vLsr7mNJetLS9R4G1yyqy02k5tCIHZpXphwc47OtEwDE1m6YZGsuLA3H6Z8Qnaz8AI3P qDuA== X-Gm-Message-State: ABUngvdv0IMuOgWpxsNADQI2rEbG5HUyQ3eWOfRS3pDxSdPpqtY8L/hUoh0VoSSr6wq9+w== X-Received: by 10.99.217.21 with SMTP id r21mr5605287pgg.78.1478092305103; Wed, 02 Nov 2016 06:11:45 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id c5sm4802036pfj.71.2016.11.02.06.11.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Nov 2016 06:11:44 -0700 (PDT) From: Wei Yongjun To: Doug Ledford , Sean Hefty , Hal Rosenstock , Ram Amrani , Rajesh Borundia , Leon Romanovsky Cc: Wei Yongjun , linux-rdma@vger.kernel.org Subject: [PATCH v2] qedr: remove pointless NULL check in qedr_post_send() Date: Wed, 2 Nov 2016 13:11:32 +0000 Message-Id: <1478092292-17225-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1477672406-31487-1-git-send-email-weiyj.lk@gmail.com> References: <1477672406-31487-1-git-send-email-weiyj.lk@gmail.com> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun Remove pointless NULL check for 'wr' in qedr_post_send(). Signed-off-by: Wei Yongjun Acked-by: Ram Amrani --- v1 -> v2: remove pointless NULL check as Ram's suggestion --- drivers/infiniband/hw/qedr/verbs.c | 5 ----- 1 file changed, 5 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c index a615142..ed7521a 100644 --- a/drivers/infiniband/hw/qedr/verbs.c +++ b/drivers/infiniband/hw/qedr/verbs.c @@ -2981,11 +2981,6 @@ int qedr_post_send(struct ib_qp *ibqp, struct ib_send_wr *wr, return -EINVAL; } - if (!wr) { - DP_ERR(dev, "Got an empty post send.\n"); - return -EINVAL; - } - while (wr) { rc = __qedr_post_send(ibqp, wr, bad_wr); if (rc)