From patchwork Fri Nov 18 11:24:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Vyukov X-Patchwork-Id: 9436251 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 146B860238 for ; Fri, 18 Nov 2016 11:25:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D91B629840 for ; Fri, 18 Nov 2016 11:25:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B9C7C29880; Fri, 18 Nov 2016 11:25:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A51F829840 for ; Fri, 18 Nov 2016 11:25:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbcKRLZH (ORCPT ); Fri, 18 Nov 2016 06:25:07 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37307 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbcKRLZG (ORCPT ); Fri, 18 Nov 2016 06:25:06 -0500 Received: by mail-wm0-f45.google.com with SMTP id t79so31114765wmt.0 for ; Fri, 18 Nov 2016 03:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=5j/EXbcFIm68F6ucKGJbZT1Ad6polXyVYhsVRI3xu+Q=; b=DLsleQzezQ9J9q5iBdfyBMr4Q/X7DuhSIq7t8vxv7KR15frCtWAsCHTIMGUVbxLg20 fFuuditzo1pmWh3OXrTNsZNAJUcTWZwAFuWeYDWanielTcyFaVFBLu19Tv34W/a/p8ai VEE46gNBLsOHot60XS3oj2KUa+03fiG/RUjar4QupjNVqyi4dTPh2XTSMGTp8G1RrDxM nRwPHBfmMJrw+qFDk0i7w9k841ls6LV/34g78wcgkQX0e22V98N8+HcHUbttmjh9ZcL+ +XfKn0ICw8T52FRNjBdz/qDj2Zde5rLDufGKdr9ts1DzLrFkqyiToKz3/GnedgUfsHnM RqpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=5j/EXbcFIm68F6ucKGJbZT1Ad6polXyVYhsVRI3xu+Q=; b=irRjZbpUx0x0410XyhHhwT/VBCBscWPySqPpGh2zvV+5lCbB6l76JbIXuhEd1a+DsU HAVzbGuwNpXOXdgkl/KbbNkXTVWYkiezB+eEK3uk28sZWx/cY+/M1DHWoIthZ4KcLO/X KGStLPtdyjM6FJOI1LO7gNy4oxHFlazPO/iTioo4sPiJob3Re0fg+vV67oETJJlYsCZt pITFcIl08+Z1H/HzQQ41zAgwLfJvHlS6Fb/38voOsYJsf1A4cQ8Sjzr1qY9lKjvtQLHF w/x9zQ+QJkhm9IG/8OezXDfl2BlBqLeethT+WMXfd+Eg+WokF+VbwHuzQhubxTYrOfh0 y0Xw== X-Gm-Message-State: ABUngvfAtKSMSFnmixhrG+JrcqzpCJc++3fBw1HH5Pv8pVXPIwBSYN4r36ZHroKGG6HWGrcd X-Received: by 10.28.161.67 with SMTP id k64mr22969144wme.69.1479468303906; Fri, 18 Nov 2016 03:25:03 -0800 (PST) Received: from dvyukov-z840.muc.corp.google.com ([100.105.28.76]) by smtp.gmail.com with ESMTPSA id r7sm8295159wjp.43.2016.11.18.03.24.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2016 03:24:47 -0800 (PST) Received: by dvyukov-z840.muc.corp.google.com (Postfix, from userid 129372) id 1BEC3E1367; Fri, 18 Nov 2016 12:24:43 +0100 (CET) From: Dmitry Vyukov To: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, leon@kernel.org Cc: Dmitry Vyukov , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com Subject: [PATCH] infiniband: remove WARN that is not kernel bug Date: Fri, 18 Nov 2016 12:24:37 +0100 Message-Id: <1479468277-50798-1-git-send-email-dvyukov@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNINGs mean kernel bugs. The one in ucma_write() points to user programming error or a malicious attempt. This is not a kernel bug, remove it. BUG/WARNs that are not kernel bugs hinder automated testing effots. Signed-off-by: Dmitry Vyukov Cc: Doug Ledford Cc: Sean Hefty Cc: Hal Rosenstock Cc: Leon Romanovsky Cc: linux-rdma@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: syzkaller@googlegroups.com --- drivers/infiniband/core/ucma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 9520154..ff60373 100644 --- a/drivers/infiniband/core/ucma.c +++ b/drivers/infiniband/core/ucma.c @@ -1584,7 +1584,7 @@ static ssize_t ucma_write(struct file *filp, const char __user *buf, struct rdma_ucm_cmd_hdr hdr; ssize_t ret; - if (WARN_ON_ONCE(!ib_safe_file_access(filp))) + if (!ib_safe_file_access(filp)) return -EACCES; if (len < sizeof(hdr))