From patchwork Mon Nov 21 10:18:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Vyukov X-Patchwork-Id: 9439183 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 97F7560469 for ; Mon, 21 Nov 2016 10:19:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8006928A8D for ; Mon, 21 Nov 2016 10:19:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7515628A8F; Mon, 21 Nov 2016 10:19:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 225C628A8D for ; Mon, 21 Nov 2016 10:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753836AbcKUKS4 (ORCPT ); Mon, 21 Nov 2016 05:18:56 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36498 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753564AbcKUKS4 (ORCPT ); Mon, 21 Nov 2016 05:18:56 -0500 Received: by mail-wm0-f45.google.com with SMTP id g23so137816988wme.1 for ; Mon, 21 Nov 2016 02:18:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=2NbYyOQ13831jTBPEmVImzgHdsFr+izI1i8lQUFmsCs=; b=ku34AdSZYl4foJB7fGRgT2ES/zruY2Q666q0w/Y36sLHF9k+cw56/6ZUUfs5204h8W 81uT8Cub+O4VGCuYALRnBOHSa1a9gPMU+zVo3oNG7hJU2WCCzvuNpN6aat33HuRPxZyd kZ+DpUnhWd5Go0WvsgiRL6ZVophPV12SQGBkxmOzUvBbrGacZuDSdtC36ijnaYJMWorb 70JfCp3HCAnw8rai2zxBgV+oilrWn6QdWJtAQih06MaZ4QFPNopFjGbu34D7j2XQrSRf BwuoLkh+jw6MsLxfu9RM++HE8p3svAuvDLFkwPqIu4HHz9WeVZQ49J1ie5EW8vMtnO1e /rpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=2NbYyOQ13831jTBPEmVImzgHdsFr+izI1i8lQUFmsCs=; b=DUCc72q0HDWH5Ac9qAuRI3R1SimAdJUOOCHhhOEOCMBdXejjbstwrJlkE8ztNs/lOe ILlW7Pzc9URKzYokgdtVbY4OBT1mgHiVOFwPBuHTRatxxIRyMK4S4AMh+XkEyfa/zydp wS6IL6Rl2+grBY1Iq1AzUB06w0KlQBa1+hLz/8eo6ddRt8KL7tr8wFTCI8d8WkesByqs HVbyxcJxsONv9cUG486x9D3Ew0IpHXFs5Q8+8RfjeydswTnfKWBqLudVSNVH3qvGq07/ oFbTBFhtfXsOqxnLsl8xrMkebxFIpmHgYONt9vgXf3iBhhGvU6gyZ5sY/6VnOUZ7yLAw tQ+A== X-Gm-Message-State: AKaTC00V6cYUkRMwK8TvfI9mal8zh3QOTs1dLYXNkkCambqetQt2MW6kOyGkf8tym4FGycq1 X-Received: by 10.28.26.80 with SMTP id a77mr13217482wma.31.1479723534421; Mon, 21 Nov 2016 02:18:54 -0800 (PST) Received: from dvyukov-z840.muc.corp.google.com ([2a00:79e0:15:10:a952:16bf:a50f:b7d1]) by smtp.gmail.com with ESMTPSA id ab10sm24020463wjc.45.2016.11.21.02.18.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2016 02:18:53 -0800 (PST) Received: by dvyukov-z840.muc.corp.google.com (Postfix, from userid 129372) id 7D1CDE12BC; Mon, 21 Nov 2016 11:18:52 +0100 (CET) From: Dmitry Vyukov To: jgunthorpe@obsidianresearch.com, Valdis.Kletnieks@vt.edu, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, leon@kernel.org Cc: Dmitry Vyukov , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com Subject: [PATCH v2] infiniband: remove WARN that is not kernel bug Date: Mon, 21 Nov 2016 11:18:50 +0100 Message-Id: <1479723531-17940-1-git-send-email-dvyukov@google.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNINGs mean kernel bugs. The one in ucma_write() points to user programming error or a malicious attempt. This is not a kernel bug, remove it. BUG/WARNs that are not kernel bugs hinder automated testing effots. Signed-off-by: Dmitry Vyukov Cc: Doug Ledford Cc: Sean Hefty Cc: Hal Rosenstock Cc: Leon Romanovsky Cc: linux-rdma@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: syzkaller@googlegroups.com --- Changes since v1: - added printk_once --- drivers/infiniband/core/ucma.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 9520154..405d0ce 100644 --- a/drivers/infiniband/core/ucma.c +++ b/drivers/infiniband/core/ucma.c @@ -1584,8 +1584,11 @@ static ssize_t ucma_write(struct file *filp, const char __user *buf, struct rdma_ucm_cmd_hdr hdr; ssize_t ret; - if (WARN_ON_ONCE(!ib_safe_file_access(filp))) + if (!ib_safe_file_access(filp)) { + printk_once("ucma_write: process %d (%s) tried to do something hinky\n", + task_tgid_vnr(current), current->comm); return -EACCES; + } if (len < sizeof(hdr)) return -EINVAL;