| Message ID | 1483353409.3592.15.camel@sandisk.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Jan 02, 2017 at 10:39:05AM +0000, Bart Van Assche wrote: > Avoid that sparse complains about using 0 as a pointer. Avoid that > sparse complains about missing function declarations. Avoid that > sparse complains about > endianness. > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > Cc: Moni Shoua <monis@mellanox.com> > Cc: Andrew Boyer <andrew.boyer@dell.com> > --- Something wrong with commit message. Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Thu, 2017-01-05 at 14:59 +0200, Leon Romanovsky wrote: > On Mon, Jan 02, 2017 at 10:39:05AM +0000, Bart Van Assche wrote: > > Avoid that sparse complains about using 0 as a pointer. Avoid that > > sparse complains about missing function declarations. Avoid that > > sparse complains about > > endianness. > > > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > > Cc: Moni Shoua <monis@mellanox.com> > > Cc: Andrew Boyer <andrew.boyer@dell.com> > > --- > > Something wrong with commit message. Hello Leon, Are you referring to the formatting or to the contents of the commit message? Bart.
On Mon, Jan 09, 2017 at 12:42:00PM +0000, Bart Van Assche wrote: > On Thu, 2017-01-05 at 14:59 +0200, Leon Romanovsky wrote: > > On Mon, Jan 02, 2017 at 10:39:05AM +0000, Bart Van Assche wrote: > > > Avoid that sparse complains about using 0 as a pointer. Avoid that > > > sparse complains about missing function declarations. Avoid that > > > sparse complains about > > > endianness. > > > > > > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> > > > Cc: Moni Shoua <monis@mellanox.com> > > > Cc: Andrew Boyer <andrew.boyer@dell.com> > > > --- > > > > Something wrong with commit message. > > Hello Leon, > > Are you referring to the formatting or to the contents of the commit > message? Both, it looks like the message was cut after last about and three "avoid that sparse complains about ..." in the row was unpleasant to me. Both these nitpicks don't worth to respin. Thanks > > Bart.
On 1/2/17, 5:39 AM, "Bart Van Assche" <Bart.VanAssche@sandisk.com> wrote: >Avoid that sparse complains about using 0 as a pointer. Avoid that >sparse complains about missing function declarations. Avoid that >sparse complains about >endianness. > >Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> >Cc: Moni Shoua <monis@mellanox.com> >Cc: Andrew Boyer <andrew.boyer@dell.com> >--- > drivers/infiniband/sw/rxe/rxe_net.c | 8 ++++---- > drivers/infiniband/sw/rxe/rxe_recv.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Andrew Boyer <andrew.boyer@dell.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c index 342e78163613..151f639abebf 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c @@ -243,8 +243,8 @@ static struct socket *rxe_setup_udp_tunnel(struct net *net, __be16 port, { int err; struct socket *sock; - struct udp_port_cfg udp_cfg = {0}; - struct udp_tunnel_sock_cfg tnl_cfg = {0}; + struct udp_port_cfg udp_cfg = { }; + struct udp_tunnel_sock_cfg tnl_cfg = { }; if (ipv6) { udp_cfg.family = AF_INET6; @@ -658,7 +658,7 @@ struct notifier_block rxe_net_notifier = { .notifier_call = rxe_notify, }; -int rxe_net_ipv4_init(void) +static int rxe_net_ipv4_init(void) { recv_sockets.sk4 = rxe_setup_udp_tunnel(&init_net, htons(ROCE_V2_UDP_DPORT), false); @@ -671,7 +671,7 @@ int rxe_net_ipv4_init(void) return 0; } -int rxe_net_ipv6_init(void) +static int rxe_net_ipv6_init(void) { #if IS_ENABLED(CONFIG_IPV6) diff --git a/drivers/infiniband/sw/rxe/rxe_recv.c b/drivers/infiniband/sw/rxe/rxe_recv.c index 252b4d637d45..50886031096f 100644 --- a/drivers/infiniband/sw/rxe/rxe_recv.c +++ b/drivers/infiniband/sw/rxe/rxe_recv.c @@ -389,7 +389,7 @@ int rxe_rcv(struct sk_buff *skb) calc_icrc = rxe_icrc_hdr(pkt, skb); calc_icrc = crc32_le(calc_icrc, (u8 *)payload_addr(pkt), payload_size(pkt)); - calc_icrc = cpu_to_be32(~calc_icrc); + calc_icrc = (__force u32)cpu_to_be32(~calc_icrc); if (unlikely(calc_icrc != pack_icrc)) { if (skb->protocol == htons(ETH_P_IPV6)) pr_warn_ratelimited("bad ICRC from %pI6c\n",
Avoid that sparse complains about using 0 as a pointer. Avoid that sparse complains about missing function declarations. Avoid that sparse complains about endianness. Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Moni Shoua <monis@mellanox.com> Cc: Andrew Boyer <andrew.boyer@dell.com> --- drivers/infiniband/sw/rxe/rxe_net.c | 8 ++++---- drivers/infiniband/sw/rxe/rxe_recv.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.11.0