From patchwork Wed Jan 18 12:26:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Amrani, Ram" X-Patchwork-Id: 9523551 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 974C9601C3 for ; Wed, 18 Jan 2017 12:27:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8D0D328589 for ; Wed, 18 Jan 2017 12:27:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 818C22859B; Wed, 18 Jan 2017 12:27:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D91B428589 for ; Wed, 18 Jan 2017 12:27:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbdARM1E (ORCPT ); Wed, 18 Jan 2017 07:27:04 -0500 Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:51252 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbdARM1D (ORCPT ); Wed, 18 Jan 2017 07:27:03 -0500 Received: from pps.filterd (m0085408.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v0ICQngX023557; Wed, 18 Jan 2017 04:26:49 -0800 Received: from avcashub1.qlogic.com ([198.186.0.117]) by mx0b-0016ce01.pphosted.com with ESMTP id 28289580au-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 18 Jan 2017 04:26:49 -0800 Received: from lb-tlvb-ramrani.il.qlogic.org (10.185.6.119) by qlc.com (10.1.4.192) with Microsoft SMTP Server id 14.3.235.1; Wed, 18 Jan 2017 04:26:47 -0800 From: Ram Amrani To: CC: , , Ram Amrani Subject: [PATCH rdma-core] libqedr: remove fast-path debug prints Date: Wed, 18 Jan 2017 14:26:38 +0200 Message-ID: <1484742398-6927-1-git-send-email-Ram.Amrani@cavium.com> X-Mailer: git-send-email 2.1.0 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5800 definitions=8411 signatures=670801 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701180170 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove the invocations of the macro FP_DP_VERBOSE(). They are not useful as enabling them causes a flood of prints. Signed-off-by: Ram Amrani --- providers/qedr/qelr_verbs.c | 38 -------------------------------------- 1 file changed, 38 deletions(-) diff --git a/providers/qedr/qelr_verbs.c b/providers/qedr/qelr_verbs.c index a7c4503..f24b1a2 100644 --- a/providers/qedr/qelr_verbs.c +++ b/providers/qedr/qelr_verbs.c @@ -54,10 +54,6 @@ #include #include -/* Fast path debug prints */ -#define FP_DP_VERBOSE(...) -/* #define FP_DP_VERBOSE(...) DP_VERBOSE(__VA_ARGS__) */ - #define QELR_SQE_ELEMENT_SIZE (sizeof(struct rdma_sq_sge)) #define QELR_RQE_ELEMENT_SIZE (sizeof(struct rdma_rq_sge)) #define QELR_CQE_SIZE (sizeof(union rdma_cqe)) @@ -1208,9 +1204,6 @@ int qelr_post_send(struct ibv_qp *ib_qp, struct ibv_send_wr *wr, qp->wqe_wr_id[qp->sq.prod].wqe_size = swqe->wqe_size; qp->prev_wqe_size = swqe->wqe_size; qp->wqe_wr_id[qp->sq.prod].bytes_len = swqe->length; - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "SEND w/ IMM length = %d imm data=%x\n", - swqe->length, wr->imm_data); break; case IBV_WR_SEND: @@ -1230,9 +1223,6 @@ int qelr_post_send(struct ibv_qp *ib_qp, struct ibv_send_wr *wr, qp->wqe_wr_id[qp->sq.prod].wqe_size = swqe->wqe_size; qp->prev_wqe_size = swqe->wqe_size; qp->wqe_wr_id[qp->sq.prod].bytes_len = swqe->length; - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "SEND w/o IMM length = %d\n", - swqe->length); break; case IBV_WR_RDMA_WRITE_WITH_IMM: @@ -1257,9 +1247,6 @@ int qelr_post_send(struct ibv_qp *ib_qp, struct ibv_send_wr *wr, qp->wqe_wr_id[qp->sq.prod].wqe_size = rwqe->wqe_size; qp->prev_wqe_size = rwqe->wqe_size; qp->wqe_wr_id[qp->sq.prod].bytes_len = rwqe->length; - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "RDMA WRITE w/ IMM length = %d imm data=%x\n", - rwqe->length, rwqe->imm_data); break; case IBV_WR_RDMA_WRITE: @@ -1281,9 +1268,6 @@ int qelr_post_send(struct ibv_qp *ib_qp, struct ibv_send_wr *wr, qp->wqe_wr_id[qp->sq.prod].wqe_size = rwqe->wqe_size; qp->prev_wqe_size = rwqe->wqe_size; qp->wqe_wr_id[qp->sq.prod].bytes_len = rwqe->length; - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "RDMA WRITE w/o IMM length = %d\n", - rwqe->length); break; case IBV_WR_RDMA_READ: @@ -1301,13 +1285,10 @@ int qelr_post_send(struct ibv_qp *ib_qp, struct ibv_send_wr *wr, qp->wqe_wr_id[qp->sq.prod].wqe_size = rwqe->wqe_size; qp->prev_wqe_size = rwqe->wqe_size; qp->wqe_wr_id[qp->sq.prod].bytes_len = rwqe->length; - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "RDMA READ length = %d\n", rwqe->length); break; case IBV_WR_ATOMIC_CMP_AND_SWP: case IBV_WR_ATOMIC_FETCH_AND_ADD: - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, "ATOMIC\n"); if (!qp->atomic_supported) { DP_ERR(cxt->dbg_fp, "Atomic not supported on this machine\n"); @@ -1422,9 +1403,6 @@ int qelr_post_recv(struct ibv_qp *ibqp, struct ibv_recv_wr *wr, *bad_wr = wr; break; } - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "RQ WR: SGEs: %d with wr_id[%d] = %lx\n", - wr->num_sge, qp->rq.prod, wr->wr_id); for (i = 0; i < wr->num_sge; i++) { uint32_t flags = 0; struct rdma_rq_sge *rqe; @@ -1441,10 +1419,6 @@ int qelr_post_recv(struct ibv_qp *ibqp, struct ibv_recv_wr *wr, rqe = qelr_chain_produce(&qp->rq.chain); RQ_SGE_SET(rqe, wr->sg_list[i].addr, wr->sg_list[i].length, flags); - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "[%d]: len %d key %x addr %x:%x\n", i, - rqe->length, rqe->flags, - rqe->first_addr.hi, rqe->first_addr.lo); } /* Special case of no sges. FW requires between 1-4 sges... * in this case we need to post 1 sge with length zero. this is @@ -1482,8 +1456,6 @@ int qelr_post_recv(struct ibv_qp *ibqp, struct ibv_recv_wr *wr, wr = wr->next; } - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, "POST: Elements in RespQ: %d\n", - qelr_chain_get_elem_left_u32(&qp->rq.chain)); pthread_spin_unlock(&qp->q_lock); return status; @@ -1682,8 +1654,6 @@ static void __process_resp_one(struct qelr_qp *qp, struct qelr_cq *cq, wc->opcode = IBV_WC_RECV; wc->wc_flags = 0; - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, "\n"); - switch (resp->status) { case RDMA_CQE_RESP_STS_LOCAL_ACCESS_ERR: wc_status = IBV_WC_LOC_ACCESS_ERR; @@ -1718,9 +1688,6 @@ static void __process_resp_one(struct qelr_qp *qp, struct qelr_cq *cq, wc->imm_data = ntohl(le32toh(resp->imm_data_or_inv_r_Key)); wc->wc_flags |= IBV_WC_WITH_IMM; - FP_DP_VERBOSE(cxt->dbg_fp, QELR_MSG_CQ, - "POLL CQ RQ2: RESP_RDMA_IMM imm_data = %x resp_len=%d\n", - wc->imm_data, wc->byte_len); break; case QELR_RESP_RDMA: DP_ERR(cxt->dbg_fp, "Invalid flags detected\n"); @@ -1884,8 +1851,6 @@ int qelr_poll_cq(struct ibv_cq *ibcq, int num_entries, struct ibv_wc *wc) * but chain already point to the next INVALID one */ doorbell_cq(cq, db_cons, cq->arm_flags); - FP_DP_VERBOSE(stderr, QELR_MSG_CQ, "doorbell_cq cons=%x\n", - db_cons); } return done; @@ -1905,9 +1870,6 @@ int qelr_arm_cq(struct ibv_cq *ibcq, int solicited) uint32_t db_cons; db_cons = qelr_chain_get_cons_idx_u32(&cq->chain) - 1; - FP_DP_VERBOSE(get_qelr_ctx(ibcq->context)->dbg_fp, QELR_MSG_CQ, - "Arm CQ cons=%x solicited=%d\n", db_cons, solicited); - cq->arm_flags = solicited ? DQ_UCM_ROCE_CQ_ARM_SE_CF_CMD : DQ_UCM_ROCE_CQ_ARM_CF_CMD;