| Message ID | 1484837311-13206-1-git-send-email-yuval.shaia@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Jan 19, 2017 at 04:48:31PM +0200, Yuval Shaia wrote: > Print the invalid port number to ease troubleshooting. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > v0 -> v1: > * Fix typo in commit header > --- > drivers/infiniband/core/mad.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Thu, Jan 19, 2017 at 04:48:31PM +0200, Yuval Shaia wrote: > Print the invalid port number to ease troubleshooting. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > v0 -> v1: > * Fix typo in commit header > --- Somehow liked the typo :-D Anyways, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> Print the invalid port number to ease troubleshooting. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com> > --- > v0 -> v1: > * Fix typo in commit header > --- > drivers/infiniband/core/mad.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index > a009f71..57f231f 100644 > --- a/drivers/infiniband/core/mad.c > +++ b/drivers/infiniband/core/mad.c > @@ -316,7 +316,9 @@ struct ib_mad_agent *ib_register_mad_agent(struct > ib_device *device, > /* Validate device and port */ > port_priv = ib_get_mad_port(device, port_num); > if (!port_priv) { > - dev_notice(&device->dev, "ib_register_mad_agent: Invalid > port\n"); > + dev_notice(&device->dev, > + "ib_register_mad_agent: Invalid port %d\n", > + port_num); > ret = ERR_PTR(-ENODEV); > goto error1; > } > -- > 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2017-01-19 at 16:48 +0200, Yuval Shaia wrote: > Print the invalid port number to ease troubleshooting. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > v0 -> v1: > * Fix typo in commit header I chuckled ;-) Applied to -next area, thanks.
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index a009f71..57f231f 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -316,7 +316,9 @@ struct ib_mad_agent *ib_register_mad_agent(struct ib_device *device, /* Validate device and port */ port_priv = ib_get_mad_port(device, port_num); if (!port_priv) { - dev_notice(&device->dev, "ib_register_mad_agent: Invalid port\n"); + dev_notice(&device->dev, + "ib_register_mad_agent: Invalid port %d\n", + port_num); ret = ERR_PTR(-ENODEV); goto error1; }
Print the invalid port number to ease troubleshooting. Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> --- v0 -> v1: * Fix typo in commit header --- drivers/infiniband/core/mad.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)