From patchwork Tue Jan 31 21:08:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 9548509 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 490D260415 for ; Tue, 31 Jan 2017 21:08:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3C28E281A7 for ; Tue, 31 Jan 2017 21:08:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 30E392838E; Tue, 31 Jan 2017 21:08:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6882B281A7 for ; Tue, 31 Jan 2017 21:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750921AbdAaVIN (ORCPT ); Tue, 31 Jan 2017 16:08:13 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:47204 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbdAaVIL (ORCPT ); Tue, 31 Jan 2017 16:08:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=References:In-Reply-To:Message-Id:Date:Subject:To:From; bh=dzCEbEl+W/s/Yb2Va3LqgoNzmkeYTivqatWB3G292i4=; b=irki4GnGMhRY4fEBswPsn6+Y2WGNH3rYA39aYylhXeW7iI3wJR/OuK4rHDbDcJUMqrb+cktGp5gtU3eAVO5xFkiy/RzjupTTbLUmPPOjcqlZBvUewVD9s0zPVO20W/VBt+KI/K23PjPV0RwIKP6nBlxBzhJhr69GiErnkmR1XOw=; Received: from [10.0.0.156] (helo=jggl.edm.orcorp.ca) by quartz.orcorp.ca with esmtps (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1cYfes-00040y-HM for linux-rdma@vger.kernel.org; Tue, 31 Jan 2017 14:08:10 -0700 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org Subject: [PATCH rdma-core 5/6] acm: Fix snprintf truncation Date: Tue, 31 Jan 2017 14:08:05 -0700 Message-Id: <1485896886-23517-6-git-send-email-jgunthorpe@obsidianresearch.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1485896886-23517-1-git-send-email-jgunthorpe@obsidianresearch.com> References: <1485896886-23517-1-git-send-email-jgunthorpe@obsidianresearch.com> X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gcc 7.0.1 remarks: ibacm/prov/acmp/src/acmp.c: In function 'acmp_open_endpoint.part.11': ibacm/prov/acmp/src/acmp.c:2499:29: warning: '%d' directive writing between 1 and 3 bytes into a region of size between 0 and 63 [-Wformat-overflow=] sprintf(ep->id_string, "%s-%d-0x%x", port->dev->verbs->device->name, ^~ ibacm/prov/acmp/src/acmp.c:2499:25: note: directive argument in the range [0, 255] sprintf(ep->id_string, "%s-%d-0x%x", port->dev->verbs->device->name, ^~~~~~~~~~~~ ibacm/prov/acmp/src/acmp.c:2499:25: note: directive argument in the range [0, 65535] ibacm/prov/acmp/src/acmp.c:2499:2: note: 'sprintf' output between 7 and 75 bytes into a destination of size 64 sprintf(ep->id_string, "%s-%d-0x%x", port->dev->verbs->device->name, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ port->port_num, endpoint->pkey); Signed-off-by: Jason Gunthorpe --- ibacm/prov/acmp/src/acmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ibacm/prov/acmp/src/acmp.c b/ibacm/prov/acmp/src/acmp.c index 56567ef8bf379c..fb6684f2eac1f5 100644 --- a/ibacm/prov/acmp/src/acmp.c +++ b/ibacm/prov/acmp/src/acmp.c @@ -174,7 +174,7 @@ struct acmp_ep { struct ibv_mr *mr; uint8_t *recv_bufs; struct list_node entry; - char id_string[ACM_MAX_ADDRESS]; + char id_string[IBV_SYSFS_NAME_MAX + 11]; void *dest_map[ACM_ADDRESS_RESERVED - 1]; struct acmp_dest mc_dest[MAX_EP_MC]; int mc_cnt;