From patchwork Mon Feb 27 22:04:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9594317 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 39331604A2 for ; Mon, 27 Feb 2017 22:10:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A9F228236 for ; Mon, 27 Feb 2017 22:10:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1DCBE28491; Mon, 27 Feb 2017 22:10:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D2B428236 for ; Mon, 27 Feb 2017 22:10:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdB0WJm (ORCPT ); Mon, 27 Feb 2017 17:09:42 -0500 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:58886 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751529AbdB0WIs (ORCPT ); Mon, 27 Feb 2017 17:08:48 -0500 X-IronPort-AV: E=Sophos;i="5.35,215,1483977600"; d="scan'208";a="93218879" Received: from mail-by2nam01lp0177.outbound.protection.outlook.com (HELO NAM01-BY2-obe.outbound.protection.outlook.com) ([216.32.181.177]) by ob1.hgst.iphmx.com with ESMTP; 28 Feb 2017 06:20:42 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mX9t48kfNjUmja1aNwnvTmSVC5mrpWBj/QD5m1e6J54=; b=sjNKwd4llmKSw6EcQc70cuTs8sBMezSjiinDIbv2PNBEmr/uV3W/HZpZ3ddPKkiCnWmEjk55Vt1prIebY42XqmyrNDRy/zmvULm//RpFe0Ch4CAbvYeTAHo2Z+SgsCdkjfhezMCJrEFyPEiSpfbTgIhJp1JVJ2va33ldrjqt1PA= Received: from BN3PR0401CA0039.namprd04.prod.outlook.com (10.162.159.177) by BN6PR04MB0739.namprd04.prod.outlook.com (10.172.198.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.12; Mon, 27 Feb 2017 22:04:37 +0000 Received: from SN1NAM04FT061.eop-NAM04.prod.protection.outlook.com (2a01:111:f400:7e4c::206) by BN3PR0401CA0039.outlook.office365.com (2a01:111:e400:51d1::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.12 via Frontend Transport; Mon, 27 Feb 2017 22:04:37 +0000 Authentication-Results: spf=pass (sender IP is 74.221.232.54) smtp.mailfrom=sandisk.com; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=bestguesspass action=none header.from=sandisk.com; Received-SPF: Pass (protection.outlook.com: domain of sandisk.com designates 74.221.232.54 as permitted sender) receiver=protection.outlook.com; client-ip=74.221.232.54; helo=sacsmgep14.sandisk.com; Received: from sacsmgep14.sandisk.com (74.221.232.54) by SN1NAM04FT061.mail.protection.outlook.com (10.152.89.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.933.11 via Frontend Transport; Mon, 27 Feb 2017 22:04:36 +0000 X-AuditID: ac1c2133-d1e189800000c960-e7-58b4a2720e8f Received: from SACCASIP04.sdcorp.global.sandisk.com (Unknown_Domain [172.28.1.254]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by (Symantec Messaging Gateway) with SMTP id 89.33.51552.272A4B85; Mon, 27 Feb 2017 14:04:35 -0800 (PST) Received: from ULS-OP-MBXIP03.sdcorp.global.sandisk.com ([fe80::f9ec:1e1b:1439:62d8]) by SACCASIP04.sdcorp.global.sandisk.com ([::1]) with mapi id 14.03.0319.002; Mon, 27 Feb 2017 14:04:33 -0800 From: Bart Van Assche To: "sebott@linux.vnet.ibm.com" , "dledford@redhat.com" CC: "gerald.schaefer@de.ibm.com" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" Subject: Re: IB on s390 broken with commit 99db94940 "IB/core: Remove ib_device.dma_device" Thread-Topic: IB on s390 broken with commit 99db94940 "IB/core: Remove ib_device.dma_device" Thread-Index: AQHSkUV5bXLvj268BUOFqjanpqXBbA== Date: Mon, 27 Feb 2017 22:04:33 +0000 Message-ID: <1488233058.2597.1.camel@sandisk.com> References: In-Reply-To: Accept-Language: nl-NL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.254] Content-ID: MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsWyRobxn27xoi0RBk9auC1env/AarHzzQs2 i8u75rBZPDvUy2JxquswowOrx8FHh9g8HhzazOLxft9VNo/Pm+QCWKK4bFJSczLLUov07RK4 Mu5cP8pWcEm+4s+S5cwNjJOluhg5OSQETCSurT7PBGILCSxhktjdGNbFyAVkH2OUWHHoBiNI gk3ASGL2hD0sILaIQJbEx4v7mEGKmAV2M0q0XTrPDJIQFoiV2N+wkRWiKE5i1db5UA16EqvP LwAbxCKgKnHmxXuwOK+AocTZy0vZIDY7S2ya9xdsDqeAi8SqxdvZuxg5OBgFZCVaXnODhJkF xCVuPZnPBHG0gMSSPRBrJQREJV4+/scKYStIfF7xjw2iXk/ixtQpbCBjmAWsJK63RUGEtSWW LXzNDHGBoMTJmU9YJjCKzUKyYRaS7lkI3bOQdM9C0r2AkXUVo1hxYnJxbnpqgaGJXnFiXkpm cbZecn7uJkZwFCoa72D8t8H9EKMAB6MSD6+F8ZYIIdbEsuLK3EOMEhzMSiK8velAId6UxMqq 1KL8+KLSnNTiQ4zSHCxK4rwxs6dGCAmkJ5akZqemFqQWwWSZODilGhitl/WY7Fr5ubXqRFfr RNkZ2/5Nkw+TfMgr67AtWN1szZ/TG+MEj6R3uZs/YgnKjGl49uDLL/ac6rKON/qybyctqf3i 6uL1asXvT/OZvzX84m3eeUAu+dTxv2vWJuoGftW/nh7rsvP+6/DZ2UyT3jodjwpfE9e1e2Oy 7MmAIrUMnQIbYcZbq+KVWIozEg21mIuKEwGyNCFFvgIAAA== X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:74.221.232.54; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(7916002)(39410400002)(39450400003)(39860400002)(39840400002)(39850400002)(2980300002)(438002)(24454002)(377424004)(189002)(199003)(68736007)(106466001)(86362001)(2501003)(189998001)(2950100002)(69596002)(6116002)(5250100002)(102836003)(3846002)(2906002)(4326007)(8936002)(5660300001)(106116001)(305945005)(54356999)(50986999)(76176999)(229853002)(7736002)(47776003)(54906002)(626004)(81166006)(81156014)(8746002)(23756003)(36756003)(356003)(33646002)(50466002)(2270400002)(8676002)(2900100001)(53936002)(97736004)(92566002)(38730400002)(6246003)(103116003)(7099028); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0739; H:sacsmgep14.sandisk.com; FPR:; SPF:Pass; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM04FT061; 1:KWkY+zgqDZVG9Oq+Qw6iAlElLNpPbEsWHwbotx45RyTxm8beEMdZ9u4V2JOSX1sbMWITbTsutnoHIHApTVocL5GfE+ylADwaosdMIfOnntwD83AtapLuQYNG4Ix6Ox0H6AIOD1o45Fa23nIX07qSMtNnubWeDYyEC2SnhCqD/3/fA/rxorMI+bVBTAq4cgwglJ75reKtSCOGezlGaS5xZuZ25L7iZFQEDe1Nz+S51ykJFufxzy3gtQln+21wgy4mxXHtYjVQDMbvCpR1J5UCxnJBM7eBr4dd1mpgUSn1lM14LqO00TgcmwDw8TJtLFk486ueNdbobp/iqX9SGABua8uqCFKmAVV/eE7T5XAFZWsAaEphVchx5ZQDSHVeS+3VpcEY0TQM3o3x65Aos0PhEEdVIG2NlLQ2vUMan6ZuZmf0H0iodbFBbuGtWnoZukJXi/fBAivIzc8xOg5/oqBIDxKtv9hZrrWSqBLi7SH7MKG/AtC865NvgDgaBgBcgcRkyJaFYGGrQsVwA0wsEneDviYoe7xQ4J9cjGyzIXA5Y6nqzqYyD7sMixsdzwFRZiAB X-MS-Office365-Filtering-Correlation-Id: d8077dd3-0f60-42c7-3cdd-08d45f5c9ebd X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(8251501002); SRVR:BN6PR04MB0739; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0739; 3:PU0uZhPM79UbOeAGAWRoBl8c3sSyfZFgCYi4kP92OSHPNENqrRhZ1+8+d/dOaLMuVjo076kxPdEg2GuymY+pXCeeMHIZCacbyVVoUu7INOJ5jRjQ1PfqiYWqIDO9v8qRJJnNonqUrutqDM/XeeIOq6P88BygK8LsJqpJ8IudLGVKe2ifCL2fYtZlckIYMCcZQ2XOzFLLKNgX8LnzJj2RWC2fdJm4AStVTlb4lQ7LsV/IX3SD7XcYSCWB/fBTidQnMDZS2ytdJDQh58B8VK0hsBO7y+fDlXM7Hhbxrmfp+c24h52kTVq2mOEP8WSx+q63/RJMa7sCRNbGHeCo8HKl1hKoD8G/f7us4p4NoCY5vKMcJ9twZT4Ek5jtJvMYAncKVBFwNPFjG4Hq7GkhqFvgyQ==; 25:WJcLHLMabQQRx2bBbIj97MVmCzVYZn6wBva0kNdzG1puyXaqKLWzaDBiLdVUY69HpeQMaCYVJzgFbYyqx98bzBisy3KxaOXfM6/07lofOE0e8I+qjtZJvX5Rfbayn71Y4iwOleHGT5GssYBzOV7C8V2zElVQaA0G7lpvqmUHdtMEKAkgKC7YEbEykTHpBil44oigf2lFd2SHkNQTBqBXNa6zDgsRAVqhxO8euE6xUgFnwW2p26L0b/31/df8vqCpygi/kjEzBBM0MxszjEtrpXmhFzNEH4DL8wzhNM66wkJweniecrcI4RQiu1t6rS+BKBCADr+FL/Xokt7CfmUbxlZc8OJg6bOBiYxqlEWRLMPOonvQuV0gRWGnHB+ZXO2I3mgqd7JDO/8kxU5Pfk6cWd6ynBC0ZxjD8dDu7PEITVv7INqGGelwu84QAGYr/kpKobu1pvmLQL81++dO37ALCg== X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0739; 31:F/1hvJOb8fRj4tpkbd9qj28damS3sJ+xzRb0Elgbg/nPrfB4IJtH9guchJjf821idqY1dAY63Z4KCO+GuU/4uki5CLbM556B4Dmt/VXLvSfrS6V9bPzSKLNIuDzgBjjG71iajOR2+kGgObPdyV7W+tYJ+ZPDwEb3BAWsv/wqsRtYWg/M40CfT0M0hiDTLiyaGa3XLfiuXo4y+znbh5AR9pFmLZD6YKjUv6Xm3o/tGCpnMaF/SWW0Lrp7fjhWF78BHGySWshXibSdIH2mnoyUznqeeAw/KOJZVA0PkT/b2wM=; 20:UEKQGTG7URus95dYamjYyOmF/je8rIEWkYvZGzfAC+/1Rg5+Bruie+05HBvJEg9py8H3TcM9LN+k6pximrOBlt+qYZWbWqeg3ZdCgH/MfDHUUhtmlJxz+pWQO2QGsBxQJw0DakMMB9LPZRAVMLZ4HrSywzWCiFMWlJQj/e0rFh2DJjrv/wN+FRiKzZIF553HNipwG+TQvXgjGdnNY0uc3BMmWfFXlHTI31pvtQqO9PmseZj9mXvf5FdpzPrTN70fMqpBOofrhNIh5+oxT1n7fxDKrAZwmWQQsrChSsRW8pRDYKUNiz6xJbZ8HwD6KbQNY8m68m0giOC/8ysQx2HbJgjo2M6NqOq44JQnPib0PwpSRW9RIdvD589WwEGFvkKkk6KD6ZszHOFtDsMoEbAjhKdC2TVaF9WgkAstrJPHfJp13rYjvHtL35/RY2slmCgjQvYtldjkMrKPQ6MmWZlMvLHAy31bn1sirtzbxzj58A548OdcbTdE70iJIxu+Vv+D X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(131327999870524); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(13017025)(13015025)(13024025)(13018025)(13023025)(8121501046)(5005006)(3002001)(10201501046)(6055026)(6041248)(20161123558025)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148); SRVR:BN6PR04MB0739; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0739; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0739; 4:28Wi1QVWRsMGqYZVLNXE8kMdznq0QQF6r5dLkyE8Kx3grJ0MXxmXoAx5O0hpJq4VhVCQOmQ21SZDaBuXgAjJ3/ceJwIRvpQiIfLGt3rNUwecO5gSOeEFrdFJRjjl2FIB329FMZxACNwmBYhVWiWBN45mwQcBiVN4pM5zKJxvnOpQSwvAMrynPsVSPfPtH671jWObfKpF+JFq9JceoP0FpMG5QzWOo4wZj6TcB/f5vsfnUbeXRXv5PSkMJlHzVKxDVl9sJPYMFSdLRSo8PQv8CLeLtkl/ul5UwTQ0pbeixGSasrKAMmnSpTZWV4J1Zg6tk4jNZudld1u3r6Y0knc4EkCL9lDhfyThp/9knnWo39QyWfOeDJSAf17c17wteCJB2/1bQ/FIyJhRBywhvh38dXDurol+12bwma3zX7ymFyyrxZ2uoVU+P5Ie1ylbWx3uNTNzES5wra6jDvzFVC/hBdWla3Ybh/ISoUXgOXjs2UAnTuqqPNbw0oE4BKGg3ufbxVKpihlfpiuyXfGm7EQrABd4Ha3T67oSwNK0YXC4djhD0iNfxClY84k9kIEDvOlLDlrkR7mEiMdayG3eI4iMPsIQMAneCt3/xUiLQNxZuhtTrZq3FErYQ3BKOXCG/tZRSej0wVaM+jfAPcTQq7v+GRKdqLiSxBHFaWjmP6sECKtJzPWwRMGXvv3ANeHaHdX/yKsMc+5GfjZLOcL7XaZOtlCyROTVsEWP7gxQAS7ao+Q2gJbxrKwa79SpG4wj4CoB5EyRQP+yxOwiZzDXTVQXlg== X-Forefront-PRVS: 02318D10FB X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; BN6PR04MB0739; 23:HMY+B4bfZoDAu4RTfX1UpuPWio7rncP73i5LoQ9?= =?iso-8859-1?Q?OmIa6LJXYLlRfX7L6IGJc8R4XysP+Oetth3o/rdvKT56zxXp0N8jNRPhic?= =?iso-8859-1?Q?rckSZXgsPGthDbhTqlthgrbkM27mnqNcz4Gyq/t1lClqpbW9JDASsjM/l8?= =?iso-8859-1?Q?9bXPZt0IwmqwQBXRyCzPM+4TUYD31jtD38RCKxTL0TQrHaTD7X/NQ6bvNN?= =?iso-8859-1?Q?ZAh5NysH2A5E/Cqt6L1AookmF+0dpFeMSa7JKE7pj1gVHl6LEMyUKZmhds?= =?iso-8859-1?Q?L/C+67OS0MuL+W1K3KdM4gkIT4McWfAX+UesId6mXTyl8X9x0Ve7847fvh?= =?iso-8859-1?Q?JnTtuxWTpoPzvm44+H/CFjjC1AjkQcESF3AjrsvuDXTiua7sRTxbRkOCp0?= =?iso-8859-1?Q?N/m6sqIwLJPybodDFEsV9qVSWdSUd7ArR/uTV6NfOjLq5eMRxaDkoawfss?= =?iso-8859-1?Q?xSsG/9Sk9QFoOV0Op8Z4u0/QlSraP2JWiPYYI+bmDosImV69Ya+9uBQmaw?= =?iso-8859-1?Q?ogmeth2W+beU12cOHY61CADQDFTfHJypBiAhbofnDKfQ+ALW4BQiOe9KjE?= =?iso-8859-1?Q?9dqpK9PsKGvvCpn5jlGr66Ci6BeoXln5s2jqCbC6/pvBQ73SNMeTE47p9D?= =?iso-8859-1?Q?fqiE79EeaFvO5pamyFZUTqHYKAdHegCxu8ZbX9i5hRQ2NAr+penpS9el1X?= =?iso-8859-1?Q?w1PDItW5NhgSZ2KnTrfxsROm84ue3kyhuQRiHlxr87B0JaRaAZKqLJkklB?= =?iso-8859-1?Q?5BK/5z65t++Eymt0ucVS0EQiX7IpbLG2tzLSc4Kq9AFpEO6DxbUwYZLDfI?= =?iso-8859-1?Q?/nFYhROOXMEyxsuA/WKdayadtGjhm+I5lUC1z2EDZG6/mNVpX8+VKQAHQv?= =?iso-8859-1?Q?kyFYW78hqGRHL8qiPTxPAmlxNW98gbaifCE2zC/nNgL5ixUPQkZUr8eCyB?= =?iso-8859-1?Q?6PdYWbbJtx9gKnm3KgbalFlUIJSxMmgR5TzwWGKCQVrGpOSp/sE2rkcpfp?= =?iso-8859-1?Q?nAzlu2wwoVZwtKCZ5QM/t1CWTmysO9XKOrhpTAo61ocMgT8EB7X3QlGldy?= =?iso-8859-1?Q?2MPgrDf6HzitBpBPRRItaUU3ygVBFlmzd2eYqkzX+4SNYw0TvkfSdb5zTy?= =?iso-8859-1?Q?EeP76mt4PjbgivvfZcO6VH4MU0D/8Ff0ao4fWCS3Qhi3SK9Og2pyamu9mU?= =?iso-8859-1?Q?RsjFWfyDHKKXCDNFPIiXlwo1EOAnUqlvjCR54TzIPSs71fIze9ucQ0yZBh?= =?iso-8859-1?Q?xH9dCjM7HtHR43+IC/1nN5YYoaDQaweMbdBqEyYU4+5ScRVpIO1m593zpX?= =?iso-8859-1?Q?QhK3H/7obdH5y+7+nZUgblJP6RcazpuFm8HmYWWVPhGTTfsIPUyUQmzGtU?= =?iso-8859-1?Q?c+9iqK6mYRr0yAaV7J6keJYylH3Z2?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0739; 6:36P8v3jDOEEgloUqB7AE3vrkm3HWNgH3HneuGO+yMLzkRGGXDuoAbhelHBl/yBD8aYBUmlYQS9doAQNc+CUJfYZcb//deBUGQVeJ0mWpbqsJEXJFXbXa6bFv0eyW3G9AAALyX9uGTr/fZ6Y/cj8jF4RhCWS1QsxrmxpNDhD78rcZSQ8K6FFd9zFU5i3Y14Wpuxf/zJKYEVdA3Kx98ZtSfvgDkEoCe96vmLfJ3nY5aC5Mz9lxUQqL4c/rftNiXLw6h9FQOzvOxgHNrINj46+WRNazOAya/Nf8BFNq3BPGRuXWrvq2/nrCRqpBQCcnXw+Krltnmuj/PN0TjrIbYWOk8dJiKNV1pahUO7y0BpxM+hYMTFAsOjC0/qsbw7sWTGTn6sa5mV109K6Sem41YHMfng7UMbMCSoUTItmjs9wJEmo=; 5:rxcN8gGw4ItNjhS+XCYYn2+LPoTxcxT38qvssGYuJwkiwwNQxfzsqETad+MQ0ZOi0rGNrINWaILenCymFxyMuAA8CgB8bzJO+d5FiNQV9VzPmxJVH36ZbWrDDMQE733KgT2RSSfjj9FJakfJoLIbfA==; 24:KMyb1TuRtTQqQsqL7u76g8eWnEVPslmNc5dcJ5+yZhl2mL9Nh8Rl4ZdMMPIs6uXWLZHiG5HwPNaB/OYPYZUzb0VemedwDMR+E0TcS8Vs5iQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0739; 7:9Xjic8MJwA4yEpZBec95W6BhxCsvVoBTwKiedZxMkzH8eaINqZ2uf6RZFPz9TsW2MkTCY1MhjGGJ1xgCZ5ExmS5N+l97Z9ju7Ys/pf77OV9B4yw84we2jnYvgvSqn+5+9oD10PlspDJPU+RP4dHqkAyno255BYDtAuWvUwuhdzNfWqYUQmle/cd6tzjqG9uk9I/Ebt7SWh5W1QtB6ifhedEgsYSr1S3GaiDddsrgtOISZ0JeuUcuxCxF8LASvSKPbQpRBl2KT5A1FECnNEiExfD/KIjnBxFDzwvmEFZOaQb2WWuaO+FYSa42yAeCXyBJDdWOVLjhi5BGJJxwbpHdyQ==; 20:yn4O+P6B/1/kFV7M8hakQUfZdZSi/JWFafBS4kD93uRbr9VUFKspHdUagp5vouOCxEUs1WF/pXODBqGmmp6V4I2ajEt0yaGR23eoTldr012UJ1hKIqW94LREtIPOe6Higr6l08KhKdo3eny72LliTsg1zOkn4T/TKLEYgqWUvKpbf+aevP6ZZBs5YGprlI8RKWsvte1A4udp9zXLWkljQ5aOsKC3jam33w0Z2oiWBXk96gb3+F1Lh7KnSADJ273K X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2017 22:04:36.6226 (UTC) X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=b61c8803-16f3-4c35-9b17-6f65f441df86; Ip=[74.221.232.54]; Helo=[sacsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0739 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2017-02-27 at 21:17 +0100, Sebastian Ott wrote: > commit 99db94940 "IB/core: Remove ib_device.dma_device" > breaks infiniband on s390 (and I think also other archs that do something > like to_pci_dev(dev) in one of their dma_ops callbacks). > > With this commit you use the dma_ops of the device that called > ib_register_device but you call e.g. dma_map with ib_device->dev > as an argument. > > S390's (pci specific) dma_map uses to_pci_dev(dev) to look into the > pci device (and its arch specific data) and oopses. > > Calling dma_map with ib_device->dev.parent would work but then it > wouldn't make sense to copy dma_ops and mask from ib_device->dev.parent > to ib_device->dev.. How about something like the untested patch below? --- drivers/infiniband/core/device.c | 5 ++++- drivers/pci/probe.c | 1 + include/linux/device.h | 5 +++++ include/linux/pci.h | 5 ++++- 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index a63e8400ea3b..989077fc6dbb 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include #include @@ -336,8 +337,10 @@ int ib_register_device(struct ib_device *device, struct device *parent = device->dev.parent; WARN_ON_ONCE(!parent); - if (!device->dev.dma_ops) + if (!device->dev.dma_ops) { device->dev.dma_ops = parent->dma_ops; + device->dev.pci_dev = to_pci_dev(parent); + } if (!device->dev.dma_mask) device->dev.dma_mask = parent->dma_mask; if (!device->dev.coherent_dma_mask) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index dfc9a2794141..60d739b59520 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1736,6 +1736,7 @@ struct pci_dev *pci_alloc_dev(struct pci_bus *bus) INIT_LIST_HEAD(&dev->bus_list); dev->dev.type = &pci_dev_type; + dev->dev.pci_dev = dev; dev->bus = pci_bus_get(bus); return dev; diff --git a/include/linux/device.h b/include/linux/device.h index 30c4570e928d..c18afd376d2a 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -42,6 +42,7 @@ struct fwnode_handle; struct iommu_ops; struct iommu_group; struct iommu_fwspec; +struct pci_dev; struct bus_attribute { struct attribute attr; @@ -860,6 +861,9 @@ struct dev_links_info { * segment limitations. * @dma_pools: Dma pools (if dma'ble device). * @dma_mem: Internal for coherent mem override. + * @pci_dev: PCI device associated with this device. Used by DMA mapping + * operations on architectures that need access to PCI device + * structure elements that are not in struct device. * @cma_area: Contiguous memory area for dma allocations * @archdata: For arch-specific additions. * @of_node: Associated device tree node. @@ -940,6 +944,7 @@ struct device { struct dma_coherent_mem *dma_mem; /* internal for coherent mem override */ + struct pci_dev *pci_dev; /* for DMA mapping operations */ #ifdef CONFIG_DMA_CMA struct cma *cma_area; /* contiguous memory area for dma allocations */ diff --git a/include/linux/pci.h b/include/linux/pci.h index 282ed32244ce..ba1222f32046 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -409,7 +409,10 @@ static inline struct pci_dev *pci_physfn(struct pci_dev *dev) struct pci_dev *pci_alloc_dev(struct pci_bus *bus); -#define to_pci_dev(n) container_of(n, struct pci_dev, dev) +static inline struct pci_dev *to_pci_dev(const struct device *dev) +{ + return dev->pci_dev; +} #define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL) static inline int pci_channel_offline(struct pci_dev *pdev)