From patchwork Mon May 22 10:15:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 9739861 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8149A60392 for ; Mon, 22 May 2017 10:16:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6070E286EC for ; Mon, 22 May 2017 10:16:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 554FC286F3; Mon, 22 May 2017 10:16:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C637F286EC for ; Mon, 22 May 2017 10:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758409AbdEVKQd (ORCPT ); Mon, 22 May 2017 06:16:33 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:32851 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758397AbdEVKQa (ORCPT ); Mon, 22 May 2017 06:16:30 -0400 Received: by mail-pf0-f176.google.com with SMTP id e193so78096282pfh.0 for ; Mon, 22 May 2017 03:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WY4sZPIaJVoRoAvLesKjr2Qx22Ud9oyGngnxz/G7A70=; b=Zl0dcMvoUmrzxe4TCuT6WytPFRbsuV/00ACVlwa/LGFhzl5rpI9GKSVt63UyUsR0Eu CSAmHzq9ivzd53RwRsodDvaIFlbcA907inXRnRQ2tFiY85+mdq601+AzXdFQOrtaQVF5 wdvupPQZTKaPVIqqyZpILzTCU9h/1DHnVAtmc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WY4sZPIaJVoRoAvLesKjr2Qx22Ud9oyGngnxz/G7A70=; b=fzmCcukQ7vs6LKHB3OiUr2g6NM+0ZBekDiXM0ReMSU+kVzcu+5iCgraY7rBUKH9Aqi 3rI6kIKXj6J9luClrk9kN7cTJbmSjsk3JrH87Zq4HEkF+Xe8e8S/VAFXsVdWsK28mSDg HIWWpTxY74Brv8i8wOcSGqj2B+4maHROVUgyNJdG1MdNUty/DSfRSaO5KVFkajMpjWmj IBX0qXhxiqc1AguZMT4rC2SIp5f+X9mswP4bXlFMc21LKwRNqpv+g5z4MSoaHR0cBxLA q/G/QZHndTYNKyJNNftq1p1Htix3Q8XulXbMtTtUq4S8YxUPGwqIPUCCmvT7jvfFuMQH Ntkw== X-Gm-Message-State: AODbwcDbIQNRaOeksxn+gL74UM64rEdmk1zthgD581qSy9D3r6Wdazjc Rlfwb98S8uFdcuqIh5o= X-Received: by 10.84.222.136 with SMTP id x8mr28303506pls.50.1495448189772; Mon, 22 May 2017 03:16:29 -0700 (PDT) Received: from dhcp-10-192-206-197.iig.avagotech.net ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id m12sm38283211pgn.30.2017.05.22.03.16.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 03:16:29 -0700 (PDT) From: Selvin Xavier To: dledford@redhat.com Cc: linux-rdma@vger.kernel.org, Somnath Kotur , Selvin Xavier Subject: [PATCH V4 for-next 07/14] RDMA/bnxt_re: Fix WQE Size posted to HW to prevent it from throwing error Date: Mon, 22 May 2017 03:15:37 -0700 Message-Id: <1495448144-18966-8-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1495448144-18966-1-git-send-email-selvin.xavier@broadcom.com> References: <1495448144-18966-1-git-send-email-selvin.xavier@broadcom.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Somnath Kotur Posting WQE size of 2 results in a WQE_FORMAT_ERROR thrown by the HW as it requires host to supply WQE Size with room for atleast one SGE so that the resulting WQE size be atleast 3. Signed-off-by: Somnath Kotur Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index 0716298..6a07e4b 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -1128,6 +1128,11 @@ int bnxt_qplib_post_send(struct bnxt_qplib_qp *qp, } /* Each SGE entry = 1 WQE size16 */ wqe_size16 = wqe->num_sge; + /* HW requires wqe size has room for atleast one SGE even if + * none was supplied by ULP + */ + if (!wqe->num_sge) + wqe_size16++; } /* Specifics */ @@ -1364,6 +1369,11 @@ int bnxt_qplib_post_recv(struct bnxt_qplib_qp *qp, rqe->flags = wqe->flags; rqe->wqe_size = wqe->num_sge + ((offsetof(typeof(*rqe), data) + 15) >> 4); + /* HW requires wqe size has room for atleast one SGE even if none + * was supplied by ULP + */ + if (!wqe->num_sge) + rqe->wqe_size++; /* Supply the rqe->wr_id index to the wr_id_tbl for now */ rqe->wr_id[0] = cpu_to_le32(sw_prod);