From patchwork Wed Jun 14 10:26:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 9786059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C3F5760325 for ; Wed, 14 Jun 2017 10:27:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFF9428547 for ; Wed, 14 Jun 2017 10:27:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B5036285E5; Wed, 14 Jun 2017 10:27:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 442F828547 for ; Wed, 14 Jun 2017 10:27:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751820AbdFNK1M (ORCPT ); Wed, 14 Jun 2017 06:27:12 -0400 Received: from mail-qk0-f176.google.com ([209.85.220.176]:35934 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbdFNK1L (ORCPT ); Wed, 14 Jun 2017 06:27:11 -0400 Received: by mail-qk0-f176.google.com with SMTP id g83so23312475qkb.3 for ; Wed, 14 Jun 2017 03:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZRo0Yi9HzDaVUaQEwsziUrQWsgIIIIBPzoB/MDNKAa0=; b=Q5lrVobLnBOxvjXGZTnPh+QAvYyuGyHi2A2r29wl0JEycpNxabTCB8iJ0QazAg145+ ZmkbxQNUjO0Nhl+FHWH7GyzAACfFR2IZne5FWjnJk1IdxjwMhQwyEswYqn6Y+9FwVG6B EEWRTdqS0FkbHgn0DeSukUcIbqBMbyNhMdDY4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ZRo0Yi9HzDaVUaQEwsziUrQWsgIIIIBPzoB/MDNKAa0=; b=rHeFL8fl7XyBqi4isHYPhbCXfBMgl18TPZmfKlidV7Hw/ok9Z5AA5/pqOCeeQiN3tk gG1Ju/Rso0FubaGN+nZ/wXnAbWkED81Eq1g0tNlDXpjPPjjl1VAvkcQdcBrVcrdcLOP7 ebB+5EfuxVFoNjxhALBB/4MPmL7zLBdarqBBKDPmxSgJ6pVrETr7mVNNcc2mSDKVhWyo MqUG26d6kHIhGhZ+qUtSh4cNxssj0R+UItnJxTegzaKlkpwwtobFtL4BtWiteOBZwlkR a8TyqCqzWqbPAVI5eUsUz0l6QUxUuM/gDldsZj7ZEXOXNpoVqOaf2BQ3P9iTiukO0xjD YDsg== X-Gm-Message-State: AKS2vOyEsx919LA/qrVwvjR6yPYTruuedEJUp1IuBPUODqkEss1XbOnw T8g9stiQFKuyx1TJfiQ= X-Received: by 10.55.151.69 with SMTP id z66mr5583056qkd.90.1497436030940; Wed, 14 Jun 2017 03:27:10 -0700 (PDT) Received: from dhcp-10-192-206-197.iig.avagotech.net ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id o49sm285065qta.34.2017.06.14.03.27.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jun 2017 03:27:10 -0700 (PDT) From: Selvin Xavier To: dledford@redhat.com Cc: linux-rdma@vger.kernel.org, Selvin Xavier Subject: [PATCH V5 for-next 04/14] RDMA/bnxt_re: Dereg MR in FW before freeing the fast_reg_page_list Date: Wed, 14 Jun 2017 03:26:25 -0700 Message-Id: <1497435995-20480-5-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1497435995-20480-1-git-send-email-selvin.xavier@broadcom.com> References: <1497435995-20480-1-git-send-email-selvin.xavier@broadcom.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If the host buffers are freed before destroying MR in HW, HW could try accessing these buffers. This could cause a host crash. Fixing the code to avoid this condition. Signed-off-by: Selvin Xavier --- v4 -> v5: - Rebase the patch to the for-4.13 branch drivers/infiniband/hw/bnxt_re/ib_verbs.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index c31f152..c750d8f 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -3037,6 +3037,12 @@ int bnxt_re_dereg_mr(struct ib_mr *ib_mr) struct bnxt_re_dev *rdev = mr->rdev; int rc; + rc = bnxt_qplib_free_mrw(&rdev->qplib_res, &mr->qplib_mr); + if (rc) { + dev_err(rdev_to_dev(rdev), "Dereg MR failed: %#x\n", rc); + return rc; + } + if (mr->npages && mr->pages) { rc = bnxt_qplib_free_fast_reg_page_list(&rdev->qplib_res, &mr->qplib_frpl); @@ -3044,8 +3050,6 @@ int bnxt_re_dereg_mr(struct ib_mr *ib_mr) mr->npages = 0; mr->pages = NULL; } - rc = bnxt_qplib_free_mrw(&rdev->qplib_res, &mr->qplib_mr); - if (!IS_ERR_OR_NULL(mr->ib_umem)) ib_umem_release(mr->ib_umem);