From patchwork Sun Jun 18 14:37:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 9794833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BD7AE601C8 for ; Sun, 18 Jun 2017 14:38:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B023C28403 for ; Sun, 18 Jun 2017 14:38:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A517928435; Sun, 18 Jun 2017 14:38:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, URIBL_BLACK autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1239628403 for ; Sun, 18 Jun 2017 14:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753098AbdFROiI (ORCPT ); Sun, 18 Jun 2017 10:38:08 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:53975 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbdFROiI (ORCPT ); Sun, 18 Jun 2017 10:38:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ol63Gi6FCwmWZCqW+YpzSffJgizK2nMNJQprhIq0Ooc=; b=RT5oSji9CCPaHSsd1xGsNlCw0 Beq/ANf3IJhhUkZNcHn20dIldgHeX1qssJaHNphIYGoxScYFgrGoWneGdCm6RPLbyH+eKAI+ntzWD rhmUe0cUBRxpfCsIE0enjsvXRq8Rjyvu0eIfECuQA2dLNyX2+fEMoT1SxZrH0AULI6Htca6KGrlQo q87ro0r3igLPO+3CaxlAgFYqqcqv1paqA83p5ILnzy6W0kzR7yHf658hGUxdi9sE2hGq3hYs4KdmU WrWMzVwvh/kqRGLzizhK/dtsMrjDzjXRssVWcqDLg9hqH2ND/9w/fwGaBvE7hTQLwpoRfjviT6xJm e8pH5zBCg==; Received: from bzq-82-81-101-184.red.bezeqint.net ([82.81.101.184] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dMbL4-0006UR-39; Sun, 18 Jun 2017 14:38:06 +0000 From: Sagi Grimberg To: Doug Ledford , linux-rdma@vger.kernel.org, Saeed Mahameed Cc: Christoph Hellwig , Leon Romanovsky , linux-nvme@lists.infradead.org Subject: [PATCH v6 for-4.13 2/7] mlx5e: don't assume anything on the irq affinity mappings of the device Date: Sun, 18 Jun 2017 17:37:52 +0300 Message-Id: <1497796677-15794-3-git-send-email-sagi@grimberg.me> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497796677-15794-1-git-send-email-sagi@grimberg.me> References: <1497796677-15794-1-git-send-email-sagi@grimberg.me> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP mlx5e currently assumes that irq affinity is really spread first irq vectors across device home node cpus. This was designed to provide a good OOB performance, however, feeding RSS indirection table with only a subset if the RX rings is overall a loss both in RX efficiency (napi is processing more flows per-cpu) and in latency QoS in case the application is running on a cpu core that is not included in the RSS indirection table (with more QPI traffic). With the new generic affinity mappings this is no longer the case, hence mlx5e should not rely on this anymore. Signed-off-by: Sagi Grimberg --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 2a3c59e55dcf..1e344b445a47 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3733,18 +3733,8 @@ void mlx5e_build_default_indir_rqt(struct mlx5_core_dev *mdev, u32 *indirection_rqt, int len, int num_channels) { - int node = mdev->priv.numa_node; - int node_num_of_cores; int i; - if (node == -1) - node = first_online_node; - - node_num_of_cores = cpumask_weight(cpumask_of_node(node)); - - if (node_num_of_cores) - num_channels = min_t(int, num_channels, node_num_of_cores); - for (i = 0; i < len; i++) indirection_rqt[i] = i % num_channels; }