From patchwork Sun Jul 2 08:20:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 9821089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1402560224 for ; Sun, 2 Jul 2017 08:21:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 01A9728179 for ; Sun, 2 Jul 2017 08:21:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EA399283BB; Sun, 2 Jul 2017 08:21:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82FFE28179 for ; Sun, 2 Jul 2017 08:21:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751800AbdGBIVD (ORCPT ); Sun, 2 Jul 2017 04:21:03 -0400 Received: from merlin.infradead.org ([205.233.59.134]:34812 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751735AbdGBIVC (ORCPT ); Sun, 2 Jul 2017 04:21:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=osADy9wr3BiW6xGu3uixGTmc9RFFPg9xxJah1dEdalI=; b=kmtlT+IDkKANFOQjVXtnmNYEp lqhH4ABK1/eAVrT7D0X7Cqst2OjllM/IOyymdJbE5Toi13Ac1euaRMdJbonMnHYSCiceaCT4MIlp3 7yn/4u7/sbNoO9aNB23AtC2Di053sUZrEsm6oMoPMTchHCrpS1xaCy7J/E40cHxRXhE22I/M92bzV /kysTQb8RMA7f8mZMaVeixz4eBOjpWflvMbMDWSV6iQ8/+NdyIpYLZZ/d2TwsmJXO2JV5l5nUg1Oh xfStTgp1zhREPASmlAD3JPCRkcK+MUFf5dKRR4imDHi8cP7n1reWFHAE08OxsT6pMeyd7D+HMBZbe VhlhVyo7Q==; Received: from bzq-82-81-101-184.red.bezeqint.net ([82.81.101.184] helo=bombadil.infradead.org) by merlin.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1dRa7n-00062z-Me; Sun, 02 Jul 2017 08:21:00 +0000 From: Sagi Grimberg To: Doug Ledford , linux-rdma@vger.kernel.org Cc: linux-nvme@lists.infradead.org, Christoph Hellwig Subject: [PATCH v2 3/3] nvmet-rdma: remove redundant empty device add callout Date: Sun, 2 Jul 2017 11:20:52 +0300 Message-Id: <1498983652-18250-4-git-send-email-sagi@grimberg.me> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498983652-18250-1-git-send-email-sagi@grimberg.me> References: <1498983652-18250-1-git-send-email-sagi@grimberg.me> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Now that its not needed, we can simply not assign it. Reviewed-by: Johannes Thumshirn Reviewed-by: Christoph Hellwig Signed-off-by: Sagi Grimberg --- drivers/nvme/target/rdma.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index 56a4cba690b5..76d2bb793afe 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -1510,10 +1510,6 @@ static struct nvmet_fabrics_ops nvmet_rdma_ops = { .delete_ctrl = nvmet_rdma_delete_ctrl, }; -static void nvmet_rdma_add_one(struct ib_device *ib_device) -{ -} - static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data) { struct nvmet_rdma_queue *queue; @@ -1534,7 +1530,6 @@ static void nvmet_rdma_remove_one(struct ib_device *ib_device, void *client_data static struct ib_client nvmet_rdma_ib_client = { .name = "nvmet_rdma", - .add = nvmet_rdma_add_one, .remove = nvmet_rdma_remove_one };