From patchwork Thu Jul 20 17:01:00 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 9855377 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5095F600F5 for ; Thu, 20 Jul 2017 17:01:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3EB5A286CB for ; Thu, 20 Jul 2017 17:01:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 337DE286E4; Thu, 20 Jul 2017 17:01:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 94A092022B for ; Thu, 20 Jul 2017 17:01:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965452AbdGTRBN (ORCPT ); Thu, 20 Jul 2017 13:01:13 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:33739 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965335AbdGTRBM (ORCPT ); Thu, 20 Jul 2017 13:01:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=References:In-Reply-To:Message-Id:Date:Subject:To:From; bh=7WXCYNbGBrfxphPjGazE1FOOQAUtbGdwjc5feYH/76o=; b=Kp+QB1Xq04yOoxHkI/d3JDOUkD5mIoa7sN52RVS5ubWhS6O1HxWiqrS2qYfCKAhiaZMXEQcYaFnOer+PBX5duT4ndRAxdKIQdNdDGTj0Xuo71P0UKaVxPn1tAqEchtFI5Se/r0pynjmlvxX5NfZO8m0sZOehXsvZSLd9E67VN/A=; Received: from [10.0.0.156] (helo=jggl.edm.orcorp.ca) by quartz.orcorp.ca with esmtps (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1dYEp3-0000gv-3a; Thu, 20 Jul 2017 11:01:09 -0600 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org, Leon Romanovsky Subject: [PATCH v2 rdma-core 4/8] mlx5: Avoid sparse complaints about !! Date: Thu, 20 Jul 2017 11:01:00 -0600 Message-Id: <1500570064-11712-5-git-send-email-jgunthorpe@obsidianresearch.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500570064-11712-1-git-send-email-jgunthorpe@obsidianresearch.com> References: <1500570064-11712-1-git-send-email-jgunthorpe@obsidianresearch.com> X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sparse says: warning: dubious: !x & y Unclear why sparse thinks this is bad, but casting to C99 bool is the same as !! and much easier to read. Signed-off-by: Jason Gunthorpe --- providers/mlx5/cq.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/providers/mlx5/cq.c b/providers/mlx5/cq.c index 500116133c1f9e..9a8d958a9ced68 100644 --- a/providers/mlx5/cq.c +++ b/providers/mlx5/cq.c @@ -206,11 +206,12 @@ static inline int handle_responder(struct ibv_wc *wc, struct mlx5_cqe64 *cqe, if (likely(cur_rsc->type == MLX5_RSC_TYPE_QP)) { wq = &qp->rq; if (qp->qp_cap_cache & MLX5_RX_CSUM_VALID) - wc->wc_flags |= (!!(cqe->hds_ip_ext & MLX5_CQE_L4_OK) & - !!(cqe->hds_ip_ext & MLX5_CQE_L3_OK) & - (get_cqe_l3_hdr_type(cqe) == - MLX5_CQE_L3_HDR_TYPE_IPV4)) << - IBV_WC_IP_CSUM_OK_SHIFT; + wc->wc_flags |= + ((bool)(cqe->hds_ip_ext & MLX5_CQE_L4_OK) & + (bool)(cqe->hds_ip_ext & MLX5_CQE_L3_OK) & + (get_cqe_l3_hdr_type(cqe) == + MLX5_CQE_L3_HDR_TYPE_IPV4)) + << IBV_WC_IP_CSUM_OK_SHIFT; } else { wq = &(rsc_to_mrwq(cur_rsc)->rq); } @@ -1105,11 +1106,11 @@ static inline int mlx5_cq_read_wc_flags(struct ibv_cq_ex *ibcq) int wc_flags = 0; if (cq->flags & MLX5_CQ_FLAGS_RX_CSUM_VALID) - wc_flags = (!!(cq->cqe64->hds_ip_ext & MLX5_CQE_L4_OK) & - !!(cq->cqe64->hds_ip_ext & MLX5_CQE_L3_OK) & - (get_cqe_l3_hdr_type(cq->cqe64) == - MLX5_CQE_L3_HDR_TYPE_IPV4)) << - IBV_WC_IP_CSUM_OK_SHIFT; + wc_flags = ((bool)(cq->cqe64->hds_ip_ext & MLX5_CQE_L4_OK) & + (bool)(cq->cqe64->hds_ip_ext & MLX5_CQE_L3_OK) & + (get_cqe_l3_hdr_type(cq->cqe64) == + MLX5_CQE_L3_HDR_TYPE_IPV4)) + << IBV_WC_IP_CSUM_OK_SHIFT; switch (mlx5dv_get_cqe_opcode(cq->cqe64)) { case MLX5_CQE_RESP_WR_IMM: