From patchwork Mon Jul 24 20:00:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 9860361 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B3B67603F9 for ; Mon, 24 Jul 2017 20:14:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A6E5E284B2 for ; Mon, 24 Jul 2017 20:14:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9BF00285A0; Mon, 24 Jul 2017 20:14:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17AFB285A7 for ; Mon, 24 Jul 2017 20:14:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbdGXUOA (ORCPT ); Mon, 24 Jul 2017 16:14:00 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:45005 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752815AbdGXUNy (ORCPT ); Mon, 24 Jul 2017 16:13:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=References:In-Reply-To:Message-Id:Date:Subject:To:From; bh=EI+cz07CSDWeFHrXIy0cOJD4CZHKwxbx7e7xFajd5yM=; b=k8HqvwXRUH/9iTcnjStlPgczbPkpnuBqqtwtqPZF50kqsXfZf/1/7KUbck0vC4+DA35dw/vDgeOOq4Ld4IIiQtVaJdLWE9ChYFpx//s4WUQtaia4gR0Gb9yf/qT933a/UA8lKHk0GD8tbCcLi2usTYDXe0+X3ALRpq3ZpoB3/Ck=; Received: from [10.0.0.156] (helo=jggl.edm.orcorp.ca) by quartz.orcorp.ca with esmtps (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1dZjWx-0001rL-99; Mon, 24 Jul 2017 14:00:39 -0600 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org, Leon Romanovsky , Doug Ledford , Benjamin Drung , Jarod Wilson Subject: [PATCH rdma-core 17/21] srp_deamon: Using v formatters directly for pr_err Date: Mon, 24 Jul 2017 14:00:25 -0600 Message-Id: <1500926429-31822-18-git-send-email-jgunthorpe@obsidianresearch.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500926429-31822-1-git-send-email-jgunthorpe@obsidianresearch.com> References: <1500926429-31822-1-git-send-email-jgunthorpe@obsidianresearch.com> X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP No reason to format to a string buffer and then just print that string, use vsyslog and vfprintf directly instead. Signed-off-by: Jason Gunthorpe --- srp_daemon/srp_daemon.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c index f0dfe260945574..a75f3af085cbde 100644 --- a/srp_daemon/srp_daemon.c +++ b/srp_daemon/srp_daemon.c @@ -295,22 +295,17 @@ void pr_debug(const char *fmt, ...) void pr_err(const char *fmt, ...) { va_list args; - int pos; - char str[1000]; va_start(args, fmt); - pos = vsnprintf(str, sizeof(str), fmt, args); - va_end(args); - if (pos >= sizeof(str)) - str[sizeof(str) - 1] = '\0'; switch (s_log_dest) { case log_to_syslog: - syslog(LOG_DAEMON | LOG_ERR, "%s", str); + vsyslog(LOG_DAEMON | LOG_ERR, fmt, args); break; case log_to_stderr: - fprintf(stderr, "%s", str); + vfprintf(stderr, fmt, args); break; } + va_end(args); } static int check_not_equal_str(const char *dir_name, const char *attr,