From patchwork Tue Jul 25 14:29:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matan Barak X-Patchwork-Id: 9862117 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C3F3601A1 for ; Tue, 25 Jul 2017 14:30:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0CA2726E96 for ; Tue, 25 Jul 2017 14:30:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0013A28688; Tue, 25 Jul 2017 14:30:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8497326E96 for ; Tue, 25 Jul 2017 14:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbdGYO3S (ORCPT ); Tue, 25 Jul 2017 10:29:18 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:36650 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752005AbdGYO3S (ORCPT ); Tue, 25 Jul 2017 10:29:18 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from matanb@mellanox.com) with ESMTPS (AES256-SHA encrypted); 25 Jul 2017 17:29:14 +0300 Received: from gen-l-vrt-078.mtl.labs.mlnx. (gen-l-vrt-078.mtl.labs.mlnx [10.137.78.1]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v6PETEWB000630; Tue, 25 Jul 2017 17:29:14 +0300 From: Matan Barak To: Lijun Ou , "Wei Hu(Xavier)" , Doug Ledford Cc: linux-rdma@vger.kernel.org, Matan Barak Subject: [PATCH] IB/hns: Avoid compile test under non 64bit environments Date: Tue, 25 Jul 2017 17:29:06 +0300 Message-Id: <1500992946-77766-1-git-send-email-matanb@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The hns driver uses __raw_writeq which is only defined in 64BIT environments. Trying to compile the driver in a 32BIT environment results in errors. Only COMPILE_TEST when 64BIT is defined. Fixes: 7d1b6a678e0b ("IB/hns: Support compile test for hns RoCE driver") Signed-off-by: Matan Barak --- Hi Lijun and Wei, This is a small fix for the compile test patch I posted. The original patch added the support to compile the hns RoCE driver in architectures other than ARM64 to ease development. However, __raw_writeq is used in your driver and it's only available in 64bit environments. Therefore, I've added the required condition in the Kconfig. Please note that compiling the code over 64bit architectures that declare 64BIT but don't declare ARCH_DMA_ADDR_T_64BIT produces compilation warnings. I'm not aware of such architectures though. Regards, Matan drivers/infiniband/hw/hns/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig index cbe6b51..61c93bb 100644 --- a/drivers/infiniband/hw/hns/Kconfig +++ b/drivers/infiniband/hw/hns/Kconfig @@ -1,7 +1,7 @@ config INFINIBAND_HNS tristate "HNS RoCE Driver" depends on NET_VENDOR_HISILICON - depends on (ARM64 || COMPILE_TEST) && HNS && HNS_DSAF && HNS_ENET + depends on (ARM64 || (COMPILE_TEST && 64BIT)) && HNS && HNS_DSAF && HNS_ENET ---help--- This is a RoCE/RDMA driver for the Hisilicon RoCE engine. The engine is used in Hisilicon Hi1610 and more further ICT SoC.