From patchwork Tue Sep 5 04:16:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 9937773 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9415D600CB for ; Tue, 5 Sep 2017 04:18:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 826F128842 for ; Tue, 5 Sep 2017 04:18:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 771BD28871; Tue, 5 Sep 2017 04:18:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ED26128842 for ; Tue, 5 Sep 2017 04:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750808AbdIEERk (ORCPT ); Tue, 5 Sep 2017 00:17:40 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:40873 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbdIEERk (ORCPT ); Tue, 5 Sep 2017 00:17:40 -0400 X-IronPort-AV: E=Sophos;i="5.41,478,1498492800"; d="scan'208";a="48166117" Received: from mail-sn1nam02lp0021.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([216.32.180.21]) by ob1.hgst.iphmx.com with ESMTP; 05 Sep 2017 12:16:53 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=paUwNVruW5oiJmo4eYQeHX+xIrmKfVOTdfoY2oArnH8=; b=cnuOwKuwBy+8lh0PLESGbP0kBWGv3eQSWZivsUaNrh12vu2x43aJywlzOngMVEEbdCllPMKxc5rgzLcl8DO8yOe/AncscO6TB5LhAposeIOQ2/qTIhSLiIiMlhe2Yk6bB8Y5b+fMOgNzjkJnsGq/YKSkrQR9tzTWaeYMIQds/aY= Received: from CY1PR0401MB1536.namprd04.prod.outlook.com (10.163.19.154) by CY1PR0401MB1179.namprd04.prod.outlook.com (10.160.164.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Tue, 5 Sep 2017 04:16:51 +0000 Received: from CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) by CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) with mapi id 15.20.0013.018; Tue, 5 Sep 2017 04:16:51 +0000 From: Bart Van Assche To: "yuval.shaia@oracle.com" , "leon@kernel.org" CC: "faisal.latif@intel.com" , "linux-rdma@vger.kernel.org" , "Ram.Amrani@cavium.com" , "dennis.dalessandro@intel.com" , "swise@chelsio.com" , "sean.hefty@intel.com" , "shiraz.saleem@intel.com" , "mike.marciniszyn@intel.com" , "Ariel.Elior@cavium.com" , "hal.rosenstock@gmail.com" , "dledford@redhat.com" Subject: Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs Thread-Topic: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs Thread-Index: AQHTJZK2TfkXK3mVHka8hgFkMY1SlKKlrhkAgAACWQA= Date: Tue, 5 Sep 2017 04:16:51 +0000 Message-ID: <1504585010.3360.10.camel@wdc.com> References: <20170904152848.3471-1-yuval.shaia@oracle.com> <20170905040826.GB1070@mtr-leonro.local> In-Reply-To: <20170905040826.GB1070@mtr-leonro.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [73.223.62.206] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1PR0401MB1179; 20:bGt4/pdSdbO7BxxRki+iUsq/bX/3OJRHMgMlyb5Z8N9jAHwodieOG9d30HFNK5dVqPGDVXhVoFrPeWtI55lJNimbL6XoXHd+PVRo8U6FUp2UcNd6fqd8wZYQJ06CEE9wqsxKZmWTg7Dez0WxEK5Lqe+4Vcg5ct58x/kb+Hr4DUs= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 85202081-f69b-44a7-8d82-08d4f414ef44 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR0401MB1179; x-ms-traffictypediagnostic: CY1PR0401MB1179: wdcipoutbound: EOP-TRUE x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123558100)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR0401MB1179; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR0401MB1179; x-forefront-prvs: 0421BF7135 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39860400002)(377424004)(199003)(57704003)(189002)(24454002)(2900100001)(68736007)(86362001)(478600001)(189998001)(39060400002)(6246003)(106356001)(6512007)(99286003)(14454004)(72206003)(105586002)(36756003)(53936002)(25786009)(3280700002)(54906002)(2906002)(3660700001)(101416001)(103116003)(81156014)(33646002)(4326008)(8936002)(76176999)(2501003)(305945005)(50986999)(5660300001)(6506006)(81166006)(53546010)(102836003)(7416002)(66066001)(2950100002)(3846002)(6116002)(229853002)(97736004)(54356999)(6436002)(8676002)(6486002)(77096006)(7736002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0401MB1179; H:CY1PR0401MB1536.namprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: wdc.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <0CE7B51C8C32BB4F93CC10F82E677755@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2017 04:16:51.5915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1179 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote: > Why do we need to be dependent on CONFIG_BROKEN? > Is it still valid for IB stack? Hello Leon, As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN" part was introduced through the following patch: From a2b2f45be7e9138bde7fcba3b8e9257fea04d087 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Tue, 23 Aug 2005 22:45:41 +0100 Subject: [PATCH] [PATCH] Kconfig fix (infiniband and PCI) infiniband uses PCI helpers all over the place (including the core parts) and won't build without PCI. Signed-off-by: Al Viro Signed-off-by: Linus Torvalds --- drivers/infiniband/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig index 79c8e2dd9c33..32cdfb30e9b4 100644 --- a/drivers/infiniband/Kconfig +++ b/drivers/infiniband/Kconfig @@ -1,6 +1,7 @@ menu "InfiniBand support" config INFINIBAND + depends on PCI || BROKEN tristate "InfiniBand support" ---help--- Core support for InfiniBand (IB). Make sure to also select