From patchwork Wed Sep 20 23:27:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 9962967 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6437160208 for ; Wed, 20 Sep 2017 23:38:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 568C729255 for ; Wed, 20 Sep 2017 23:38:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B6F829267; Wed, 20 Sep 2017 23:38:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C7EDC29255 for ; Wed, 20 Sep 2017 23:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752098AbdITXh6 (ORCPT ); Wed, 20 Sep 2017 19:37:58 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:52459 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751972AbdITXh4 (ORCPT ); Wed, 20 Sep 2017 19:37:56 -0400 Received: by mail-pf0-f169.google.com with SMTP id p87so2299393pfj.9 for ; Wed, 20 Sep 2017 16:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3qhEfFOCeutkIILlwz+0b9w4A4GszJDHnGMyJTMqvHM=; b=bS6a5uButimZc0GEVmgl9dTYpgBuHymfy2IHFaaRLnFftabQX5u80usQYbPT003TDu JAODS0KypghP31SJ8vjn6OdhswO8yi+4K5SAlflscl6ZzGVWaacXA15T1gmMTY3LuiHT DPCojxXJGG+Nrgq44IAHKHpZFKrVuUoPMxHpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3qhEfFOCeutkIILlwz+0b9w4A4GszJDHnGMyJTMqvHM=; b=i5JnPAhfD1FYbS/0kHQ+HwVhu9CWHFTFOcLJ6tmTT1MO4FxSvE5nLYFx0H/UIAS+B0 eJ1oNK2WAwv+gAnopWII93EJDzgnReXZyVAwCXrMKf5p46leK8nGd4N/e12p3hvcJ4zy gg4n+mobK6cFdDVWvq0+zGlnjdvsoNjWYo3ASCu8EzCBy7XzL7/6fhKVkVQ+6v/KCNlL RConBd4Ndk59u0qrcBf0puYD9iuJWivZ7Kgtw4HNUKS4Kvl8WSKk9fwozzjw3KAvHv8l 5oDbN+WYpAyuRtyDhGC5JNCSRTVyG8DuvmeT88dkyzyqZycg4qZtb2VRhB2cGLDvpoDH VeXw== X-Gm-Message-State: AHPjjUgyD/y0Gun/g475M/2QlZR9CQr66/JBzJiqk0MtKAwyhA4fxz6b 7UCDWGHVjwpPAWg54io9vHk0uA== X-Google-Smtp-Source: AOwi7QBYup518lXoy6ah3kz0onbkTdckESS6UC6yZvUTP+cH3I3znaaCX+Mw2N8Hf2DponuzuAY1Sg== X-Received: by 10.84.253.131 with SMTP id a3mr3706920plm.244.1505950676299; Wed, 20 Sep 2017 16:37:56 -0700 (PDT) Received: from www.outflux.net (173-164-112-133-Oregon.hfc.comcastbusiness.net. [173.164.112.133]) by smtp.gmail.com with ESMTPSA id i3sm80992pgs.23.2017.09.20.16.37.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Sep 2017 16:37:54 -0700 (PDT) From: Kees Cook To: Thomas Gleixner Cc: Kees Cook , Dennis Dalessandro , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 28/31] infiniband/rdmavt: Remove redundant timer initialization Date: Wed, 20 Sep 2017 16:27:52 -0700 Message-Id: <1505950075-50223-29-git-send-email-keescook@chromium.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1505950075-50223-1-git-send-email-keescook@chromium.org> References: <1505950075-50223-1-git-send-email-keescook@chromium.org> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP setup_timer() is already called before the open-coded init_timer() and .data assignment. Remove it. Cc: Dennis Dalessandro Cc: Doug Ledford Cc: Sean Hefty Cc: Hal Rosenstock Cc: linux-rdma@vger.kernel.org Signed-off-by: Kees Cook --- drivers/infiniband/sw/rdmavt/qp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/sw/rdmavt/qp.c b/drivers/infiniband/sw/rdmavt/qp.c index 22df09ae809e..3116879677e0 100644 --- a/drivers/infiniband/sw/rdmavt/qp.c +++ b/drivers/infiniband/sw/rdmavt/qp.c @@ -894,8 +894,6 @@ struct ib_qp *rvt_create_qp(struct ib_pd *ibpd, atomic_set(&qp->refcount, 0); atomic_set(&qp->local_ops_pending, 0); init_waitqueue_head(&qp->wait); - init_timer(&qp->s_timer); - qp->s_timer.data = (unsigned long)qp; INIT_LIST_HEAD(&qp->rspwait); qp->state = IB_QPS_RESET; qp->s_wq = swq;