From patchwork Mon Nov 6 16:07:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 10043809 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C836F60247 for ; Mon, 6 Nov 2017 16:09:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCCB129EF7 for ; Mon, 6 Nov 2017 16:09:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B169A29F07; Mon, 6 Nov 2017 16:09:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 59D1429EF7 for ; Mon, 6 Nov 2017 16:09:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754100AbdKFQJD (ORCPT ); Mon, 6 Nov 2017 11:09:03 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:47461 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753842AbdKFQJB (ORCPT ); Mon, 6 Nov 2017 11:09:01 -0500 Received: by mail-qk0-f193.google.com with SMTP id m189so11548085qke.4 for ; Mon, 06 Nov 2017 08:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=60dD448lR0Xmiywk3l21wEQiWHHWpfEGn8fhjIceg9s=; b=IOsCND2jdpsoTuH69+fFTwkurG2XGupb1VXfZY2IXIxrSC7gRXJkqbm/+82jGoe4hN 8jT3easCRREe9h4t5isbelze/St9K5N72aBCj1pfJik0Z6BfynLBVwvbmbUZkKWTCMmj jyewMtHFObRCGyHB9lkpVD5OMEjjsvrJfDHPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=60dD448lR0Xmiywk3l21wEQiWHHWpfEGn8fhjIceg9s=; b=fPLQpUAheDSZJs/syEK3z5/UP8xW+8IiZNK3kJ2uXA9r4RWJZ2uphz6Drqodz25wwS tGB/Up6i3Ieg0/aMOt0tp0ThnnaH6vLjmTIsw0K0npVB9GetdD3amjK7j0Km1VyjvOqo 3V8UDu/OiS3kb3zlpmjiDlKLbN3qwLj+pASqm/W6nGzvYMG4GmpxSPVdUZ7tEdUowdzW 7hiylaUA8UjpvvVhogmgfOpnQuQMcJV6Q4Z136w0y9YkgzDDXTwWrKGKCjhiE6FWpYqv ZnQbxXOjDFqCnARDDoG5bGNbQ9hiwUB1pmKjhWfqKBmBL6S0FX4YZSr8ogTi8uPe7wNw F/DQ== X-Gm-Message-State: AJaThX7scYM3URp4K3pP9sbA/Y0lQ4k97JeLM5VlTTVhK5CkPXn2TbKQ DKC6Xz1qaEJhMMuQoIspoMyJ+w== X-Google-Smtp-Source: ABhQp+R56TGBMioi6hVoAOy1Oi77Mxe3DhGDj75GUyrxp/2/omLoTwFDMdPL+Tmo7F1f0PAoR90wGA== X-Received: by 10.55.40.230 with SMTP id o99mr6414746qko.81.1509984540721; Mon, 06 Nov 2017 08:09:00 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net ([192.19.239.250]) by smtp.gmail.com with ESMTPSA id c64sm8237717qkd.67.2017.11.06.08.08.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Nov 2017 08:09:00 -0800 (PST) From: Selvin Xavier To: dledford@redhat.com Cc: linux-rdma@vger.kernel.org, Selvin Xavier Subject: [PATCH 3/4] RDMA/bnxt_re: Flush CQ notification Work Queue before destroying QP Date: Mon, 6 Nov 2017 08:07:31 -0800 Message-Id: <1509984452-18336-4-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1509984452-18336-1-git-send-email-selvin.xavier@broadcom.com> References: <1509984452-18336-1-git-send-email-selvin.xavier@broadcom.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Destroy_qp shall wait for any outstanding CQ notification to be flushed out before proceeding with QP destroy. Flushing the WQ before destroying the QP. Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 + drivers/infiniband/hw/bnxt_re/qplib_fp.c | 7 +++++++ drivers/infiniband/hw/bnxt_re/qplib_fp.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index ebcdfb4..96ec797 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -788,6 +788,7 @@ int bnxt_re_destroy_qp(struct ib_qp *ib_qp) struct bnxt_re_dev *rdev = qp->rdev; int rc; + bnxt_qplib_flush_cqn_wq(&qp->qplib_qp); bnxt_qplib_del_flush_qp(&qp->qplib_qp); rc = bnxt_qplib_destroy_qp(&rdev->qplib_res, &qp->qplib_qp); if (rc) { diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index 805a612..c0f8133 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -2537,3 +2537,10 @@ void bnxt_qplib_req_notify_cq(struct bnxt_qplib_cq *cq, u32 arm_type) atomic_set(&cq->arm_state, 1); spin_unlock_irqrestore(&cq->hwq.lock, flags); } + +void bnxt_qplib_flush_cqn_wq(struct bnxt_qplib_qp *qp) +{ + flush_workqueue(qp->scq->nq->cqn_wq); + if (qp->scq != qp->rcq) + flush_workqueue(qp->rcq->nq->cqn_wq); +} diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.h b/drivers/infiniband/hw/bnxt_re/qplib_fp.h index 8ead70c..c582d4e 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.h +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.h @@ -478,4 +478,5 @@ void bnxt_qplib_release_cq_locks(struct bnxt_qplib_qp *qp, int bnxt_qplib_process_flush_list(struct bnxt_qplib_cq *cq, struct bnxt_qplib_cqe *cqe, int num_cqes); +void bnxt_qplib_flush_cqn_wq(struct bnxt_qplib_qp *qp); #endif /* __BNXT_QPLIB_FP_H__ */