From patchwork Fri Jan 12 21:11:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10161685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7783160327 for ; Fri, 12 Jan 2018 21:11:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6A32F28A78 for ; Fri, 12 Jan 2018 21:11:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5F29E28ABB; Fri, 12 Jan 2018 21:11:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC1C628ABC for ; Fri, 12 Jan 2018 21:11:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965119AbeALVLQ (ORCPT ); Fri, 12 Jan 2018 16:11:16 -0500 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:6573 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964844AbeALVLP (ORCPT ); Fri, 12 Jan 2018 16:11:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1515791475; x=1547327475; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ZNqK9G79ZNpIhNYvdYzcrf2ZYmhH+bZsyh/jqX7kQUk=; b=KpckwiY5+/G1oVmEOfBYqEGz5Kd9QQnPR5pm343dfN+NsiObjwVkEfTa U5gEP7PhlW0tnfOrnabdoLFEqfNG6GdOhN96YLLzzVtxJ8BjLXOyPiULd 5jBXsC9ovyxlL3cMXNUx9g31FOQEuqEJBgBwYXaPYw+twMDNSxFpx2oEC BnxtTED5V8sMuKiIIfHKsiHbAtm8E96sIb4nz4Pu2ZvRep6/d81+hxryJ wTeu8a+AlrLZ+mvF7Qs3sPBv5AzphFDyb+dsFX688C/vUPzHm1yReh3wC RqfNJ5VIsFwqxcuDXmQgGkbFe5l0JduZMySRHYgftAAx9D6Mtme8G/zp0 w==; X-IronPort-AV: E=Sophos;i="5.46,350,1511798400"; d="scan'208";a="171410599" Received: from mail-co1nam03lp0023.outbound.protection.outlook.com (HELO NAM03-CO1-obe.outbound.protection.outlook.com) ([216.32.181.23]) by ob1.hgst.iphmx.com with ESMTP; 13 Jan 2018 05:11:15 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZNqK9G79ZNpIhNYvdYzcrf2ZYmhH+bZsyh/jqX7kQUk=; b=lL5g6F/lKbVXMtHin+lQXBhlxaYmU1dpE0jaGvB3/YD55HMES9O/44CuRYKvCBjMPwpT3/tgbhaSlPZj+JXeS2Rw6eTACHaYoQit4obwELlRUcmashgNWCQsU4hkEUPqNl6KcFhb0vTbtB25os1zqqzogNxR6CRGHivLm7x6o2A= Received: from CY1PR0401MB1536.namprd04.prod.outlook.com (10.163.19.154) by CY1PR0401MB1535.namprd04.prod.outlook.com (10.163.19.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Fri, 12 Jan 2018 21:11:14 +0000 Received: from CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) by CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) with mapi id 15.20.0386.008; Fri, 12 Jan 2018 21:11:13 +0000 From: Bart Van Assche To: "loberman@redhat.com" CC: "linux-rdma@vger.kernel.org" , "ddutile@redhat.com" Subject: Re: Kernel v4.16 / v4.17 SRP and SRPT patches Thread-Topic: Kernel v4.16 / v4.17 SRP and SRPT patches Thread-Index: AQHTiYuaYr628DokJEaPU713hZtHWqNsBsYAgAAbwwCAAPv3gIAAT48AgAADzICAAAU/AIAABHkAgAAEU4CAABbugIAABSwAgAABD4CAAQivgIAAgPWAgAAI3wCAAAUXgIABi/8A Date: Fri, 12 Jan 2018 21:11:13 +0000 Message-ID: <1515791472.2396.57.camel@wdc.com> References: <1515531652.26021.1.camel@redhat.com> <1515537614.26021.3.camel@redhat.com> <1515591723.26021.6.camel@redhat.com> <20180110182648.GI4518@ziepe.ca> <1515609623.2745.20.camel@wdc.com> <1515610750.10153.1.camel@redhat.com> <20180110191510.GK4518@ziepe.ca> <1515612639.10153.3.camel@redhat.com> <20180110205243.GP4776@mellanox.com> <1515618674.10153.6.camel@redhat.com> <20180110211501.GS4776@mellanox.com> <1515675741.21421.1.camel@redhat.com> <1515703435.21421.9.camel@redhat.com> <1515705340.2752.60.camel@wdc.com> <1515706433.21421.11.camel@redhat.com> In-Reply-To: <1515706433.21421.11.camel@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1PR0401MB1535; 7:VAK2n4fIt79erX74c8rbBAyKbGPvbmkVHNRmumBXhM4FgvzeX1o7SDX/HeAe0OdYkd624AZeyvWIR3W7Z8Wi/CAcBRdzKerBTGOJU+EXLk6LnB9ooPqOjqQS01iz1FrcjndyLK0HwBlpooY7KK50bi3tv0S2v0tlhiI2y9zKP4fRwgaZPWhDEkzAC2zLD/4GKJn+rKFR0w3WTYyGNPM+crjC77qhtjflHXa9297clJ2VSC2XIPylmzx9gawoJvRj; 20:eGvssB49K8pXx3VEqGd57eVp5LhlY+lU6/lEEtnN2ypBtx7rIQxusg9FIvsklR2Z1JSTC0TrBpDREbJe/O1N13KW8htsqZTB+oO5ytvov5TgmG5Tfa8S63yUWDUzoCChPb2/IJPZzIvdhYNOG2yGF3k1468Y78kfIzWkQeGTilg= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 600ac463-f471-4373-c0b0-08d55a01034d x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:CY1PR0401MB1535; x-ms-traffictypediagnostic: CY1PR0401MB1535: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(3231023)(944501075)(10201501046)(6055026)(6041268)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY1PR0401MB1535; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR0401MB1535; x-forefront-prvs: 0550778858 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(346002)(366004)(39860400002)(396003)(376002)(377424004)(189003)(199004)(24454002)(6506007)(3660700001)(3280700002)(316002)(229853002)(105586002)(6436002)(4326008)(77096006)(54906003)(5640700003)(6486002)(25786009)(2950100002)(59450400001)(106356001)(2351001)(3846002)(6916009)(1730700003)(81166006)(97736004)(86362001)(6116002)(8676002)(103116003)(81156014)(2900100001)(5660300001)(8936002)(102836004)(2501003)(68736007)(76176011)(305945005)(7736002)(2906002)(36756003)(93886005)(72206003)(66066001)(14454004)(478600001)(6512007)(53936002)(99286004)(6246003); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0401MB1535; H:CY1PR0401MB1536.namprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-microsoft-antispam-message-info: YRS7y2jHBzojBXhEJQO+y77Snyh4DUsRrbbLellcBhca4YBA55pubpETJDCcG3DloNA67MUTTANfuVpWDCdFbA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 600ac463-f471-4373-c0b0-08d55a01034d X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2018 21:11:13.7500 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 2018-01-11 at 16:33 -0500, Laurence Oberman wrote: > I just rebooted the server into 4.13 and its fine again and found all > the targets with the same kernel on the client. > > So its specific to your new tree with srpt > > I will reboot again and re-load LIO and show you but here is my ACL > list that has been this way for some time. > > > o- srpt > ....................................................................... > ...................................... [Targets: 2] > | o- ib.fe800000000000007cfe900300726e4e > ....................................................................... > .... [no-gen-acls] > | | o- acls > ....................................................................... > ..................................... [ACLs: 8] > | | | o- ib.4e6e72000390fe7c7cfe900300726ed2 > > [ ... ] Hello Laurence, Although I'm not sure I think I found the root cause of this failure. The following patch should fix the failure: I wrote "should" because targetcli is not installed on my test setup and because I have not yet verified this change with targetcli. If you have the time to verify this change that would be great. If not then I will install targetcli myself and verify this change. Thanks, Bart. Reviewed-by: Laurence Oberman Tested-by: Laurence Oberman diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 96142110a155..5297963c834d 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2083,7 +2083,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev, struct ib_cm_rep_param ib_cm; } *rep_param = NULL; struct srpt_rdma_ch *ch; - char i_port_id[24]; + char i_port_id[36]; u32 it_iu_len; int i, ret; diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.h b/drivers/infiniband/ulp/srpt/ib_srpt.h index bf4525b24d98..02883f8e9c71 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.h +++ b/drivers/infiniband/ulp/srpt/ib_srpt.h @@ -308,7 +308,7 @@ struct srpt_rdma_ch { bool using_rdma_cm; bool processing_wait_list; struct se_session *sess; - u8 sess_name[36]; + u8 sess_name[24]; struct work_struct release_work; };