From patchwork Tue Jan 23 22:30:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10181105 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BBDE26019D for ; Tue, 23 Jan 2018 22:30:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB18C28816 for ; Tue, 23 Jan 2018 22:30:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A945B28823; Tue, 23 Jan 2018 22:30:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 21A2228829 for ; Tue, 23 Jan 2018 22:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932258AbeAWWaL (ORCPT ); Tue, 23 Jan 2018 17:30:11 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:62158 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932150AbeAWWaL (ORCPT ); Tue, 23 Jan 2018 17:30:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1516746611; x=1548282611; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=TWTDO1R5rqroQO8JMlQEkWAhkpQTFSsL1QajGN8xuJM=; b=D/ynJ10fkyCxtBKD2vicaAaldNbSFENcCh6rFAknEXUqxeKfm7quZ6UI +0xS+XPyWArs6EqwrjKb0f3xv22DAdQQx8kcrzjqEpvZEYd8AtQ4KxD3l ODgCcI+J8daK1ODoy5aEvEjCYSGlcHnU7YeKxTXWW+0r5q0yaF3TYMSQS pLBPjZ+pOLXevOd1JfYcnyQP5CIunaaKD7FcJRQ30XYxtq1Si4VJza7Io 14lOFDHV24tL8LZr7/wKG7ShuF+T0hr0iwcieCKDlNsZIau/DTnuFhIs1 +d9dqk8myF6yjqMPuzO/shxBk5m/U5wMzeVVMWbe4lHUiCELtmP/u2rrT w==; X-IronPort-AV: E=Sophos;i="5.46,403,1511798400"; d="scan'208";a="69636437" Received: from mail-sn1nam02lp0015.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([216.32.180.15]) by ob1.hgst.iphmx.com with ESMTP; 24 Jan 2018 06:30:10 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=TWTDO1R5rqroQO8JMlQEkWAhkpQTFSsL1QajGN8xuJM=; b=eaVvYRq1jBZS6+ij3qSJt9/aGGPcAX4rqIfzAow+Eykoe9azQl5P7/9zje3Smkj9OIc9gIsxNSRdjmTDgKYk8o8kx7PSmcLksbD0erZeE+Crv+mZfPaKbHzIJFLReA0idsbJi9xydJe9OQa/uRQgbJfyj1xIHR5Z4179azUbaOE= Received: from CY1PR0401MB1536.namprd04.prod.outlook.com (10.163.19.154) by CY1PR0401MB0970.namprd04.prod.outlook.com (10.160.160.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Tue, 23 Jan 2018 22:30:08 +0000 Received: from CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) by CY1PR0401MB1536.namprd04.prod.outlook.com ([10.163.19.154]) with mapi id 15.20.0428.019; Tue, 23 Jan 2018 22:30:08 +0000 From: Bart Van Assche To: "leonro@mellanox.com" CC: "jgg@mellanox.com" , "paulmck@linux.vnet.ibm.com" , "linux-rdma@vger.kernel.org" , "dledford@redhat.com" Subject: Re: [PATCH rdma-next] RDMA/srpt: Fix RCU debug build error Thread-Topic: [PATCH rdma-next] RDMA/srpt: Fix RCU debug build error Thread-Index: AQHTlEBZxBEGPLiQ30OTMTT085oLXqOBkz0AgAAL5QCAADBpAIAAO2WA Date: Tue, 23 Jan 2018 22:30:08 +0000 Message-ID: <1516746607.3339.47.camel@wdc.com> References: <20180123115013.12213-1-leonro@mellanox.com> <20180123152142.GB30619@mellanox.com> <1516723456.3339.3.camel@wdc.com> <20180123185732.GA1393@mtr-leonro.local> In-Reply-To: <20180123185732.GA1393@mtr-leonro.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.172] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1PR0401MB0970; 7:U45OARt3ZVwC+uwm0SPu2yYWV8Uj0NEA3PrTZGT4BVISjjGkCZDwqkLXBg/XTjXpxcDQv+rJKor4lZXOjUKOEJa7lXrI+rJkWFHFxhAoMwagcyIjtQse0I76GwmdggHumyg039/MqU4D0CHdo8RMyGP5cs4Dsh/WolouC1ISaEg6Td2LW9je1536KzyehQ6TI0RMqd6eM4luqzx/Zn6jJoVVRPLE5HTZvGoBMacTz52AMKecoGwpa+yCvXMMkmzq; 20:JisFRax3bmrML/iZe0SQymzDzgPv8u0c6xFxTwBFh//vi0dwqP/slhgoBsLWVIlusCarGWzEQ3reH3l6WTdgplLKl27BNcl1i44nbt+TMa4vOuNLEL5IGAXTRZzSl4WztdVsx2eQQXio9GqcHG/3opzNkoknlnHJPGHd8agAzkQ= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 7280961b-77ff-41b3-8fbb-08d562b0dbf7 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:CY1PR0401MB0970; x-ms-traffictypediagnostic: CY1PR0401MB0970: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231023)(2400081)(944501161)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:CY1PR0401MB0970; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0401MB0970; x-forefront-prvs: 05610E64EE x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(376002)(39860400002)(346002)(396003)(39380400002)(377424004)(199004)(189003)(66066001)(3280700002)(2950100002)(2351001)(106356001)(54906003)(86362001)(8676002)(81166006)(105586002)(93886005)(36756003)(6436002)(3660700001)(81156014)(6512007)(305945005)(7736002)(53936002)(5640700003)(478600001)(6486002)(1730700003)(99286004)(102836004)(8936002)(2501003)(68736007)(229853002)(76176011)(6506007)(2906002)(5660300001)(25786009)(6116002)(316002)(6916009)(14454004)(72206003)(3846002)(4326008)(103116003)(2900100001)(6246003)(26005)(97736004)(77096007); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0401MB0970; H:CY1PR0401MB1536.namprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-microsoft-antispam-message-info: w9BjvM8uJSkkOhNjwOvDh+u9KLYu0fVgMlaedk9oRZ4NVE1oeeM8Mxf8zT+tIBBDtmTKeCt9jm90SOWtO/jh/Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: <97DF7CA72BF45B4C94BBBD552C862094@namprd04.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7280961b-77ff-41b3-8fbb-08d562b0dbf7 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2018 22:30:08.5743 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB0970 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2018-01-23 at 20:57 +0200, Leon Romanovsky wrote: > So how are we going to solve that rdma/for-next doesn't compile? How about the following? [PATCH] IB/srpt: Fix CONFIG_DEBUG_OBJECTS_RCU_HEAD=y build Avoid that the kernel build fails as follows if RCU debugging is enabled: ERROR: "init_rcu_head" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined! diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 5ccc75c389e2..a78a79791950 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -1977,7 +1977,6 @@ static struct srpt_nexus *srpt_get_nexus(struct srpt_port *sport, nexus = ERR_PTR(-ENOMEM); break; } - init_rcu_head(&tmp_nexus->rcu); INIT_LIST_HEAD(&tmp_nexus->ch_list); memcpy(tmp_nexus->i_port_id, i_port_id, 16); memcpy(tmp_nexus->t_port_id, t_port_id, 16); @@ -2147,7 +2146,6 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev, goto reject; } - init_rcu_head(&ch->rcu); kref_init(&ch->kref); ch->pkey = be16_to_cpu(pkey); ch->nexus = nexus;