From patchwork Wed Mar 14 12:49:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kalderon, Michal" X-Patchwork-Id: 10282081 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4404C601E9 for ; Wed, 14 Mar 2018 12:50:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 35D05288D1 for ; Wed, 14 Mar 2018 12:50:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2A506288F6; Wed, 14 Mar 2018 12:50:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 86AD6288D1 for ; Wed, 14 Mar 2018 12:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbeCNMuI (ORCPT ); Wed, 14 Mar 2018 08:50:08 -0400 Received: from mail-sn1nam02on0072.outbound.protection.outlook.com ([104.47.36.72]:18824 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751776AbeCNMuH (ORCPT ); Wed, 14 Mar 2018 08:50:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bqve4QOiTI5zAPQPnqmSK3t+6dViB6CuVt/dixFSXP4=; b=ofemiMte+pqjDziHiOui/PT7q495fCHvAmRjH/+DssaONG63UPOnOWoxhJ34Okh4YFmmv+LdVFh1qCqTwz3e3MrKjJhv+ZDEo2hbSYafQXKjwp82cKC9DsAv0Z5wAa5xOGoDZZG8+QV1OcJfwDTOaBZW3SvbRypnPMyWpMisSB0= Received: from BYAPR07CA0017.namprd07.prod.outlook.com (2603:10b6:a02:bc::30) by BLUPR0701MB2082.namprd07.prod.outlook.com (2a01:111:e400:52f4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.567.14; Wed, 14 Mar 2018 12:50:05 +0000 Received: from BN1AFFO11FD005.protection.gbl (2a01:111:f400:7c10::188) by BYAPR07CA0017.outlook.office365.com (2603:10b6:a02:bc::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.588.14 via Frontend Transport; Wed, 14 Mar 2018 12:50:04 +0000 Authentication-Results: spf=fail (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=cavium.com; Received-SPF: Fail (protection.outlook.com: domain of cavium.com does not designate 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD005.mail.protection.outlook.com (10.58.52.65) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.527.18 via Frontend Transport; Wed, 14 Mar 2018 12:50:03 +0000 Received: from lb-tlvb-michal.il.qlogic.com.com (10.185.6.89) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 14 Mar 2018 05:50:01 -0700 From: Michal Kalderon To: , CC: , , , , Michal Kalderon , Ariel Elior Subject: [PATCH net 1/2] qed: Fix MPA unalign flow in case header is split across two packets. Date: Wed, 14 Mar 2018 14:49:27 +0200 Message-ID: <1521031768-19131-2-git-send-email-Michal.Kalderon@cavium.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1521031768-19131-1-git-send-email-Michal.Kalderon@cavium.com> References: <1521031768-19131-1-git-send-email-Michal.Kalderon@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(396003)(346002)(376002)(2980300002)(1110001)(1109001)(339900001)(199004)(189003)(47776003)(356003)(51416003)(478600001)(85426001)(86362001)(48376002)(50466002)(2950100002)(6666003)(186003)(77096007)(305945005)(2906002)(110136005)(26005)(59450400001)(69596002)(81166006)(50226002)(81156014)(36756003)(16586007)(72206003)(8676002)(5660300001)(106466001)(336012)(4326008)(107886003)(8936002)(54906003)(316002)(105606002)(104016004)(76176011); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB2082; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD005; 1:rbTNEoX21KV0oJqZmV0dozc4Kx1w3oQ6lSmOFri4Ygn/b+MLfFqhE0hDLaBO9e/l73ouyJu8LeejmYaRoqwHlmAeY2XPe4MA+PYK3bouEQxOXmPCoKxnztIFf4LSBy8F X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c92474ed-13cf-4835-47f3-08d589aa1b79 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:BLUPR0701MB2082; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2082; 3:wwcFqzKzEUSo1U+sIDcKsrNea40LCCxUtcmOPzdqnBsx57U/+0oDEq5QW+sSFACPG7PoOgEGp1Fo/AFRnaDwLK7Nb7lovJ4qL8PGxBe5dso5KCXfv0GrwXiEqvt0VBdRuyfVXKCNKrj3k5qk4Wh+ALXcYSgjIRqPwvnLYbUJu/Y/F4Y/4bm4XG65D2yyISlIU3s0tIMwmFGUP14oA7zKmIVetCE0CEp1sxfjSA71R/4pQyyL9fP7hLFD1/O3zMmBbMwBigWRJQFl+GY6PC8VxeNDXRfdMSCTisj2q7QGa9eMDFWQyYlgXvxzYBCMflYlNtYy8nMwgibuJRzasJbkA89oKiOsPJUUa0ZfT5vOvNI=; 25:aDsHZ/cXh0y7kRP/yg4nrxYxG04LBvi5/jvxZHwjlQ1bYnhQaObru4AGokBpxPd8dS22pMpDPKkNtSOddqVjuPt0u+/G1Zc4Kaa8EPZEwvGz0wD3OHV59SbeAZjJdkkgsxKRU1Ls4IGKH6F9cy1nQFYipOiS9QetrgaQvN2eyBYoHIc9wjSv87fkW237ovhVvWXkcieVWBFdlRCUP9f+MOGC33tJPna5dhbdbzv49Qo4p3r6UOLxW62ZmbLYrinB9Rt5YVHlQlTcMt7yr2MvqT0uGvApMksuEW063gbr3bN13qXxoQpuBkerwDmF5NEy4bYEDXzhv5rXCgITghG1lxBTsYhpV7EtlSEPxY+89e0= X-MS-TrafficTypeDiagnostic: BLUPR0701MB2082: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2082; 31:Fvlr9FohuNutcT9UpDSxYcJR324LySb7KW2of54xfwdXlLMI/K0s/efD9FkMCEy2X0BIEnGg+hCK8uinwBd1kU40FGT90prO3UjbKUXi1PKf+wsdUNb7+ZA/CDclI6IxKiwdVZYOHL2yauVUEGPbwhpz5XVhhyuliGTxL7iCc716GQODm2Ky3fO7l3iJuewzBpg146dC9MfNjdq3z3JymVz/SOl8wIoZWMCXZa3rGRI=; 20:YlwAbSzgAgAUOUGUGj7VeTpVOmzNQ8UNNMkJrriqU47bjEgTgjc5pvXv0zNL15PcpiBMnIqKPBDVWyMIc0YT2yvdxonxiVpfSeFgZwVq02L08RmUZUtarLuqzIwFXD6vR00XwabxU2orEtQAB2Qqvjrigh0e4jHTObxnzyMwTWcpNJv/jOgt4amnnnQnBTmb9ao4BXEWzqzLebnsuFycplznr4S2HQcTFZmKOcJBun3gVbn+20OyLSLR4W5djvcjj9Gdj6WlANvaHOExhUCEyByaDGVtRuGykKCfJ5Rx1tcqRv+RW7AhHe4gJ669wolMMnrzc6jCliApOEl5Po231LBkLG79/7247761rfMDmnxpoopspqyJs7z8OYyKjf/cRUTSzcqcc/dbVnAJoanVS1lVez4sZvhkmfdfTEJ0Jgl9YfCALKfBgMvzQH0Jv+AyTFIQBaSTLttPzBVTDnqUi/5TBpmNzVO8nizeEKCgSa9693OUkn9syHoXtDNsekBG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(10201501046)(3002001)(93006095)(93001095)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:BLUPR0701MB2082; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB2082; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2082; 4:6poqISVkm1KCP7kf3ObYjmlsJ5TQRnSfEUxIfYESKu3gU+QNOg4VdePqiEdx/lo0ZARjZXJRYcSo+6WSPfJWVWi0jg5sRxwfWmdysmCQcjmoC9XwoePfXQcwB9QPpMgPsXfb+aozkE4dCHVX0lms2TGbffqyXmmM1dj/YFUwB2ryEnwbn1BoIZ7YSBd7aN+Zl87iM15N6hy/YpifWXYoc9kFUprkkeE7RW9Tyz6CHEDfyoEVcuKe6nVJddNz3hED0+0PRQLiKKCJP2jhTMithQ== X-Forefront-PRVS: 0611A21987 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB2082; 23:IwiaCFDyVw/L8qbusMGDRu/4jPaUJdeLenKJyVV?= =?us-ascii?Q?VagoAc8xmhIBTEqsrOxFjz9oTdxsi+vcWFvA3P10BN7O6NWPxrSlCp9hgS1q?= =?us-ascii?Q?N6rItg5Gium9n4CpEcxsHvVJtFSv77WzsMsPMIwh4A32NdadngpeWJjDQoP0?= =?us-ascii?Q?BarMcCuuT/DwZzt2/TS0q8Z+AP6nQXop8MAAgQ9qpkQu3fa4dlclbaHg4A1J?= =?us-ascii?Q?6lpfLkW80VVLlD4hwpPjd3w6WNvfusZfb5a2JytmRmjBphFUQu6JEBJnnygO?= =?us-ascii?Q?CKOHb3jLDUiHpZfWTkAXxR9Q/gj3LjXQWeQXPmv4VzLasRVxhgopoO3ZESM8?= =?us-ascii?Q?Bb3twRC/5PFCOeoV5DTI+cOp0gu+Tfh46/X/QH9y866oUw+udBRW07POrJcW?= =?us-ascii?Q?eJXkqQCCgVQejhhIu/pjIMUfZNaAz3EOdF47K8xB3xXfycXmGNYIlRNK+p6z?= =?us-ascii?Q?XGjX2aVAwYTE0BkKbPY56nufqwdNUrO7h6dvUi0a49BVqA+goWhpAEjtM5fc?= =?us-ascii?Q?LyJ8BHqsQHH6gehC1e8oNbAssVKxNFknkRCr8ETwXMYaSLPmF/c1X6n/WfiH?= =?us-ascii?Q?iH5qdUddilHo6jvgERFGnasIT4LRoxY5gUSLJ04xOd7PjS249OpJXsqCoOUZ?= =?us-ascii?Q?JvXdOrFjllOzhVQc/fsWeRFVS7Sqend10zKBricf9iTFzjtORbPAiHnQCilv?= =?us-ascii?Q?352pd9M1cQLY66O0mGvtSdZ8Cw9++vw85xlnOLg3x4j/PaHDEF8waFbjyFSF?= =?us-ascii?Q?3Xs+B+xEONDc4ti3sscIO6tG22e3a+iXRV/swmcsvBi2bEqsb6UY88AOX04V?= =?us-ascii?Q?MrhctbQKcE2Ak1D9JPdFCWdh8BPhMKwGiTNQEtoBZOOnyMYoZf8ME+TRAYBK?= =?us-ascii?Q?SC0zsWmCeLD9tteKUttHkPu+LiZqY1gbSHrFqisdg5q2zcql5QqP5E8kMZSd?= =?us-ascii?Q?R60DAlvwsSfRB/KXrgtcT3lmLPrZGsiZQJQzrhorGGk7JuL7EnOTS9//QAyC?= =?us-ascii?Q?ZAzA25BB5RXBGr4VpCrFMmNbQh7b99ZEaGeLoqw0hK9K7nX68YcOcX0xAvXL?= =?us-ascii?Q?NErbEucQzjgrzqSb/Lse+HIUZS4ITapLpaXuY99IxorM5C6nYhg=3D=3D?= X-Microsoft-Antispam-Message-Info: bKomlkhDMrqi5+RLyqvbJXOZt2NTmoxwqMw6cDV2+ipacwMflwVrRzxFYSpCRS3xx8AGsnZobF8SSlU5LbSvGKD5pz0vA1ae7b0tM1zqD/uRP9T13PXZcHqbepFyrEY72jOJlYC4ElSIskeHNBGE6p4pXv/fafvIPTy5Hnzmvs9gWyOhNhSbvvMM9QnL1n7W X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB2082; 6:ZelNbtqQLEsa+Pk034ckY8NFnD7UDz8XSKxRoxdcw8BBNmvpx2F19P2NgVR7vDUzvjR+g0ezN573kHf1q0eqJQDCk9cpKEjs/nirH3HZDa0ImaZz9123ysvqLqGnBUQLH/ilNU19BYu5+a60HJxe1oXFd1pKcTRZ+N1UCVI6DT7Iqr5slU2vTJGEsUvqCYkBNIKst6F8GZYF2BOWq10pfEwSRE2ueAMxaSp1PXi3+nmwoEamOOo08KUwUgoY0RM5urmvDgY007Qtctg3xQes3bJp3JI+1BLpNWecj31L6tLq/aBLeW4yvc3oX9rDcdMlWJKypwMjLeGFFS7K3DCA/63wBDQWKXPtlrFxIgG6Jjo=; 5:8CLZE1Mb8kxhlCFZKPjkF9fUh7goYxZqwQyWKprqdg3XW2Mw/cSQWy6qJW7nAYmSXo49YHcPVkV+QNSxOAUwYEMA4/ITpY7h4EzhKy3bWP6/CkY73S49J4CBj15qVgI9MgBJ7HPFjRgk3K0uCkNxpMml29CUvXSaOrJuESxIZRo=; 24:SQhLkbaAFked716Vlbu0oRrouNbQq+GI3eocQYAi30HJdBxFMItDtfMns/6ZX+OmUoqZ+7xEo63iZw44vug/4sUkWJD3YO+ekgtmbnDyop4=; 7:MdFAoCJ3z7jHYqaoWiMj9l4YBdRZ+dtiijIo+MtV4PMkA1Ml+atPn3zhm6xnpHQ9e4S2WUH1M01OzZdInAAL6/U58wLwdjppQaPleubicdwnmMu56KwVjJeC7VVvDC3xcQx2tgY+DNHTJ/ss2yFCmP2XjBDjQ1GP+kI6eJ4Zq5NRNHFm41kNo5Fwmi00iH2v2bxXpwwaF07BhijNieyjT0canJ0WM9Odv8CmEs8q6ecBjhfrfLbN+J5j5BDbrLki SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 12:50:03.7895 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c92474ed-13cf-4835-47f3-08d589aa1b79 X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB2082 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is a corner case in the MPA unalign flow where a FPDU header is split over two tcp segments. The length of the first fragment in this case was not initialized properly and should be '1' Fixes: c7d1d839 ("qed: Add support for MPA header being split over two tcp packets") Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c index ca4a81d..fefe527 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c @@ -1928,8 +1928,8 @@ qed_iwarp_update_fpdu_length(struct qed_hwfn *p_hwfn, /* Missing lower byte is now available */ mpa_len = fpdu->fpdu_length | *mpa_data; fpdu->fpdu_length = QED_IWARP_FPDU_LEN_WITH_PAD(mpa_len); - fpdu->mpa_frag_len = fpdu->fpdu_length; /* one byte of hdr */ + fpdu->mpa_frag_len = 1; fpdu->incomplete_bytes = fpdu->fpdu_length - 1; DP_VERBOSE(p_hwfn, QED_MSG_RDMA,