From patchwork Wed Mar 14 12:49:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kalderon, Michal" X-Patchwork-Id: 10282083 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 269B3601E9 for ; Wed, 14 Mar 2018 12:50:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18B6F288EE for ; Wed, 14 Mar 2018 12:50:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0D7C8288F3; Wed, 14 Mar 2018 12:50:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 59D56288E7 for ; Wed, 14 Mar 2018 12:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508AbeCNMuT (ORCPT ); Wed, 14 Mar 2018 08:50:19 -0400 Received: from mail-sn1nam02on0057.outbound.protection.outlook.com ([104.47.36.57]:31296 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751366AbeCNMuS (ORCPT ); Wed, 14 Mar 2018 08:50:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=cC3m71nOAVWWepSwzG+ZLWus67Nf+dE/fg3fZMBOwf0=; b=BQPcMU8BHbKR8tt4aXp2M4EJm7SX7E4D5jyZ80sU2frskmtwq1JDB/VawkaWiiIbnxQHvilv9a8tFTwYWRmM2kde2r2AmKhC/AJWX+vdI+yp/Mg3uE3hr+lfBJ35Ab9ictkONTaI8dO2CMmDMvH/l0iDT4qr5Of8W5ntA00VCDg= Received: from DM5PR07CA0053.namprd07.prod.outlook.com (2603:10b6:4:ad::18) by CY1PR0701MB2091.namprd07.prod.outlook.com (2a01:111:e400:531e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 14 Mar 2018 12:50:16 +0000 Received: from BN1AFFO11FD018.protection.gbl (2a01:111:f400:7c10::160) by DM5PR07CA0053.outlook.office365.com (2603:10b6:4:ad::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.588.14 via Frontend Transport; Wed, 14 Mar 2018 12:50:15 +0000 Authentication-Results: spf=fail (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; mellanox.com; dkim=none (message not signed) header.d=none; mellanox.com; dmarc=none action=none header.from=cavium.com; Received-SPF: Fail (protection.outlook.com: domain of cavium.com does not designate 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD018.mail.protection.outlook.com (10.58.52.78) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.527.18 via Frontend Transport; Wed, 14 Mar 2018 12:50:15 +0000 Received: from lb-tlvb-michal.il.qlogic.com.com (10.185.6.89) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 14 Mar 2018 05:50:13 -0700 From: Michal Kalderon To: , CC: , , , , Michal Kalderon , Ariel Elior Subject: [PATCH net 2/2] qed: Fix non TCP packets should be dropped on iWARP ll2 connection Date: Wed, 14 Mar 2018 14:49:28 +0200 Message-ID: <1521031768-19131-3-git-send-email-Michal.Kalderon@cavium.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1521031768-19131-1-git-send-email-Michal.Kalderon@cavium.com> References: <1521031768-19131-1-git-send-email-Michal.Kalderon@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(39860400002)(39380400002)(396003)(346002)(2980300002)(1110001)(1109001)(339900001)(189003)(199004)(50466002)(106466001)(26005)(16586007)(2906002)(110136005)(76176011)(54906003)(356003)(186003)(86362001)(4326008)(59450400001)(51416003)(316002)(107886003)(77096007)(2950100002)(6666003)(8936002)(47776003)(50226002)(81156014)(69596002)(336012)(36756003)(8676002)(305945005)(85426001)(105606002)(48376002)(104016004)(478600001)(5660300001)(81166006)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB2091; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; PTR:50-232-66-26-static.hfc.comcastbusiness.net; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD018; 1:PQBiu8Z0kHharUh0Xwm36wIxn4SEu/vJ/H2sifCNAn1fmjP2RGyROTywUkS6ZqSn1qbG1MzzwXUR+revhdhKPjRVCku3oyWZ3U0ZLxYhHJkTG5buc+X2PhMJNz+VzkXe X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8bb28117-241e-4cda-c2af-08d589aa227b X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:CY1PR0701MB2091; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB2091; 3:EHS16vOjSobiwoVuQPvgW8jDjOtYIDHzmTETAHLjFmxAqAHGcNKBcoVm13WWDVYZIJG5UYKQBuSu3XvrPqryWh+vBMFzmpElCXSZ9WBV1q71NlAWGNabhKCPVJb5WnvZc22GbMCeOWhA8sDwKz35PH4oS2l1Xc325tnPUg20X+UBxsFUF2mA+TfycHWprZpxQBHZ4x2q4fpqpQDpHXv0mzIvyKQ1svLvbUvvWMaC+RD/WM/Kf8FiF29i5IXiAqz/P3b0ze5Qd9biL+Nlc/hZUc4IBxPnb7g77XYUGBfqMC6VU75wKbruAPj9wVwleT7f3UaPZvneqRloyebzxOep7PGE/9dR8caxW3UNNJEkS6Y=; 25:lQKgXyfFyohP8dvV831lTGYrWUduh4Apd5Rnqe55KAGyvCrMd5OtRZ8NtvI3ms2n7E/zDSt7CNOVmp0H2eTR4riKiR7Ur7/io7taFsUgFXHB23B9E8v0jCNOI1BihrpiyXOjn1t89vlJe0vXTvyKWEnOmdv3PTWAXS2ERSB2XSyOTOOktkOkxoxORyVEubV3VSd52KMJ74Sbxsax0VpbDcs9g/e0FYD3q6uSrEtpzq7FPGLI1X5A6XAKbkc9Jl71BKtfqefcrfJjXJiNVp/t0Ckve/HJ3Rvvpkwq2JM0ZrKl3IC/SiVcZjZn/DBCDmqVNeC/6QaWiWDwgC2jzU7XMw== X-MS-TrafficTypeDiagnostic: CY1PR0701MB2091: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB2091; 31:3omuhpxRhjOEE/LpERF+baF/uHlmyIABHHAdAfD3hvvJT2eyU01UbpQhyFzDKulzFAa7i2sHierUPTFwOcZDZndQ13ZoVtLOmRq3d+3Mn/V6GLP88bfgu+KARn1HzAfKRzA/J+ygBKhdfQred1vY4adw776y4AwvgoVVALi5b9ndjuYSnTTtAWs2byh5Y598PMVy7LM5uM45M8fLa9n6mpCrj9NzS7SH2f5OwhZovr0=; 20:Uk34nJX04HmMhWkVazJ2a32jHbUq4mLKEnXmxEIBkugeuA58PeQJaYwKX6QNxzVDZ5JAfp1bYkw2xVmzm9WmM2Qz2q6U9Q1fnTpbpAdlkpIQ7baI5QgG+KdSsRxKZEi+oTuudy6oaAdYhUkqmAkLaynh4+gso2z8A6vEg6fUc7MHgf8glCqgrsWspcsMruooNUXIz1qAtUTuqRlxehSZJ+Bsrct6VLdTHULoGoMhRRKTLZcMeq8AQQC+Kn19K89Qbr4UQq8/3Gq57NhW3r3GTCScgViRrTK4IeI3ChzF5S35392oUuugvTH8FXrpr32siFThOQRf+genChSIEl0t9UcjjVccJgGTZEipf1JLXKFV+wao+X2LJgiHD/JtUiXoN8dKsbz4IN4+zwB0vBpIhVny/XPZutZZ7BDd7f8USoeqtmLlJm+wZWKJMTIAk2mX4ZJcyYtJXU2YtVufyx6PKzWaBbdo3SttEqr2nXsCF48SLLPFxi4F/Dc383YjZKY6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501244)(52105095)(3002001)(10201501046)(6041310)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:CY1PR0701MB2091; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB2091; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB2091; 4:19wt081Xz0Wc3RtY/hQ/+aIzNjek+Nzy7XsuZnCvjM4bkoM/e4+6VvtByMmA3yGyjJgnJSPf2epHfMnC5RBjpM//Z575LkmPL7f5YtloxfloIetVwAHulnG+nkuEhfrk5uefPlvbRgt1TR8C4TlxL8WM0ojD5a7rita+5pvt9pe45IuS69R6zdcMHR3dHSPM37TWuMTICDGugvkxdQoZ+ROGR5tB5let2xvZ7Y1NcSZg1IKqGx6sRak5COifmCzoxU5kMFuu+Y69B2wTfC9f0Q== X-Forefront-PRVS: 0611A21987 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB2091; 23:QVzuG+NKgs916c0Ak/+ijl1aIunRogKoyyVfbrY?= =?us-ascii?Q?39Lc0mex1WX18Z9A1aWVSvn4vmDcXWxMoJtjO7lftOuC/3wncGk8H0wdF6Jk?= =?us-ascii?Q?YTsV2c6IlewzQxE3FKcA6hTAcjq0MtzgqawKZ49lwcv4+SjbJZUMJx3g3RYR?= =?us-ascii?Q?11ZVfjKcADcem4PTMIAUw9vAszsAmApHkOP+hxeZOtcpFFQRJqpqyzpoha/T?= =?us-ascii?Q?vguvMeLU/GlQKzG9jh4WeAFVTWMxOFd7Ix/Asn8NfPp3F8wZrKY6ZIdgWt1I?= =?us-ascii?Q?RU+DzK7i9hznnltE4WP814o1H8KNXWSNHw11Fe17ckEGbHkjQc3TZ4h6PPYB?= =?us-ascii?Q?tthBRhl3mXJjjBiURJbYztfGpaHiGE42QozyXpDo1jmIKSV6aETviTWCmai8?= =?us-ascii?Q?sqXixShpAPJCLGzw6iV1hgD5DW3zmuKEx7/s6WVoeBKFE8pf4/hW2up/324m?= =?us-ascii?Q?mM1D+NTCcp6HqaVqn8m17knCQE/XFFFcxV6RrsksxoE3XUzp5WYiPQV1a8tT?= =?us-ascii?Q?TI2s112Dazw/yJuLqyXz1lh175wut9euW6702tH1SpxBnPn5roolLEz54dIy?= =?us-ascii?Q?zuDgm9oMfvlRA0JswF9uBtqbSUflJ2/SQJPwyGJdn7uVdRiwjiVxRRFY51AT?= =?us-ascii?Q?iab0WyXAsEU02bHdQkLQahMZQ3cpGS8VLP+MWDDKvrotXSWf7Jx4EVW7C2TR?= =?us-ascii?Q?pCtTsY8DjgBP5aUY4M4sw6RrpBvnY/0V4CMHB8FIujAPbyl0tRggXorieRPk?= =?us-ascii?Q?6rwQxpz3s6OvtWduWk3RMeVcG7m+sLE1r2DmpvST9pgWXBz1pfPzBMarOuoX?= =?us-ascii?Q?4n/AQfrBavLtfxWsgtsdFcGYX2h3qmrwfqbEgL5l0o0gtQOJHam9tgXVjnmS?= =?us-ascii?Q?92g/SDDCJJqG9coOzYk1648N/rULm5Yg18YXfGX9wLNy37Rz2KMFFac0tyxb?= =?us-ascii?Q?Ac9yop5pyEBe8Ednv64hqfda0jbz3lWE9MpLHiEeegCOKut0UtmhIrixuFsl?= =?us-ascii?Q?UBoi6EdyG74HE9d/szh7fE+wRcnt5eX7fTu+zS5/o5Ivj5ONuBQyQyFZVO/E?= =?us-ascii?Q?kMdSxP52WpX8KjBzpau7TC/He9m1YMVkpIm+QU7EmcQ/xXZX5vg=3D=3D?= X-Microsoft-Antispam-Message-Info: C90h7H8W7ykaeMoxrvABGGgl5WIIbH4GytsooGfZbqaJb6PU9KfuXwKP5SBGeQ1zQmSlDRIr/mVghdxaqBcTxDdl8DCtCd4EYCJPmy2jRLkN4UC/dNWQn7/UFqQ1Q+DuSOhu4XGh43knczfA2fqDgoatB3zAu7tha2ZCqD9/VeZTUbWFL7SRo4YL7luMUbM1 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB2091; 6:BMvGBtoEWI+DReoBeQ7AbcLJYz06mOWPcMd8mYfMgBDh7/lThc5uhEmkIylVWZJTRDFisF5liRYiGQi7R6BfdZ8jnRvEWV0mX/R8m1f4XoAv0R4uZz1MdsmhPg1s2qaugsYqLvaDZsfsExiayaAUICBwIJQLHU9yi2VcMBEZcd0L8IPjQ0gQEwYkh7S3UL7MCzcPR4Z6xpD1aLiJwCvZzzF2UPZ77POsuxHQ3YcZY5QiuTq1Maq3kZzlrKjKeKYHp1By1rYOTHPkCvb2wK655zbFLUyHG2+3WEKzCCugeOWn2Aa7J18QNNhKsTuO+ulEud2tQMq4c//far+ZXZu/7lTNeQqGZOr1JqE0jqTzNkA=; 5:f6t9Kzy+kVnLKH+qMCpqGLBp36A6zrIRjXbicuvP1CKRXs+o+8tZWO45sszi31/bfgvnzYuGsBmD+vpk1zngDRgJ8uZJMNSfDWqWmQsuVHQhfkmO1K5k256HCbBY+NSkzWwdSEylZV94OyZXXqn0maFke52x50crKo2EQD5zaCY=; 24:qRa9YlypXzpJkQsaLX0bVmUO05ovadB3NpRfArNVPwvczcknHkJ0Ettm/o1muxpTpP/EpNWbCYz9b4kz8CzHmEBv5sH4FHx2j86SDsEWq38=; 7:WHpbuDljc8nK6l3kibQf9viMspvZidbZSnO7KmM15JFCatWoKvf8mZmCA7DEDYIkSJItnh49mXuIyS+B6pY7rZipyIJoTird+vAL0ltXUA9GTSikHn0nvE4UwRlW7Y2hsc1RF01MxjDB+rYglk9zSyPMdNNARVfVevLW5KGsFmKZnUVTi0O328XMDHfDFVy7oPhw4oia/xPoKjtR+Q+T1i+WDXNEbgglr2gIrxZUZWxX5n7SjO14qxZQAQ1+sryH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 12:50:15.5342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8bb28117-241e-4cda-c2af-08d589aa227b X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB2091 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP FW workaround. The iWARP LL2 connection did not expect TCP packets to arrive on it's connection. The fix drops any non-tcp packets Fixes b5c29ca ("qed: iWARP CM - setup a ll2 connection for handling SYN packets") Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c index fefe527..d5d02be 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c @@ -1703,6 +1703,13 @@ qed_iwarp_parse_rx_pkt(struct qed_hwfn *p_hwfn, iph = (struct iphdr *)((u8 *)(ethh) + eth_hlen); if (eth_type == ETH_P_IP) { + if (iph->protocol != IPPROTO_TCP) { + DP_NOTICE(p_hwfn, + "Unexpected ip protocol on ll2 %x\n", + iph->protocol); + return -EINVAL; + } + cm_info->local_ip[0] = ntohl(iph->daddr); cm_info->remote_ip[0] = ntohl(iph->saddr); cm_info->ip_version = TCP_IPV4; @@ -1711,6 +1718,14 @@ qed_iwarp_parse_rx_pkt(struct qed_hwfn *p_hwfn, *payload_len = ntohs(iph->tot_len) - ip_hlen; } else if (eth_type == ETH_P_IPV6) { ip6h = (struct ipv6hdr *)iph; + + if (ip6h->nexthdr != IPPROTO_TCP) { + DP_NOTICE(p_hwfn, + "Unexpected ip protocol on ll2 %x\n", + iph->protocol); + return -EINVAL; + } + for (i = 0; i < 4; i++) { cm_info->local_ip[i] = ntohl(ip6h->daddr.in6_u.u6_addr32[i]);