From patchwork Wed Mar 21 12:51:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kalderon, Michal" X-Patchwork-Id: 10299421 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8CD37602B3 for ; Wed, 21 Mar 2018 12:52:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77E3C2843B for ; Wed, 21 Mar 2018 12:52:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6BFDD28699; Wed, 21 Mar 2018 12:52:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C70B32843B for ; Wed, 21 Mar 2018 12:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbeCUMws (ORCPT ); Wed, 21 Mar 2018 08:52:48 -0400 Received: from mail-by2nam03on0083.outbound.protection.outlook.com ([104.47.42.83]:36775 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751405AbeCUMwr (ORCPT ); Wed, 21 Mar 2018 08:52:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sOz2reEbYQahfZiCYT6EF6expI4TrsbWCZnEA6DVGCw=; b=H9Cw+/OPs3EcMuEg4rXhCCo5kNjN+A72D6e3Riocmlc38axWvwF/eS2QFpvdvO6J+HI68lpcnm39R/s0aQiomLomBcEOuKUnsdwC6deZrdT+35rRRaPrNfFyn5wGqG5s611U3CVnoXz5Fjn9AL5NCEwxx3XaRvWxiBMbjQG42to= Received: from SN1PR0701CA0007.namprd07.prod.outlook.com (2a01:111:e400:5173::17) by SN1PR0701MB2096.namprd07.prod.outlook.com (2a01:111:e400:530b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 12:52:40 +0000 Received: from BN1AFFO11FD012.protection.gbl (2a01:111:f400:7c10::197) by SN1PR0701CA0007.outlook.office365.com (2a01:111:e400:5173::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.609.10 via Frontend Transport; Wed, 21 Mar 2018 12:52:40 +0000 Authentication-Results: spf=fail (sender IP is 50.232.66.26) smtp.mailfrom=cavium.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=cavium.com; Received-SPF: Fail (protection.outlook.com: domain of cavium.com does not designate 50.232.66.26 as permitted sender) receiver=protection.outlook.com; client-ip=50.232.66.26; helo=CAEXCH02.caveonetworks.com; Received: from CAEXCH02.caveonetworks.com (50.232.66.26) by BN1AFFO11FD012.mail.protection.outlook.com (10.58.52.72) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.20.527.18 via Frontend Transport; Wed, 21 Mar 2018 12:52:39 +0000 Received: from lb-tlvb-michal.il.qlogic.com.com (10.185.6.89) by CAEXCH02.caveonetworks.com (10.17.4.29) with Microsoft SMTP Server id 14.2.347.0; Wed, 21 Mar 2018 05:52:37 -0700 From: Michal Kalderon To: , , CC: , , Michal Kalderon , Ariel Elior Subject: [PATCH v3 for-rc 2/3] RDMA/qedr: Fix rc initialization on CNQ allocation failure Date: Wed, 21 Mar 2018 14:51:51 +0200 Message-ID: <1521636712-30608-3-git-send-email-Michal.Kalderon@cavium.com> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1521636712-30608-1-git-send-email-Michal.Kalderon@cavium.com> References: <1521636712-30608-1-git-send-email-Michal.Kalderon@cavium.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:50.232.66.26; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(396003)(346002)(376002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(26005)(76176011)(72206003)(2950100002)(69596002)(81166006)(81156014)(54906003)(110136005)(36756003)(48376002)(8936002)(336012)(59450400001)(51416003)(50226002)(186003)(77096007)(6666003)(4326008)(8676002)(107886003)(478600001)(106466001)(85426001)(356003)(305945005)(104016004)(2906002)(5660300001)(47776003)(16586007)(2201001)(50466002)(316002)(86362001)(105606002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB2096; H:CAEXCH02.caveonetworks.com; FPR:; SPF:Fail; PTR:50-232-66-26-static.hfc.comcastbusiness.net; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD012; 1:AU4ug3/XmGUkfG4ESOWmCDN34Na6q7af2lHF4SYnaQ+B6jieLT5EWU5/IAaB9qqoCQv92Rv9pZFlW0ZpejUQiYYSJGk05FlPey+/UdwFMaNnlQ05Vyp3T0L2PiBd/wV4 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39872dc3-0ab7-4281-1c02-08d58f2aa15c X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:SN1PR0701MB2096; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2096; 3:VbriZsP2Nqcc19lKT+pvMYcpNIFam5C4Xdh7fsFm6ssuQcUfi2cqngGrJ3P4vJ3ZZqYOeZZexM/lmjoKUJHw3YFqEe1Eao3iOcxqf6004lOgLy8uwGoGoh9BuKsdXL2avgD8hBMqPQ6hF86th7sixh3KyXwx5Ga7YRiK4m7H9hQmS9fLs66g6wSseqdMZy4IeSt1seR+yhZVK7QCNc8qQUDVpyACNNoRbnMzaTU5VfDboeli+StAqsp/UtpEW0IWuLdznIrB9vryUOneynFwUp8FVstFlGpqQ1pHrJ6ycNbot6J2xaGmRRH7wYqRIkbJl4GPQNgmYeE5solTPjfXhpj4QeXLMGchkyHFyimtHyU=; 25:GMVBKLTZ56bd4XD8Tzrery5m5lnCd/jxNJtqS+zSYAJtlSdu4FrsnlT0f3RXzcnf0RGWWkx0J0AqAzd9bcZykUdT7RPdX/Lng87kWM1Z4BKl4TfkfG9kl8AMYqWKv9zBUbVC63a2zrMCBGATCVIiRR32PapkFJrK6a+ny4oE1wLHszV1pUt44Xa3CHIFX6WMVdVllbYBCdz8HQYtnGaRlt9hdGfQWwo3jFVqyJGLRu82RSViKW+6ZW+fkjv8xdWWSplZLxaO9Zjv+e4Wae5DTO7UQGPyL838equJqVKpjkNJMqQBVslSyE4GN0lBC9VLIc871S+jNXOnnHxVgfZU5Yp2QKazj7Hm9kKmYGFNYGc= X-MS-TrafficTypeDiagnostic: SN1PR0701MB2096: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2096; 31:p4gVOzjXwT9hDIB22i4d3pvIpc4xbFgnhcGylTFUK/XirNNgqCJ7n2P0a7O1x0HP0NVUCLf0YCzRIVTW+hIV/GfcInke+3w81v9I40CpK2jO43YVPTi8dMBUmoHcLC84VobdS5mT+BCicXm+fzwRvTr46HQSXtsJg2xbj0LLWI4SIlL1Cy9KgmxNozrJcHgSFFDym0quJsLMzDExUTcV7nNioUhYWlDGgLlVBENifxM=; 20:I6qlTplFu9szqoSdxI/+VXaSW/eVWpzWpSC79h7BWadFLhS4mkkATR2vN/2E8oLGjZP5vRrAOFstFNcjmsdQb7j8buD5xlcEZaVd5t3dz8GaR6oK1VBwaPa37q9D/x4yMknpdLqirAOzZdu9kH8PjcEk6Ux2qG4pg24xCTo0Ip9Gp2HESI3UzTHil8j679zDyjShJaPxuqj0X1NUzvWOzse3fe4Lkt4IwOR9hY6p60/rpHVrLSEKJcdXz4aubrtG58KF3azks7XZwfoqSdBdftN3GWQ4Pzg5zkQxAihf8vHn5hnrxjwy9NkAj49qrQ4SKJtVq/y5gX9xoaS30k6I86gP0r3stdTIY2UI10XBLI+ANrsxsEjYfENn8GeX2RFrSCE1c5iR7qyacbf84plHJWs+qWAaC7IYD+DgwSpyuoBpfvu6emWAPzjVuZ1IiPlja9z7PD9lWwf0PtfBeFdkrFl+flSf01EoZGFUfEPeUn4M2jAAcquG/xweOnZk2aaf X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231221)(944501323)(52105095)(3002001)(10201501046)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:SN1PR0701MB2096; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0701MB2096; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2096; 4:g3C6Nf/hk4p+0DCuKfjunSvYCI00KdkvT/1Yj+XD7WS6s8foStPDQj5jQT8ThFcPeImgE+xBCyVzaoB858cDxsDiS5KzQs9d/4lDs+0uj0vjIDlwXpHtLOFgtBS6nPz765Q7Fvs3CHniUOFret7h8bHjbgg+Kz1YpdSjab49ZmnuB530IHu2foI5xdq9zB5xcgF0gsDp0BFzAs0L8k15DTqTO2vIOhGz6nGODtC70cJ1Utku/uKl+vhkf4ek12r030AdlHXuVNzMq20Fl3vH6g== X-Forefront-PRVS: 0618E4E7E1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0701MB2096; 23:O0jCwqqvpfsDr7whS7YdVYjV+r7xxoV5cBbabJo?= =?us-ascii?Q?AR8sUsmLIag1MrnySTvuT8Pv2IDaNK8Qs9/y6l8dGhXuGTqsJUlypL/ZkYQD?= =?us-ascii?Q?bCbE8mUGlAN9gl0bMMQcPmiAF5iq+VFZDBNSbJGEIjX0LWA+Kumi3cI0f+ZJ?= =?us-ascii?Q?sABVrS55P2YxTpeGXUow1JIZiNXw7B+441AXv8g5DCVevsymhsztJyID+Wrh?= =?us-ascii?Q?51i3MDUFlHPyc2vkYbfh+ItcTs8L5H0HHW4qWOP4inAaoSetugeEyEpp2/qt?= =?us-ascii?Q?wDatNNfDzivTEQuIWm9RC3hzLE+n9Demk7ZL+jRw0issJ/CRpc7a61OildK6?= =?us-ascii?Q?bqt2Cd8DtADaQ2hzscZvQ+yebas1GaypytlwIyRZutHhKunaxZlRcsajDMh6?= =?us-ascii?Q?Q6HdRgx2W5OVQNCGBw3Ba8uXPcHSqY671Rwzfbs2DaCtS9mw2GKvwsY24C2m?= =?us-ascii?Q?78SQEfq9OgRpRNOf/odnSj+apQJPDjmxhc+Jb/Jb1XcXyRTj8QdUqFi7ii3t?= =?us-ascii?Q?TRuTLCsW58qqLahkQ/0AMySXENV0uxkIBQUsx9TVVGPFwuyX0No/luss6qxJ?= =?us-ascii?Q?tBlVBSkEOrmM6GpagKY+fo3jYX5ZGSWgKl8AODH51tg6XX7WFPcXPIHaOCFX?= =?us-ascii?Q?Vli9gJkSIxGVUbDEEX8VzrGxxWBCPdsyT+JQWkSXFayil46hPDEAxvoOAy0W?= =?us-ascii?Q?MChHnOF07AbkwATe8L/bNMHJqX15FkOSsCXdTZrqjHdSHdJe2AKVm/ZiDCEO?= =?us-ascii?Q?+W52yyNbiqgynvFpuLsQB6bWc74bkuJZ3N9RgKi6nyZBbVH9BM0BT4iP2dsD?= =?us-ascii?Q?j9Yfh3Tn4MxKWL9Bk5EhkTjgE4sm0dIy47NxYvT7sKG4mSFcGiSVqI3nWrEB?= =?us-ascii?Q?sJabdnPyOm9Mx9AL1nx7dEimMxdCuaTg110kwqHJKBmq6KlpxVQB29htJyp5?= =?us-ascii?Q?Wu+tr8gu0Pb2ZHzKYc8wNrNIyR/cxQsvUKOUMOx5uvqbsgKdtnSq5gKx1qlo?= =?us-ascii?Q?VFkiigMXq74JVSRCDT/2MZoLAZcf/gbl4AIrRrRv6iShdgwC/IL3wcwMTAFL?= =?us-ascii?Q?PE39UG5D6xM8mO7M2N5H5aMFdc3LidQhLhcmWj4ecrBbPjsC4zIesaFtHPdl?= =?us-ascii?Q?j5ZWemwTbK08=3D?= X-Microsoft-Antispam-Message-Info: z3uROrXjfQbEyii1/3SnulJ/SkQIV5dX66CZEA03UWVO4MoQt1EKH+oFJcCWV+c2JBpKrKW5SFyNOYNNM+ziBGMtLnQ6KORWBrV5EXf68UuNwLv8b83DjcMFqIM2HPz3HfBdyEDetQerIzj6zAvufWeF072F3QSP1BgtciDwquH4wpso5o3YkzGBw9E6EpLC X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB2096; 6:LsVTObyISjfvvXeSvnNGzGDIxJ11+fUhLnnR6/OFHM34V0bWkF5yQYDfjn2dyAbzYfOGOVS689ny6G/paIsV7/hnZ9FRfvxcTGkmSUvJY+qVQjAsLXpqbbRBtpnFT6T2UUDSYSSDT4axC8GsS9j+zDx2PhAT2YEPllQurFwVQgPVzs84WlLy9N8b4GL7djOjR9WbIhHhIFyuwgoCXq0yOndMzuW5IOmz45ETDsRrQnOaFdpArxdb3LwMLI4rJ4OOpebznePckeaBXvLBVIPbwTfnJ1nogBuAMcDlWzrgaiWghiSGaN7QzEdkcX3Y6smBGOdxzFnUYBDfGjkeaP6Tq88PSlroqiePAegX74BvBr0=; 5:HSmrZtRh6vBQposuUkScH7f4cc6O2+pv/oyncM404bKbPM8o5PpuYQQdmv8Ox1U4bbFw+JqgPH990Y9hfIyoh1/HoZh/e59dhbnKab/KbphPFE1H3ojzPikofBLT8E1o8Iu3Y84odrjEJLfFAJn/k8A+1s2ey+Okdbz5lDyvpwc=; 24:7Q6NVjE0AJBFJ4WTBCARCJs9YensL7WsLVqrRSWT1orxQ8/darqmIVWw2d4TBNo4Nibkt4e8X+e/3paUpszTJc8KYOoKsXLO8MtQySADEqs=; 7:VsYbvIqsfc1Muk2SVzHVXN08KXU6EAcSsWLMVvXPQEX9YW0JIQrR7imgHTZ+wqT10ukHvsJWNykWzhc2SAuoGYF1fWls66/1Oy+xBN5Q28xpqInX5geMcwZje+gVltOkWBG+1DbHthNR6JBDzKI8M8e/95AG5yzjAZLHUqOwbCMLTyRLQb/j2Fu8WkGn+R4yd5GNvj8gPNo4ceWzagUh77KhcWcf9t/zrz4ZrkVVCEscCY3rWdmHCy/BpxjtOGVp SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2018 12:52:39.7927 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39872dc3-0ab7-4281-1c02-08d58f2aa15c X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=711e4ccf-2e9b-4bcf-a551-4094005b6194; Ip=[50.232.66.26]; Helo=[CAEXCH02.caveonetworks.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB2096 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Return code wasn't set properly when CNQ allocation failed. This only affect error message logging, currently user will receive an error message that says the qedr driver load failed with rc '0', instead of ENOMEM Fixes: ec72fce4 ("qedr: Add support for RoCE HW init") Signed-off-by: Michal Kalderon Signed-off-by: Ariel Elior --- drivers/infiniband/hw/qedr/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index db4bf97..0ffb9b9 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -833,7 +833,8 @@ static struct qedr_dev *qedr_add(struct qed_dev *cdev, struct pci_dev *pdev, dev->num_cnq = dev->ops->rdma_get_min_cnq_msix(cdev); if (!dev->num_cnq) { - DP_ERR(dev, "not enough CNQ resources.\n"); + DP_ERR(dev, "Failed. At least one CNQ is required.\n"); + rc = -ENOMEM; goto init_err; }