| Message ID | 1522814778-19318-1-git-send-email-parav@mellanox.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Apr 03, 2018 at 11:06:18PM -0500, Parav Pandit wrote: > rxe driver's add_gid() and del_gid() callbacks are doing simple > checks which are already done by the ib core before invoking these > callback routines. > Therefore, code is simplified to skip implementing add_gid() and > del_gid() callback functions. > They are only invoked by ib_core if they are implemented. > > Signed-off-by: Parav Pandit <parav@mellanox.com> > --- > drivers/infiniband/sw/rxe/rxe_verbs.c | 17 ----------------- > 1 file changed, 17 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Tue, Apr 03, 2018 at 11:06:18PM -0500, Parav Pandit wrote: > rxe driver's add_gid() and del_gid() callbacks are doing simple > checks which are already done by the ib core before invoking these > callback routines. > Therefore, code is simplified to skip implementing add_gid() and > del_gid() callback functions. > They are only invoked by ib_core if they are implemented. > > Signed-off-by: Parav Pandit <parav@mellanox.com> > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> > --- > drivers/infiniband/sw/rxe/rxe_verbs.c | 17 ----------------- > 1 file changed, 17 deletions(-) Since this is fixing up missed stuff in an already accepted series it is applied to for-next now, thanks Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c index 4f8a2de..8f2243b 100644 --- a/drivers/infiniband/sw/rxe/rxe_verbs.c +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c @@ -83,21 +83,6 @@ static int rxe_query_gid(struct ib_device *device, return 0; } -static int rxe_add_gid(const union ib_gid *gid, - const struct ib_gid_attr *attr, void **context) -{ - if (attr->index >= RXE_PORT_GID_TBL_LEN) - return -EINVAL; - return 0; -} - -static int rxe_del_gid(const struct ib_gid_attr *attr, void **context) -{ - if (attr->index >= RXE_PORT_GID_TBL_LEN) - return -EINVAL; - return 0; -} - static struct net_device *rxe_get_netdev(struct ib_device *device, u8 port_num) { @@ -1271,8 +1256,6 @@ int rxe_register_device(struct rxe_dev *rxe) dev->get_link_layer = rxe_get_link_layer; dev->query_gid = rxe_query_gid; dev->get_netdev = rxe_get_netdev; - dev->add_gid = rxe_add_gid; - dev->del_gid = rxe_del_gid; dev->query_pkey = rxe_query_pkey; dev->alloc_ucontext = rxe_alloc_ucontext; dev->dealloc_ucontext = rxe_dealloc_ucontext;
rxe driver's add_gid() and del_gid() callbacks are doing simple checks which are already done by the ib core before invoking these callback routines. Therefore, code is simplified to skip implementing add_gid() and del_gid() callback functions. They are only invoked by ib_core if they are implemented. Signed-off-by: Parav Pandit <parav@mellanox.com> --- drivers/infiniband/sw/rxe/rxe_verbs.c | 17 ----------------- 1 file changed, 17 deletions(-)