From patchwork Mon Oct 8 10:28:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 10630369 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6B54F112B for ; Mon, 8 Oct 2018 10:29:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B12528986 for ; Mon, 8 Oct 2018 10:29:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4F3A5289A6; Mon, 8 Oct 2018 10:29:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0656028986 for ; Mon, 8 Oct 2018 10:29:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726995AbeJHRkO (ORCPT ); Mon, 8 Oct 2018 13:40:14 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:38797 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbeJHRkO (ORCPT ); Mon, 8 Oct 2018 13:40:14 -0400 Received: by mail-wr1-f66.google.com with SMTP id a13-v6so20201355wrt.5 for ; Mon, 08 Oct 2018 03:29:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Dl7WFmwG9M4v+e+KQ+QgNKbu+AcRFf7HegZVkzhnHXY=; b=B943UpD3VNySesHQnN/gLb3nlxxtOt3KJ/skfkIyewvW5EHj3pP/pFnuK5HjnCa34B taJ306mecmmUGIgNOUVQq9x1OZgtIrVydR4NiZCTR0Hq3EKQt/qypskOB1KEa9tRs8oE 9NNXALbbEY76XLEpbiWqrb3HS1qBt34TACWbo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Dl7WFmwG9M4v+e+KQ+QgNKbu+AcRFf7HegZVkzhnHXY=; b=qS5/HNSRM6/3osMuQ67ndeabWNmYSUtsKzdOsItjKCsL2wQ960Xmn4PS8mh3Gu1+NY kRXzVRAXoGJRnzZrk2N4Chm3xuOrQ63JGVo28z3RJUJdnj4CLzj5/IV9gznIFtFkpEg8 Wyuq9pd7T1dJn68oiMt3mVocrSqkQAqglVukdFuRq8MMYgX/2Bb9MtdSe6Om7Ty5h6iZ mFEstjjuRylhd5RT94rDd6+bZ5jOdV+02r4aLpOhwV6rTEhMofWQVrcpk5pCBYnoRech zo3l5dlGbkIcL1icq88NToy5RkY8VMcNRCtUsQcLlunsJ74JTj0rpY+bInBMSE+3AIK6 TJlA== X-Gm-Message-State: ABuFfojCTx0dUvuK6U3KSRokOfwWZsxZHKbc2g63bo8feGb75cUCXeZL lAvsBCaMil02zK2zJg3yIhDu2g== X-Google-Smtp-Source: ACcGV60hf3g3iq64VYshIUwyOEkRtSvluQBh4PbjH71jfQ4XXIu6IazUlQuGbltww5KLo9QKtdfNCw== X-Received: by 2002:a05:6000:c3:: with SMTP id q3mr15278551wrx.302.1538994551245; Mon, 08 Oct 2018 03:29:11 -0700 (PDT) Received: from dhcp-10-192-206-197.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id 143-v6sm12674897wmv.6.2018.10.08.03.29.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Oct 2018 03:29:10 -0700 (PDT) From: Selvin Xavier To: dledford@redhat.com, jgg@mellanox.com Cc: linux-rdma@vger.kernel.org, Selvin Xavier Subject: [PATCH rdma-next 12/13] RDMA/bnxt_re: Wait for delayed work to finish before device removal Date: Mon, 8 Oct 2018 03:28:03 -0700 Message-Id: <1538994484-21390-13-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1538994484-21390-1-git-send-email-selvin.xavier@broadcom.com> References: <1538994484-21390-1-git-send-email-selvin.xavier@broadcom.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Delayed work bnxt_re_worker would be still running even after cancel_delayed_work returns. This causes crash as the driver proceeds with device removal. To make sure that the work is finished before returning, use cancel_delayed_work_sync. Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index 2b1d00d..75a54c5 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1203,7 +1203,7 @@ static void bnxt_re_ib_unreg(struct bnxt_re_dev *rdev) bnxt_re_unregister_ib(rdev); } if (test_and_clear_bit(BNXT_RE_FLAG_QOS_WORK_REG, &rdev->flags)) - cancel_delayed_work(&rdev->worker); + cancel_delayed_work_sync(&rdev->worker); bnxt_re_cleanup_res(rdev); bnxt_re_free_res(rdev);