From patchwork Mon Oct 8 10:27:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 10630347 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D1780112B for ; Mon, 8 Oct 2018 10:28:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C25A528609 for ; Mon, 8 Oct 2018 10:28:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B6C2C286C0; Mon, 8 Oct 2018 10:28:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 639A928609 for ; Mon, 8 Oct 2018 10:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726612AbeJHRje (ORCPT ); Mon, 8 Oct 2018 13:39:34 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35225 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbeJHRje (ORCPT ); Mon, 8 Oct 2018 13:39:34 -0400 Received: by mail-wr1-f65.google.com with SMTP id w5-v6so20225563wrt.2 for ; Mon, 08 Oct 2018 03:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z3CAtp2jXJ0gvHLzwYRt2YV+O39d5E6xrvViRNARCWE=; b=e0bG1Qx4+ZCUoWn35HMqgUMg7Q2MfFR8bdUQyHyhnFHwNPmgOLcNrt1llPvP2YKoap 64ITLWwIvsWH29nnYz/EIchGJUs/jxkcdJEBudRSTvZB+zy3pRz9TbPkQ3wxSigLBNb/ cmhfiCbZet8p6iPpKcAGfC8DL3VfpstXoAyUw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z3CAtp2jXJ0gvHLzwYRt2YV+O39d5E6xrvViRNARCWE=; b=ZPXJV/9SIlMyokUhPsuH0kIEGgR/dbO5hQbw0XkHgFWbHKLmdskH44Tihnfgg8utXT HpzWqavVlaTR0iUQppps9gWEKkgpcax0f4m7lbmkGqjbIgAdTzixrRhjhSP2tuM7Bt38 Rgql0Yc8Bq1o+bQpmV9ZYdrIq/66JNpoh2rPVPZRb7p5HQsbGHyFLaZmpbN34okh6Puv 3deifgB33Ea0DZZak7aXfJJVbc0tzZ9ozbJ/OVen9ywWYnkk9J7l9jKm3uQEP+W8J8Tk WDg701JBkp+zgN43I5YA0ToLb81TZCMJR3OiUlgVbZ/+GgvmInV1CNGfgPGfV6+IVFn4 El5A== X-Gm-Message-State: ABuFfoiqUswcUJmLKHn6hPdCvKKZYvLeyqrCt1qxsLwcy8fVLpBrmYBT Pd7TcH54DXRmIHZ9ZKJVpSXwQA== X-Google-Smtp-Source: ACcGV63NTJo6Rx9tixvlu5Kddgj11gRvpf8YY3SfeA0sN372eQJ/lnS6OKqmSZ7rbYxCz0x6U4A38w== X-Received: by 2002:a5d:5601:: with SMTP id l1-v6mr16552993wrv.209.1538994511659; Mon, 08 Oct 2018 03:28:31 -0700 (PDT) Received: from dhcp-10-192-206-197.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id 143-v6sm12674897wmv.6.2018.10.08.03.28.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Oct 2018 03:28:31 -0700 (PDT) From: Selvin Xavier To: dledford@redhat.com, jgg@mellanox.com Cc: linux-rdma@vger.kernel.org, Selvin Xavier Subject: [PATCH rdma-next 01/13] RDMA/bnxt_re: Add missing spin lock initialization Date: Mon, 8 Oct 2018 03:27:52 -0700 Message-Id: <1538994484-21390-2-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1538994484-21390-1-git-send-email-selvin.xavier@broadcom.com> References: <1538994484-21390-1-git-send-email-selvin.xavier@broadcom.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add the missing initalization of the cq_lock and qplib.flush_lock. Fixes: 942c9b6ca8de ("RDMA/bnxt_re: Avoid Hard lockup during error CQE processing") Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 + drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index bc2b9e0..bea8318 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -2664,6 +2664,7 @@ struct ib_cq *bnxt_re_create_cq(struct ib_device *ibdev, nq->budget++; atomic_inc(&rdev->cq_count); + spin_lock_init(&cq->cq_lock); if (context) { struct bnxt_re_cq_resp resp; diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index 6eaa4b2..e141689 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -1966,6 +1966,7 @@ int bnxt_qplib_create_cq(struct bnxt_qplib_res *res, struct bnxt_qplib_cq *cq) INIT_LIST_HEAD(&cq->sqf_head); INIT_LIST_HEAD(&cq->rqf_head); spin_lock_init(&cq->compl_lock); + spin_lock_init(&cq->flush_lock); bnxt_qplib_arm_cq_enable(cq); return 0;