From patchwork Mon Oct 8 10:27:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 10630355 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7C1F91867 for ; Mon, 8 Oct 2018 10:28:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEF3A288C5 for ; Mon, 8 Oct 2018 10:28:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B3595288CD; Mon, 8 Oct 2018 10:28:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67ACC288C5 for ; Mon, 8 Oct 2018 10:28:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726712AbeJHRjs (ORCPT ); Mon, 8 Oct 2018 13:39:48 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55141 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbeJHRjs (ORCPT ); Mon, 8 Oct 2018 13:39:48 -0400 Received: by mail-wm1-f66.google.com with SMTP id r63-v6so7603419wma.4 for ; Mon, 08 Oct 2018 03:28:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M0jp7IVF46Mhs6p/zEBdJ1jJCvLhlO3m21lfT2qHEuE=; b=N7zR1P6uPMVe7P5sQvuBxR6Ne25J+VT3hORwpVtL3Up9zAtDLYOgOfaeQHlQL8ybR6 M85Q+rEBYMBvRBLk9ciMmyRuhqyYJ5hvJutpLWxgyYmRB7dIdVEdYNQ3ofRJrxm6uQyK WpznU4Q/52ZOLLEqgHEW+7/jrKvif92ZdIgBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M0jp7IVF46Mhs6p/zEBdJ1jJCvLhlO3m21lfT2qHEuE=; b=mHhKcD5Nug3P7ep3hyYfhUW2YiJzQPd9CMMYKLc0gj6weQIvXBweqadh+J3ZVcZFnB hPpV1qa8dQ5OxJClzo+9LnQhkR9zgonOC+EPaRou7KkRAbOykcsZmnHnnVI5hTLCPhyd ZtUPEYNTzHeLnJx+hFFVmqNvhVE6Pn8va8WOY8DfU5CAeWXDgwWpV8RRPz7OkM221//8 nSylwk0Q6CasSE2SGDDKwCd6ew03ycZEDAfbDn7tf2LwBZayblCNPhtX/9SGxlVPqulh QwgjAewmXJKUYsNyTTlmdwxElqpcQmeLOOAt507X9UHq/jzuJ3wJWe0C0ozaObLmAgq/ hsig== X-Gm-Message-State: ABuFfojpuix+qwpiWxEtd7lDpHG99SkdsVL3I4CRs3SO0ANBSZBvFHLL OiLINbQ7zZ8EVTP9g4v8l9lHWtCWkLM= X-Google-Smtp-Source: ACcGV63LPGgaz8j4lXn103f6mcRhcVNP37Jz6Ik9A60x5HoR2OO9Y5SlUzPxypn8y6urvXNwubOyaw== X-Received: by 2002:a1c:7913:: with SMTP id l19-v6mr3522883wme.84.1538994525751; Mon, 08 Oct 2018 03:28:45 -0700 (PDT) Received: from dhcp-10-192-206-197.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id 143-v6sm12674897wmv.6.2018.10.08.03.28.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Oct 2018 03:28:45 -0700 (PDT) From: Selvin Xavier To: dledford@redhat.com, jgg@mellanox.com Cc: linux-rdma@vger.kernel.org, Selvin Xavier , dan.carpenter@oracle.com Subject: [PATCH rdma-next 05/13] RDMA/bnxt_re: Avoid accessing nq->bar_reg_iomem in failure case Date: Mon, 8 Oct 2018 03:27:56 -0700 Message-Id: <1538994484-21390-6-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1538994484-21390-1-git-send-email-selvin.xavier@broadcom.com> References: <1538994484-21390-1-git-send-email-selvin.xavier@broadcom.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In the failure path, nq->bar_reg_iomem gets accessed without initializing. Avoid this by calling the bnxt_qplib_nq_stop_irq only if the initialization is complete. Reported-by: Dan Carpenter Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") Fixes: 6e04b1035689 ("RDMA/bnxt_re: Fix broken RoCE driver due to recent L2 driver changes") Signed-off-by: Selvin Xavier Cc: dan.carpenter@oracle.com --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index e141689..b98b054 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -358,7 +358,8 @@ void bnxt_qplib_disable_nq(struct bnxt_qplib_nq *nq) } /* Make sure the HW is stopped! */ - bnxt_qplib_nq_stop_irq(nq, true); + if (nq->requested) + bnxt_qplib_nq_stop_irq(nq, true); if (nq->bar_reg_iomem) iounmap(nq->bar_reg_iomem);