| Message ID | 1546861016-12624-1-git-send-email-galpress@amazon.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | f687ccea10d23a9b0faed67ceac535b76604669a |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [rdma-rc] RDMA/uverbs: Fix post send success return value in case of error | expand |
On Mon, Jan 07, 2019 at 01:36:56PM +0200, Gal Pressman wrote: > If get QP object fails 'ret' must be assigned with a proper error code. > > Fixes: 9a0738575f26 ("RDMA/uverbs: Use uverbs_response() for remaining response copying") > Signed-off-by: Gal Pressman <galpress@amazon.com> > --- > drivers/infiniband/core/uverbs_cmd.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied to for-rc, thanks Jason
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c index 6b12cc5f97b2..1b82cb74276c 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -2012,8 +2012,10 @@ static int ib_uverbs_post_send(struct uverbs_attr_bundle *attrs) return -ENOMEM; qp = uobj_get_obj_read(qp, UVERBS_OBJECT_QP, cmd.qp_handle, attrs); - if (!qp) + if (!qp) { + ret = -EINVAL; goto out; + } is_ud = qp->qp_type == IB_QPT_UD; sg_ind = 0;
If get QP object fails 'ret' must be assigned with a proper error code. Fixes: 9a0738575f26 ("RDMA/uverbs: Use uverbs_response() for remaining response copying") Signed-off-by: Gal Pressman <galpress@amazon.com> --- drivers/infiniband/core/uverbs_cmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)