From patchwork Mon Nov 30 13:13:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 11940447 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MIME_HEADER_CTYPE_ONLY, MIME_NO_TEXT,SPF_HELO_NONE,SPF_PASS,T_TVD_MIME_NO_HEADERS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D48C64E7B for ; Mon, 30 Nov 2020 13:14:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0ED9B20708 for ; Mon, 30 Nov 2020 13:14:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="gq6rfuxk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726007AbgK3NO3 (ORCPT ); Mon, 30 Nov 2020 08:14:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgK3NO3 (ORCPT ); Mon, 30 Nov 2020 08:14:29 -0500 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE54AC0613CF for ; Mon, 30 Nov 2020 05:13:48 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id x24so10368318pfn.6 for ; Mon, 30 Nov 2020 05:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=Fe63wMSZpfDRjhYy5co8snhmZ0wn7pAobd/fYnUiTjA=; b=gq6rfuxkpp3XYADRD6Sr0fl/9PChhZOQh9qjzNZ1uwQ9UYeZimWOzOfA5MbdoFboPv DxK5g8TivuArvvNLoaiXAnvmWSQ1qBS9gKXsTdGav+RfIUbgXyrEQPL0MQGNexrXcDvk XBJCZe+N/ZMwlvzigQPl2VZZZEDj+vSIyg614= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Fe63wMSZpfDRjhYy5co8snhmZ0wn7pAobd/fYnUiTjA=; b=iq7JGqV8cMzAmkO5qiTk+rDRd203BZbDG6nP9uGfzd/ueneLysShI7ON8PfFlWLmNa jc3awoZAQQxFIA/RwM+VMrtaEDIWZDZnnfP/yE1y9lej60LeP0CRpzJstzbwuG/ha09+ 1gEnkYG++RJ2js2/UU84VlDrFwG3rzp2lVp0o861JKkPmNmi427eLUa774KNSXXIZHbS KGMhUYNPtk0bGsip9q77fWhT84cQ0CjJ+LRpYBonnuH38Eq5xy9Pzm31Nb3ttOQQ3ECV Ltp3ueYjXTZs/Y8gOSTtcoNyJJYjV2isP9ODFTANbFNrOWrASD9xA6eDxVt7xclnaA/6 Yqsg== X-Gm-Message-State: AOAM530To0w4Yr+a1A3mGec0KG9CrA8uz+nWWze6Vm+B17A2hArMr6gq miXpFem25382BTDokTyvEsHcGsgCTPPzN6UriIviiU8bXGzbwrW0VYN3KYmFu38AmmdA6oF78u6 FGOlKxkGcDAfIVvOU1Bo5uTgqUip+BnI0ihO1u4FnOs95A0RypGg7sa00CQzq9hsqssrYGt+AP+ UedP83ErLz X-Google-Smtp-Source: ABdhPJzsJc/26880a2O1IBaGrT3s+BD3pkF1IE4Z1ogs/ZtO5CVzn90AH2uY+T1nT0GgJLH780Xlxg== X-Received: by 2002:a63:4912:: with SMTP id w18mr17877793pga.9.1606742027326; Mon, 30 Nov 2020 05:13:47 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id u7sm3611829pfh.115.2020.11.30.05.13.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Nov 2020 05:13:46 -0800 (PST) From: Selvin Xavier To: linux-rdma@vger.kernel.org Cc: jgg@ziepe.ca, dledford@redhat.com, Selvin Xavier , Devesh Sharma Subject: [PATCH] RDMA/bnxt_re: Fix max_qp_wrs reported Date: Mon, 30 Nov 2020 05:13:06 -0800 Message-Id: <1606741986-16477-1-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org While creating qps, driver adds one extra entry to the sq size passed by the ULPs in order to avoid queue full condition. When ULPs creates QPs with max_qp_wr reported, driver creates QP with 1 more than the max_wqes supported by HW. Create QP fails in this case. To avoid this error, reduce 1 entry in max_qp_wqes and report it to the stack. Signed-off-by: Devesh Sharma Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/qplib_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c index e865690..6c6a9d2 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c @@ -118,7 +118,7 @@ int bnxt_qplib_get_dev_attr(struct bnxt_qplib_rcfw *rcfw, * 128 WQEs needs to be reserved for the HW (8916). Prevent * reporting the max number */ - attr->max_qp_wqes -= BNXT_QPLIB_RESERVED_QP_WRS; + attr->max_qp_wqes -= (BNXT_QPLIB_RESERVED_QP_WRS + 1); attr->max_qp_sges = bnxt_qplib_is_chip_gen_p5(rcfw->res->cctx) ? 6 : sb->max_sge; attr->max_cq = le32_to_cpu(sb->max_cq);