From patchwork Thu May 11 07:26:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13237591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81FD9C7EE22 for ; Thu, 11 May 2023 07:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237387AbjEKHin (ORCPT ); Thu, 11 May 2023 03:38:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237437AbjEKHik (ORCPT ); Thu, 11 May 2023 03:38:40 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C01782107 for ; Thu, 11 May 2023 00:38:38 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id 41be03b00d2f7-5304913530fso2229183a12.0 for ; Thu, 11 May 2023 00:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1683790718; x=1686382718; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=qE/ig7Oj+U2B4ACzH5TZrpaS7kUAoNYL1hBk5YrJ3Qw=; b=NvraUyo3UwQY0iVS6zl9KllHMwB6eVVZbB3RMuj21iJ6jMGIRneFnSALFgRgeUMcXg nrHXFAK4C8z2A5YFk34UfCMY799VwfkUD9iUCGcMLtEgQLcwUNefgrzgQlHu0Zub/xej XEPo6jRR19umMZOQj0NfXbHPl3dZSqk/q/Mng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683790718; x=1686382718; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qE/ig7Oj+U2B4ACzH5TZrpaS7kUAoNYL1hBk5YrJ3Qw=; b=Z5kWlR3qSAEZ+RXHgTsHEOLrgTQ9GMHg2PoOn0EcL95qYxUGqv8MFaD6K4MTvMS8tg MB3ANO4KTRGaUTB6Ar/5TRXqDJHxqCPuftbCuM1s/n9BMqYGSds8y1OIDa8GRQo5MzsL dWTd2wEQh0FWVaZ1udONv3/CvUPDmegJmtwbX457WYOlcP+k9NyynQagTO015hOZZYDJ fuiduZvWRZ0dbF4+Sca2aVHoydGyyUhZyqKnpPCGd+4UcICbwCtV6lt3MDluxdT7lacJ nn6Vk3XszbUenk12XUc1SgVL7PycOUB66Ha1U47Gi1OIyE4xLBaIMpGFgys2R68Kd2NB coeA== X-Gm-Message-State: AC+VfDy+Dr5MXAWpZ7RNEJUIbjhtaQk6yG2xee1j9y4M3Uo1ZH+Ol0dM 0zsFE6OAtxIgTZBGMzjoC69XDzo7CPLP6GY6TIE= X-Google-Smtp-Source: ACHHUZ6TkjtB9XDyDy0ylWy5RQli+C69V0JtihGMjFe9x8fuHVg14DMlslm+PoKxgHH2ITO8i1ZDMw== X-Received: by 2002:a17:90b:506:b0:24d:df69:5c67 with SMTP id r6-20020a17090b050600b0024ddf695c67mr21432697pjz.12.1683790717916; Thu, 11 May 2023 00:38:37 -0700 (PDT) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id n14-20020a65488e000000b00502f4c62fd3sm4174332pgs.33.2023.05.11.00.38.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 May 2023 00:38:37 -0700 (PDT) From: Selvin Xavier To: jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Selvin Xavier Subject: [PATCH for-rc 07/10] RDMA/bnxt_re: Fix to remove an unnecessary log Date: Thu, 11 May 2023 00:26:22 -0700 Message-Id: <1683789985-22917-8-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1683789985-22917-1-git-send-email-selvin.xavier@broadcom.com> References: <1683789985-22917-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Kalesh AP During destroy_qp, driver sets the qp handle in the existing CQEs belonging to the QP being destroyed to NULL. As a result, a poll_cq after destroy_qp can report unnecessary messages. Remove this noise from system logs. Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index 607ed69..55f092c 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -2799,11 +2799,8 @@ static int bnxt_qplib_cq_process_terminal(struct bnxt_qplib_cq *cq, qp = (struct bnxt_qplib_qp *)((unsigned long) le64_to_cpu(hwcqe->qp_handle)); - if (!qp) { - dev_err(&cq->hwq.pdev->dev, - "FP: CQ Process terminal qp is NULL\n"); + if (!qp) return -EINVAL; - } /* Must block new posting of SQ and RQ */ qp->state = CMDQ_MODIFY_QP_NEW_STATE_ERR;