From patchwork Fri May 19 06:48:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13247725 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31946C7EE2A for ; Fri, 19 May 2023 07:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229999AbjESHAN (ORCPT ); Fri, 19 May 2023 03:00:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230048AbjESHAM (ORCPT ); Fri, 19 May 2023 03:00:12 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461A0E6B for ; Fri, 19 May 2023 00:00:11 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1ae4be0b1f3so21620585ad.0 for ; Fri, 19 May 2023 00:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1684479610; x=1687071610; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=v/lYEBI3JXhP06tCTRGvwVBjmwlug5wbwRj3jZeRhb0=; b=AoGZiMd2JASsUpwOvakZE5+zcf0beOHEBaHKQHMP4astqJhDheNJmIUTxMYByBJV+1 sk9Spwo0+XoAoOv92Tbuf0rg0DEzqLFWZpA6GgRhikLkI/ABYRMF8kJ38vgX6weTKp3B dV4NRChd9yRB+DxBGkV/Y5aRl7PkWl5kB/0mA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684479610; x=1687071610; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v/lYEBI3JXhP06tCTRGvwVBjmwlug5wbwRj3jZeRhb0=; b=e4l6jbPsIjv9B7y+RiNALhDQ3cvjnRM9E5g9lDe1xLTVRX91Lcitr6hZLp17NwVfEW JQSRLUCLFxxXVDrjkPGBBh3SLk1NRfLYugZxwZiqgEJ4PdpW9lzkHFsOtESVScIDGdEx nky7BPVZD5Ko0tVJh1NYQ2F21qKwIX1JscBRd1X+SXLQbsrwVqHselyAPws50n4x6UOH BrZbjtwkesHpELHnSWbTIsvDBy77RuV7zw58YiyLvBIodNmrBxDBTNKrrnbukdhQXJu4 dlS1Ul5OyMTSJexSpVcEPbX8UgOcvB+nID7wb9RbCwxYt3AU7/AdgsWDQH836ltqA3RV 5ldQ== X-Gm-Message-State: AC+VfDzD1Y3fbcwXwxLRepeqRmJejVdbjP7UlcK1Xpq+gNQtlj2LPr++ KakAjvjcf8GAH14n/Os28uGOzA== X-Google-Smtp-Source: ACHHUZ7ln85itUBbOJdB3CsrX8KWxZM8X2XDypl9fj/AdUB3oNNGZ9+irrIINBCnTQvyCwuZj9bgPw== X-Received: by 2002:a17:903:26cc:b0:1ac:5def:d203 with SMTP id jg12-20020a17090326cc00b001ac5defd203mr1563505plb.35.1684479610623; Fri, 19 May 2023 00:00:10 -0700 (PDT) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id ju19-20020a170903429300b001a64c4023aesm2654279plb.36.2023.05.19.00.00.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2023 00:00:09 -0700 (PDT) From: Selvin Xavier To: jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Selvin Xavier Subject: [PATCH for-next 5/7] RDMA/bnxt_re: Fix to remove an unnecessary log Date: Thu, 18 May 2023 23:48:15 -0700 Message-Id: <1684478897-12247-6-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1684478897-12247-1-git-send-email-selvin.xavier@broadcom.com> References: <1684478897-12247-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Kalesh AP During destroy_qp, driver sets the qp handle in the existing CQEs belonging to the QP being destroyed to NULL. As a result, a poll_cq after destroy_qp can report unnecessary messages. Remove this noise from system logs. Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/qplib_fp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c index ff33d77..e695abae 100644 --- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c +++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c @@ -2798,11 +2798,8 @@ static int bnxt_qplib_cq_process_terminal(struct bnxt_qplib_cq *cq, qp = (struct bnxt_qplib_qp *)((unsigned long) le64_to_cpu(hwcqe->qp_handle)); - if (!qp) { - dev_err(&cq->hwq.pdev->dev, - "FP: CQ Process terminal qp is NULL\n"); + if (!qp) return -EINVAL; - } /* Must block new posting of SQ and RQ */ qp->state = CMDQ_MODIFY_QP_NEW_STATE_ERR;