From patchwork Thu Aug 3 08:45:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13339558 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4304C001DF for ; Thu, 3 Aug 2023 08:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234172AbjHCI5P (ORCPT ); Thu, 3 Aug 2023 04:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234872AbjHCI5O (ORCPT ); Thu, 3 Aug 2023 04:57:14 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1034E46 for ; Thu, 3 Aug 2023 01:57:11 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6877eb31261so483570b3a.1 for ; Thu, 03 Aug 2023 01:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1691053031; x=1691657831; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=C9q4tNmpiSKicNm1oBStbQYm6KUUkUzCJ9aVUTBqt+U=; b=YpOAvR3fudLo5Cfc2BJoWdfXCyPkBtcV/wOXXfjUsmw9/4f+W8H6aJN7RdnmyDOBcp lOxcdPY8YpzvP/RiwDxZ7VHrItXRg1xjCec1sBDsgoYpucEnULwfbJJieau6bqGzAa5l FvaWFpSPcog4QhJsYAqDakcmQcv3kHQIgxPEI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691053031; x=1691657831; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C9q4tNmpiSKicNm1oBStbQYm6KUUkUzCJ9aVUTBqt+U=; b=D7zCizgYC7LraGz0UUolXDcnujrYpRfUuhp2+0YTZUSpbgR2bAwQoPoKuuyzDx98RZ Og5aWlB2bGt1DPJX30Tg3cUUsSQyDAgpEu1dqptu9Nt6gH7PmrQ+rmudGBg/jUmBJBAt LnziGpdyD9qVYPc60NG6NQiAwnZQ0fZLQ6wIrAfjFxMlukGhlukWPiUHduVXp+hhGmB8 aMvj37NpcBNQdtOYqRDWMR1abQL9SlIkzTyrSXZVIWZ+mLahfwHFUmrpjSkSBJ7OTWKa o5bDH21mvFV3S+p6yG0DzzsS8xreCCf1tyrk6ifvCDIesqEQGghb/UaltfLn58clSHqj /T0w== X-Gm-Message-State: ABy/qLZFGINl4M2EYyElZ68KknacIwCt9tjabLi3xgXAuukvFYVkHo/n xCtLX9ssOO14woIZs1c7IcifLw== X-Google-Smtp-Source: APBJJlGhZJU0WOXAkYS+xKNQQf6rNkXogFMDAnM54DMjZ0Ib+IQIhUrtNXdJiXCWZm6MKltQMEsANA== X-Received: by 2002:a05:6a20:7d99:b0:13f:4e70:ad48 with SMTP id v25-20020a056a207d9900b0013f4e70ad48mr2175874pzj.52.1691053031144; Thu, 03 Aug 2023 01:57:11 -0700 (PDT) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id x42-20020a056a000bea00b0068713008f98sm10289035pfu.129.2023.08.03.01.57.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Aug 2023 01:57:10 -0700 (PDT) From: Selvin Xavier To: jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Selvin Xavier Subject: [PATCH for-next v2 2/6] RDMA/bnxt_re: Remove a redundant flag Date: Thu, 3 Aug 2023 01:45:22 -0700 Message-Id: <1691052326-32143-3-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1691052326-32143-1-git-send-email-selvin.xavier@broadcom.com> References: <1691052326-32143-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Kalesh AP After the cited commit, BNXT_RE_FLAG_GOT_MSIX is redundant. Remove it. Fixes: 303432211324 ("bnxt_en: Remove runtime interrupt vector allocation") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/bnxt_re.h | 1 - drivers/infiniband/hw/bnxt_re/main.c | 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/bnxt_re.h b/drivers/infiniband/hw/bnxt_re/bnxt_re.h index 03a1325..9fd9849 100644 --- a/drivers/infiniband/hw/bnxt_re/bnxt_re.h +++ b/drivers/infiniband/hw/bnxt_re/bnxt_re.h @@ -140,7 +140,6 @@ struct bnxt_re_dev { struct list_head list; unsigned long flags; #define BNXT_RE_FLAG_NETDEV_REGISTERED 0 -#define BNXT_RE_FLAG_GOT_MSIX 2 #define BNXT_RE_FLAG_HAVE_L2_REF 3 #define BNXT_RE_FLAG_RCFW_CHANNEL_EN 4 #define BNXT_RE_FLAG_QOS_WORK_REG 5 diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index bbda694..2fe47b3 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1422,8 +1422,8 @@ static void bnxt_re_dev_uninit(struct bnxt_re_dev *rdev) bnxt_re_net_ring_free(rdev, rdev->rcfw.creq.ring_id, type); bnxt_qplib_free_rcfw_channel(&rdev->rcfw); } - if (test_and_clear_bit(BNXT_RE_FLAG_GOT_MSIX, &rdev->flags)) - rdev->num_msix = 0; + + rdev->num_msix = 0; if (rdev->pacing.dbr_pacing) bnxt_re_deinitialize_dbr_pacing(rdev); @@ -1480,7 +1480,6 @@ static int bnxt_re_dev_init(struct bnxt_re_dev *rdev, u8 wqe_mode) ibdev_dbg(&rdev->ibdev, "Got %d MSI-X vectors\n", rdev->en_dev->ulp_tbl->msix_requested); rdev->num_msix = rdev->en_dev->ulp_tbl->msix_requested; - set_bit(BNXT_RE_FLAG_GOT_MSIX, &rdev->flags); bnxt_re_query_hwrm_intf_version(rdev);