From patchwork Tue Jan 23 04:54:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Selvin Xavier X-Patchwork-Id: 13526832 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C6422119 for ; Tue, 23 Jan 2024 05:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986671; cv=none; b=RL4VzUHm71xkYihFGGx5Ipl0W+K82+hRYK54abzrNRVdt+TXFLNRMapVxgAR7m/f93I0MGY2rYpXTK+Grj+fu89gbCRlkzXiRu+67Oeb9reckl2tLrWQC3EqrlfUFx2al+Z4SEB3CP3lTM3Pvt1qSy2xthrASfS1SGWMAZTDrXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705986671; c=relaxed/simple; bh=U2AgML8H2hIWUHMt2OIgaQL/CiN4LEZc47uM1w5Dm6w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type; b=m0JzATGrv86urYDR1/2uE/oDrSL42CfexKVMAQFybrJzWa+aBMNQ7pNNUo8X86AEj893+7T68xULFan4wriH9/hYLDaAUs1n6YqiYsNTkYdjw/Ih4c3YTQwSmehqshwmtfktHDUD/zH5i3Y5NYhOiG3IfApmIuQF18cjut1MUtY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=G/RTZfdw; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="G/RTZfdw" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3bd562d17dcso3238815b6e.3 for ; Mon, 22 Jan 2024 21:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1705986669; x=1706591469; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=s3Pc2trzbgVJp5Sv1YqQCLIEKgAJYxLyXuRbWRoja6E=; b=G/RTZfdw04d/Npo6+3oxVGFsyn6DEM6UzDhUCbijXzA9FSNLw0MtdcFG81wIU4K/ub A44ZKwsojZI1a6viuYQHAzy4LcE/NQZJgkI1YXlv5ktuVlCf7k7OWOwYfJLITsGcZ053 zbR8EwgwzynLAdvlWogybjxON3d7VQR0PKw0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705986669; x=1706591469; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s3Pc2trzbgVJp5Sv1YqQCLIEKgAJYxLyXuRbWRoja6E=; b=BW3weZj6jgv/CrMP4X9JTQKlIXTvLv49Etlo4uEwiyzYij+EBohjIR/kw1f50eklm8 2evIsIbbI5XFX859WUdkrCYC0RvIhvmjaEOeOoMPp4D0SY031CRkZDpTctrsRBrleWHf 5da9yM3ZUjQawlIRCBLn9s48rW9c9+e51Xf3ycDXKI+r61QpYLRlK2haRZQb1I9DJFY8 sc+bH6FWz2WLZONJBV3ofwmBVS+SvE8iH2iT26VlDv7wF6zOKx4qLMzJ9qm12QYpyrqs TNjEhqSJsq2m3oXqoOKEFgPvkEbEg+1csBRZ+Akp9D/D5M6xTv4gCgxtiKiT/QYOt3pt WueQ== X-Gm-Message-State: AOJu0YyL0MHv3CPI4a/uOxYe+YdUWfF5zw7B2JrLrbRzJzqgFZ7gMqpx rXisges/5PGUKEBTPKjjVDjgY7wgMgziz2vWZkEGdex1fXGbO4f5o2nCnWYqtQ== X-Google-Smtp-Source: AGHT+IE8wDh1Br9cJAs6DGOt/gbUcLC49H3dfU9CncLUN48lKYAkC3w1WGm3GS9oO0dSwVUoq2wRYg== X-Received: by 2002:a05:6808:d4a:b0:3bd:c44d:da0e with SMTP id w10-20020a0568080d4a00b003bdc44dda0emr684929oik.108.1705986669206; Mon, 22 Jan 2024 21:11:09 -0800 (PST) Received: from dhcp-10-192-206-197.iig.avagotech.net.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id lp4-20020a056a003d4400b006dce766903dsm672949pfb.90.2024.01.22.21.11.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2024 21:11:08 -0800 (PST) From: Selvin Xavier To: leon@kernel.org, jgg@ziepe.ca Cc: linux-rdma@vger.kernel.org, andrew.gospodarek@broadcom.com, Kalesh AP , Selvin Xavier Subject: [PATCH for-rc 4/5] RDMA/bnxt_re: Return error for SRQ resize Date: Mon, 22 Jan 2024 20:54:36 -0800 Message-Id: <1705985677-15551-5-git-send-email-selvin.xavier@broadcom.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> References: <1705985677-15551-1-git-send-email-selvin.xavier@broadcom.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Kalesh AP SRQ resize is not supported in the driver. But driver is not returning error from bnxt_re_modify_srq() for SRQ resize. Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters") Signed-off-by: Kalesh AP Signed-off-by: Selvin Xavier --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index fdb4fde..ce9c5ba 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1827,7 +1827,7 @@ int bnxt_re_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr, switch (srq_attr_mask) { case IB_SRQ_MAX_WR: /* SRQ resize is not supported */ - break; + return -EINVAL; case IB_SRQ_LIMIT: /* Change the SRQ threshold */ if (srq_attr->srq_limit > srq->qplib_srq.max_wqe) @@ -1842,13 +1842,12 @@ int bnxt_re_modify_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr, /* On success, update the shadow */ srq->srq_limit = srq_attr->srq_limit; /* No need to Build and send response back to udata */ - break; + return 0; default: ibdev_err(&rdev->ibdev, "Unsupported srq_attr_mask 0x%x", srq_attr_mask); return -EINVAL; } - return 0; } int bnxt_re_query_srq(struct ib_srq *ib_srq, struct ib_srq_attr *srq_attr)