From patchwork Mon Jan 20 17:27:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konstantin Taranov X-Patchwork-Id: 13945403 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F3E81EE7A1; Mon, 20 Jan 2025 17:27:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737394054; cv=none; b=miujQfoaasHDPAh2LkwMlr3LKfDIG4gSINmRfvvTG8qD/Lm/UX9E7n6+Ivq14m5J+nSjfRMOgn06a1C8BHItka7lORb0Ox4acniDpF850iv3eMQz7bdLH0ZbYy+Ds6iqoZM+9OcXCF1hA201zC2gm+oUAEJHB6/ZBPQmXiqTh2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737394054; c=relaxed/simple; bh=zyvWJfU+VD+5jShb6kQWiBoF/AbzAYlzIv7tUwhNXoQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=icj/Wm3JX+FyBYq7e0G4OMgKr0QHoO0JZJ2Rv0x76Dc8K+YD1lekPpXmHuWcd6KyCwugznjyiY2WKZqhFidDUxXjJzCobEuACo/Df7Gz2CQLe4fwtNI/H3erjMYyGSZEFvidhvH44BQZrMlvHN6JEBG/EC2uXPBVNlwLCsUdyDs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=QkgDshjB; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="QkgDshjB" Received: from linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net (linux.microsoft.com [13.77.154.182]) by linux.microsoft.com (Postfix) with ESMTPSA id 615FE205A9CE; Mon, 20 Jan 2025 09:27:26 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 615FE205A9CE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1737394046; bh=E9YsxzL8NQza6Vhl7MjU359dvF64cn5FlJw09fYmMaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QkgDshjBHx/b/psps5f8rlt/1/QEpFaaVqdkGlIPFw9v751nibIFi4hfh+pVvbLVZ EFbQ7D+sPWxMnN8NyI/uw7hzAdtLYxLEj0SQS2LH3YWWNwZ70zFJSVz+NsU9KwydOW vr37nZRcf5sYZQ2zblO1Hxh9+kYiBcjPOd+GPQZc= From: Konstantin Taranov To: kotaranov@microsoft.com, shirazsaleem@microsoft.com, pabeni@redhat.com, haiyangz@microsoft.com, kys@microsoft.com, edumazet@google.com, kuba@kernel.org, davem@davemloft.net, decui@microsoft.com, wei.liu@kernel.org, sharmaajay@microsoft.com, longli@microsoft.com, jgg@ziepe.ca, leon@kernel.org Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: [PATCH rdma-next 08/13] net/mana: fix warning in the writer of client oob Date: Mon, 20 Jan 2025 09:27:14 -0800 Message-Id: <1737394039-28772-9-git-send-email-kotaranov@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1737394039-28772-1-git-send-email-kotaranov@linux.microsoft.com> References: <1737394039-28772-1-git-send-email-kotaranov@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Konstantin Taranov Do not warn on missing pad_data when oob is in sgl. Signed-off-by: Konstantin Taranov Reviewed-by: Shiraz Saleem --- drivers/net/ethernet/microsoft/mana/gdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microsoft/mana/gdma_main.c b/drivers/net/ethernet/microsoft/mana/gdma_main.c index 3cb0543..a8a9cd7 100644 --- a/drivers/net/ethernet/microsoft/mana/gdma_main.c +++ b/drivers/net/ethernet/microsoft/mana/gdma_main.c @@ -1042,7 +1042,7 @@ static u32 mana_gd_write_client_oob(const struct gdma_wqe_request *wqe_req, header->inline_oob_size_div4 = client_oob_size / sizeof(u32); if (oob_in_sgl) { - WARN_ON_ONCE(!pad_data || wqe_req->num_sge < 2); + WARN_ON_ONCE(wqe_req->num_sge < 2); header->client_oob_in_sgl = 1;