| Message ID | 1e9f55943699dcc2bc921000ee7ee5353cbf7480.1535742195.git.swise@opengridcomputing.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | cxgb4: fix abort_req_rss6 struct | expand |
From: Steve Wise <swise@opengridcomputing.com> Date: Fri, 31 Aug 2018 11:52:00 -0700 > Remove the incorrect WR_HDR field which can cause a misinterpretation > of this CPL by ULDs. > > Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") > Signed-off-by: Steve Wise <swise@opengridcomputing.com> > --- > > Dave, Doug, and Jason, > > I request this merge through the rdma repo since the only user of this > structure is iw_cxgb4. No objections from me.
On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: > Remove the incorrect WR_HDR field which can cause a misinterpretation > of this CPL by ULDs. What does that mean? Is this an -rc patch? Jason
(sorry for the late reply, I was out all last week) On 9/5/2018 5:55 PM, Jason Gunthorpe wrote: > On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: >> Remove the incorrect WR_HDR field which can cause a misinterpretation >> of this CPL by ULDs. > > What does that mean? > It means iw_cxgb4 doesn't correctly handle incoming ABORT CPL messages due to this incorrect struct. > Is this an -rc patch? > Yes. Since it fixes a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") which went into 4.19. Steve.
On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote: > Remove the incorrect WR_HDR field which can cause a misinterpretation > of this CPL by ULDs. > > Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") > Signed-off-by: Steve Wise <swise@opengridcomputing.com> > --- > > Dave, Doug, and Jason, > > I request this merge through the rdma repo since the only user of this > structure is iw_cxgb4. Applied to for-rc, thanks Jason
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h index b8f75a22fb6c..f152da1ce046 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_msg.h @@ -753,7 +753,6 @@ struct cpl_abort_req_rss { }; struct cpl_abort_req_rss6 { - WR_HDR; union opcode_tid ot; __be32 srqidx_status; };
Remove the incorrect WR_HDR field which can cause a misinterpretation of this CPL by ULDs. Fixes: a3cdaa69e4ae ("cxgb4: Adds CPL support for Shared Receive Queues") Signed-off-by: Steve Wise <swise@opengridcomputing.com> --- Dave, Doug, and Jason, I request this merge through the rdma repo since the only user of this structure is iw_cxgb4. --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 - 1 file changed, 1 deletion(-)