From patchwork Tue Apr 13 14:56:35 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Khapyorsky X-Patchwork-Id: 92201 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o3DEuS3B021312 for ; Tue, 13 Apr 2010 14:56:28 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751966Ab0DMO40 (ORCPT ); Tue, 13 Apr 2010 10:56:26 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:34616 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751752Ab0DMO40 (ORCPT ); Tue, 13 Apr 2010 10:56:26 -0400 Received: by bwz19 with SMTP id 19so38492bwz.21 for ; Tue, 13 Apr 2010 07:56:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:date:from:to :cc:subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=k8bDRhrN655MU2s3Dw3ftmBr6jS0PIWpBB+18oWRgy8=; b=CxKhAbCmlWzxhcR62324ywJ08rXVAvULLdNLNfdy1M9zm7Z9mnqrDK8pqb9vxdEiTn BzkcKPz34Pf2Iic7cHPhKREFz4nW0yAceSyrYVdKldWWAvzuEKHtfR9OqNrgnjzJYBgO z/dDqUEWiurnAhr7X5Hp4YP7QQcm+OZsQ/PL0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=FbwLuwHefGk5RFUFbAt6A4SifDcUcO2U8c66gl3xQAr1cVm0VFJQjVbuwY42l6sSgN MATiKXyCaN4Ie6K2i4SZXToHJlZXKxsTdcA0hffNJj98qLJMJmAejA1dxhL0qD2AAesk WnW+d9V4BPf4RTfZbM8NdBoax9SdysdBaqViI= Received: by 10.204.82.36 with SMTP id z36mr6836312bkk.88.1271170584000; Tue, 13 Apr 2010 07:56:24 -0700 (PDT) Received: from me.localdomain (85.64.35.106.dynamic.barak-online.net [85.64.35.106]) by mx.google.com with ESMTPS id l1sm46613737bkl.2.2010.04.13.07.56.22 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 13 Apr 2010 07:56:23 -0700 (PDT) Received: by me.localdomain (Postfix, from userid 1000) id 01EB411F31; Tue, 13 Apr 2010 17:56:35 +0300 (IDT) Date: Tue, 13 Apr 2010 17:56:35 +0300 From: Sasha Khapyorsky To: Ira Weiny Cc: "linux-rdma@vger.kernel.org" , Hal Rosenstock Subject: [PATCH] libibnetdisc: add \n at end of error messages Message-ID: <20100413145635.GL10830@me> References: <20100218124931.4d6ef34b.weiny2@llnl.gov> <20100410005245.GH4808@me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100410005245.GH4808@me> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 13 Apr 2010 14:56:29 +0000 (UTC) diff --git a/infiniband-diags/libibnetdisc/src/chassis.c b/infiniband-diags/libibnetdisc/src/chassis.c index 1a839d9..80e034b 100644 --- a/infiniband-diags/libibnetdisc/src/chassis.c +++ b/infiniband-diags/libibnetdisc/src/chassis.c @@ -378,7 +378,7 @@ static int get_sfb_slot(ibnd_node_t * n, ibnd_port_t * lineport) n->ch_slotnum = spine4_slot_2_slb[lineport->portnum]; n->ch_anafanum = anafa_spine4_slot_2_slb[lineport->portnum]; } else { - IBND_ERROR("Unexpected node found: guid 0x%016" PRIx64, + IBND_ERROR("Unexpected node found: guid 0x%016" PRIx64 "\n", n->guid); return -1; } @@ -419,7 +419,7 @@ static int get_router_slot(ibnd_node_t * n, ibnd_port_t * spineport) n->ch_slotnum = line_slot_2_sfb4[spineport->portnum]; n->ch_anafanum = ipr_slot_2_sfb4_port[spineport->portnum]; } else { - IBND_ERROR("Unexpected node found: guid 0x%016" PRIx64, + IBND_ERROR("Unexpected node found: guid 0x%016" PRIx64 "\n", spineport->node->guid); return -1; } @@ -446,7 +446,7 @@ static int get_slb_slot(ibnd_node_t * n, ibnd_port_t * spineport) n->ch_slotnum = line_slot_2_sfb4[spineport->portnum]; n->ch_anafanum = anafa_line_slot_2_sfb4[spineport->portnum]; } else { - IBND_ERROR("Unexpected node found: guid 0x%016" PRIx64, + IBND_ERROR("Unexpected node found: guid 0x%016" PRIx64 "\n", spineport->node->guid); return -1; } diff --git a/infiniband-diags/libibnetdisc/src/query_smp.c b/infiniband-diags/libibnetdisc/src/query_smp.c index 1ec9752..b4322bc 100644 --- a/infiniband-diags/libibnetdisc/src/query_smp.c +++ b/infiniband-diags/libibnetdisc/src/query_smp.c @@ -71,7 +71,7 @@ static int send_smp(ibnd_smp_t * smp, struct ibmad_port *srcport) if ((rc = mad_build_pkt(umad, &smp->rpc, &smp->path, NULL, NULL)) < 0) { - IBND_ERROR("mad_build_pkt failed; %d", rc); + IBND_ERROR("mad_build_pkt failed; %d\n", rc); return rc; } @@ -80,7 +80,7 @@ static int send_smp(ibnd_smp_t * smp, struct ibmad_port *srcport) umad, IB_MAD_SIZE, mad_get_timeout(srcport, rpc->timeout), mad_get_retries(srcport))) < 0) { - IBND_ERROR("send failed; %d", rc); + IBND_ERROR("send failed; %d\n", rc); return rc; } @@ -109,7 +109,7 @@ int issue_smp(smp_engine_t * engine, ib_portid_t * portid, { ibnd_smp_t *smp = calloc(1, sizeof *smp); if (!smp) { - IBND_ERROR("OOM"); + IBND_ERROR("OOM\n"); return -ENOMEM; }