From patchwork Fri Oct 22 22:57:10 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 278271 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o9MMvEwc019959 for ; Fri, 22 Oct 2010 22:57:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751228Ab0JVW5N (ORCPT ); Fri, 22 Oct 2010 18:57:13 -0400 Received: from quartz.orcorp.ca ([139.142.54.143]:46464 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751184Ab0JVW5N (ORCPT ); Fri, 22 Oct 2010 18:57:13 -0400 Received: from [10.0.0.11] (helo=jggl.edm.orcorp.ca) by quartz.orcorp.ca with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.68) (envelope-from ) id 1P9QXv-000124-3X; Fri, 22 Oct 2010 16:57:11 -0600 Received: from jgg by jggl.edm.orcorp.ca with local (Exim 4.69) (envelope-from ) id 1P9QXu-00011F-W3; Fri, 22 Oct 2010 16:57:11 -0600 Date: Fri, 22 Oct 2010 16:57:10 -0600 From: Jason Gunthorpe To: Ralph Campbell Cc: Roland Dreier , linux-rdma@vger.kernel.org Subject: Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails Message-ID: <20101022225710.GD15514@obsidianresearch.com> References: <20101022222937.28161.50341.stgit@chromite.mv.qlogic.com> <20101022222951.28161.23347.stgit@chromite.mv.qlogic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101022222951.28161.23347.stgit@chromite.mv.qlogic.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.11 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Fri, 22 Oct 2010 22:57:14 +0000 (UTC) diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infiniband/hw/qib/qib_pcie.c index 16ce9e7..2913af2 100644 --- a/drivers/infiniband/hw/qib/qib_pcie.c +++ b/drivers/infiniband/hw/qib/qib_pcie.c @@ -103,9 +103,11 @@ int qib_pcie_init(struct pci_dev *pdev, const struct pci_device_id *ent) ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32)); } else ret = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)); - if (ret) + if (ret) { qib_early_err(&pdev->dev, "Unable to set DMA consistent mask: %d\n", ret); + goto bail; + } pci_set_master(pdev); ret = pci_enable_pcie_error_reporting(pdev);