From patchwork Wed Mar 9 01:28:10 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 620241 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p291SF1j031085 for ; Wed, 9 Mar 2011 01:28:16 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756770Ab1CIB2O (ORCPT ); Tue, 8 Mar 2011 20:28:14 -0500 Received: from quartz.orcorp.ca ([139.142.54.143]:40046 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756764Ab1CIB2O (ORCPT ); Tue, 8 Mar 2011 20:28:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=obsidianresearch.com; s=rsa1; h=Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=o36HNS5jJNQ3cnoDRqXH9cyj4HTJdWE0B7b+AV+VwXk=; b=L6GKqpp+fei9/IT5gfpCkoCCb9UzXwFj9pmbVLuPtUl+dew35bA5c0MxZhwJNiTdIvfwP8y3Xu3xR1OUVRO6gPc736yKvb5bgOU8j9JVsPTzBdJtF3Q+JAwc8JVkFwCnXLxgos2w8UgjUuyW3qmhcq4aWlH+D60PZ5dtHPCGHWk=; Received: from [10.0.0.11] (helo=jggl.edm.orcorp.ca) by quartz.orcorp.ca with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1Px8CA-0005A4-JV; Tue, 08 Mar 2011 18:28:10 -0700 Received: from jgg by jggl.edm.orcorp.ca with local (Exim 4.72) (envelope-from ) id 1Px8CA-0005kk-B3; Tue, 08 Mar 2011 18:28:10 -0700 Date: Tue, 8 Mar 2011 18:28:10 -0700 From: Jason Gunthorpe To: Roland Dreier , "linux-rdma@vger.kernel.org" Subject: [PATCH/libmlx4] Return ERRNO codes from ibv_post_send/recv instead of -1 Message-ID: <20110309012810.GM22729@obsidianresearch.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.11 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 09 Mar 2011 01:28:16 +0000 (UTC) diff --git a/src/qp.c b/src/qp.c index d194ae3..ec138cd 100644 --- a/src/qp.c +++ b/src/qp.c @@ -40,6 +40,7 @@ #include #include #include +#include #include "mlx4.h" #include "doorbell.h" @@ -206,19 +207,19 @@ int mlx4_post_send(struct ibv_qp *ibqp, struct ibv_send_wr *wr, for (nreq = 0; wr; ++nreq, wr = wr->next) { if (wq_overflow(&qp->sq, nreq, to_mcq(qp->ibv_qp.send_cq))) { - ret = -1; + ret = ENOMEM; *bad_wr = wr; goto out; } if (wr->num_sge > qp->sq.max_gs) { - ret = -1; + ret = ENOMEM; *bad_wr = wr; goto out; } if (wr->opcode >= sizeof mlx4_ib_opcode / sizeof mlx4_ib_opcode[0]) { - ret = -1; + ret = EINVAL; *bad_wr = wr; goto out; } @@ -309,7 +310,7 @@ int mlx4_post_send(struct ibv_qp *ibqp, struct ibv_send_wr *wr, if (inl > qp->max_inline_data) { inl = 0; - ret = -1; + ret = ENOMEM; *bad_wr = wr; goto out; } @@ -450,13 +451,13 @@ int mlx4_post_recv(struct ibv_qp *ibqp, struct ibv_recv_wr *wr, for (nreq = 0; wr; ++nreq, wr = wr->next) { if (wq_overflow(&qp->rq, nreq, to_mcq(qp->ibv_qp.recv_cq))) { - ret = -1; + ret = ENOMEM; *bad_wr = wr; goto out; } if (wr->num_sge > qp->rq.max_gs) { - ret = -1; + ret = ENOMEM; *bad_wr = wr; goto out; }