From patchwork Wed Aug 13 09:20:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: HIMANGI SARAOGI X-Patchwork-Id: 4717511 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A1990C0338 for ; Wed, 13 Aug 2014 09:20:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C960F20176 for ; Wed, 13 Aug 2014 09:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02951200D6 for ; Wed, 13 Aug 2014 09:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752268AbaHMJUx (ORCPT ); Wed, 13 Aug 2014 05:20:53 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:62748 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbaHMJUw (ORCPT ); Wed, 13 Aug 2014 05:20:52 -0400 Received: by mail-pd0-f180.google.com with SMTP id v10so12468084pde.11 for ; Wed, 13 Aug 2014 02:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=fPwq30y5/cHhZwG1SzMcIxbKYh3r2K73T8snXS8EiKc=; b=kSJOGtUqtzctLNyK+bULyacVEIl9+Vj2jMzmJTfMvVtsOipM6FbIBmuytMAs9/6xFT xzr/48/1aVLNLAUGcCTmW6jBxLbpNCzY2ZMkxo8egDWDKcfHwy/Cnw3ISU/Skch7ir5B 1ootMH1GlKzCY7gTK5NgRjYfZEMVwd4uNb3lLyVCY5uKqm26mZ9xVHYsTMqiLOxN3h91 fyObyq5ymv/kxCbwOljZ/BJocqChknzYknVgWuIha4LmR7OF+x4UdDuQY5UqxQAjrgD8 kjfnIzQfCRxMbmpUFicBIZlwTUGzoyTz07vGuyTOmEZV3ZcRBLdlxp3mB593c9MZN23o C9Nw== X-Received: by 10.66.172.17 with SMTP id ay17mr137014pac.149.1407921652451; Wed, 13 Aug 2014 02:20:52 -0700 (PDT) Received: from localhost ([14.139.82.6]) by mx.google.com with ESMTPSA id qp12sm2141119pdb.80.2014.08.13.02.20.50 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 13 Aug 2014 02:20:51 -0700 (PDT) Date: Wed, 13 Aug 2014 14:50:47 +0530 From: Himangi Saraogi To: Mike Marciniszyn , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Julia Lawall Subject: [PATCH] IB/qib: Drop unnecessary continue Message-ID: <20140813092047.GA3150@himangi-Dell> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- drivers/infiniband/hw/qib/qib_init.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c index 8d3c78d..3bee93a4 100644 --- a/drivers/infiniband/hw/qib/qib_init.c +++ b/drivers/infiniband/hw/qib/qib_init.c @@ -705,11 +705,9 @@ int qib_init(struct qib_devdata *dd, int reinit) lastfail = qib_create_rcvhdrq(dd, rcd); if (!lastfail) lastfail = qib_setup_eagerbufs(rcd); - if (lastfail) { + if (lastfail) qib_dev_err(dd, "failed to allocate kernel ctxt's rcvhdrq and/or egr bufs\n"); - continue; - } } for (pidx = 0; pidx < dd->num_pports; ++pidx) {