diff mbox

IB/hfi1: Add Infiniband dependency to Kconfig

Message ID 20150804161652.24483.80145.stgit@phlsvslse11.ph.intel.com (mailing list archive)
State Accepted
Headers show

Commit Message

Marciniszyn, Mike Aug. 4, 2015, 4:16 p.m. UTC 
From: Jubin John <jubin.john@intel.com>

The hfi1 driver depends on the infiniband core stack.
Building a kernel without the infiniband core but with the
hfi1 driver causes undefined reference errors to the ib_* functions.

Reported by 0-day build:
https://lists.01.org/pipermail/kbuild-all/2015-August/011216.html

This is a temporary patch and is only needed while the hfi1 driver is
in staging. Remove when moving driver back to drivers/infiniband.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Jubin John <jubin.john@intel.com>
---
 drivers/staging/hfi1/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Doug Ledford Aug. 14, 2015, 8:56 p.m. UTC | #1 
On 08/04/2015 12:16 PM, Mike Marciniszyn wrote:
> From: Jubin John <jubin.john@intel.com>
> 
> The hfi1 driver depends on the infiniband core stack.
> Building a kernel without the infiniband core but with the
> hfi1 driver causes undefined reference errors to the ib_* functions.
> 
> Reported by 0-day build:
> https://lists.01.org/pipermail/kbuild-all/2015-August/011216.html
> 
> This is a temporary patch and is only needed while the hfi1 driver is
> in staging. Remove when moving driver back to drivers/infiniband.
> 
> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
> Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
> Signed-off-by: Jubin John <jubin.john@intel.com>

Picked up, thanks.
diff mbox

Patch

diff --git a/drivers/staging/hfi1/Kconfig b/drivers/staging/hfi1/Kconfig
index 87a385a..78bc89e 100644
--- a/drivers/staging/hfi1/Kconfig
+++ b/drivers/staging/hfi1/Kconfig
@@ -1,6 +1,6 @@ 
 config INFINIBAND_HFI1
 	tristate "Intel OPA Gen1 support"
-	depends on X86_64
+	depends on X86_64 && INFINIBAND
 	default m
 	---help---
 	This is a low-level driver for Intel OPA Gen1 adapter.