| Message ID | 20150916064225.GI5004@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 09/16/2015 02:42 AM, Dan Carpenter wrote: > The cinfo struct has a hole after the last struct member so we need to > zero it out. Otherwise we disclose some uninitialized stack data. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks, applied.
diff --git a/drivers/staging/rdma/hfi1/file_ops.c b/drivers/staging/rdma/hfi1/file_ops.c index 4698617..2c43ca5 100644 --- a/drivers/staging/rdma/hfi1/file_ops.c +++ b/drivers/staging/rdma/hfi1/file_ops.c @@ -1181,6 +1181,7 @@ static int get_ctxt_info(struct file *fp, void __user *ubase, __u32 len) struct hfi1_filedata *fd = fp->private_data; int ret = 0; + memset(&cinfo, 0, sizeof(cinfo)); ret = hfi1_get_base_kinfo(uctxt, &cinfo); if (ret < 0) goto done;
The cinfo struct has a hole after the last struct member so we need to zero it out. Otherwise we disclose some uninitialized stack data. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- v2: typo in changelog -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html